From: "Nerijus Bendžiūnas" <nerijus.bendziunas@gmail.com>
To: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] wifi: ath9k: stop a failed register read from opening the RX filter
Date: Mon, 14 Sep 2026 05:25:57 +0300 [thread overview]
Message-ID: <20260914022557.1141231-1-nerijus.bendziunas@gmail.com> (raw)
In-Reply-To: <5f892b6a-7c02-483f-84c3-43c1161ef251@oss.qualcomm.com>
On Fri, 11 Sep 2026 10:06:21 -0700, Jeff Johnson wrote:
> On 9/10/2026 6:46 PM, Nerijus Bendžiūnas wrote:
>> +/*
>> + * Set bits in the RX filter without reading it back: on USB a failed read
>> + * returns all ones, and writing that back would open every filter bit.
>> + */
>> +void ath9k_hw_enable_rxfilter(struct ath_hw *ah, u32 bits)
>
> there is a standard for kernel function documentation
>
> https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html#function-documentation
Thanks, I will change this to kernel-doc.
Per Toke's request on the cover letter, this patch and the other ath9k
fixes will come back as one series once, with the dependencies and the
testing explained, rather than as a v4 on this thread.
Nerijus
next prev parent reply other threads:[~2026-09-14 2:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 1:46 [PATCH v3 0/2] wifi: ath9k: fix the RX filter handling around spectral scans Nerijus Bendžiūnas
2026-09-11 1:46 ` [PATCH v3 1/2] wifi: ath9k: stop a failed register read from opening the RX filter Nerijus Bendžiūnas
2026-09-11 17:06 ` Jeff Johnson
2026-09-14 2:25 ` Nerijus Bendžiūnas [this message]
2026-09-11 1:46 ` [PATCH v3 2/2] wifi: ath9k: clear the PHY error filter when a spectral scan is disabled Nerijus Bendžiūnas
2026-09-11 10:28 ` [PATCH v3 0/2] wifi: ath9k: fix the RX filter handling around spectral scans Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260914022557.1141231-1-nerijus.bendziunas@gmail.com \
--to=nerijus.bendziunas@gmail.com \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®