From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8BAF3E3C68 for ; Mon, 14 Sep 2026 07:29:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370987; cv=none; b=AoNiDeqFPUV2xnPjjdQiaKjPA3EZadXV91vMp9htgCd9iSjr+kXT/42AZ+rQd8NgP1EnUr5qXQOzNVPhPktymSlIkCxksKgsI81ocYyyw2UuxqyQ4Uydt104SRh0pYr0v5ZWLtFfv1hEgWt5koqtf01jPJjf1yOBj+/r9RUviQQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370987; c=relaxed/simple; bh=yVHr58+jpi0ogaZaNb/vAEA+UBaGvyzAgPcg7m3FJUI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QmntaViY1mrkiowZhH3VY9atL6cifExGQIlpgQc3zRWAS2PHTt58BENpAY4IxMlq/eSLGA4WMl90XU92FiEQxPM22vkzYaRdKqjlFr51e4pok5j0WyBEimSC/1QQwv6Amg4okgC5mcwXlzfZ+G/j2S8hbRPV/kmLiaF3rTh/D4s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aIONortY; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aIONortY" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-381b831d535so5576492a91.0 for ; Mon, 14 Sep 2026 00:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789370985; x=1789975785; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iLuGPJOul88SFkcVl5PHBDFHBc0tVdx0/BNU/eqBS78=; b=aIONortYejgKrJlCywY3/Bg7Ua32BwTy3UUecesz3flUVbpA30rWIUWmb5Fjv0zqgp pNJB11SWkcdMtrOtxjoL9RXTe7OBf3PIXc7DxkqOdIawO18TqQmZhP4bG59x8dm2nSLE AmuSE29p0LjYmLhaN5iT1ag7QlMUmklZ1diAeFAMLeBNta7SKIWLmcXQpL8WW/0Y5WFZ IBIeUxEnw56wOEegj84o5jN0l7q8TvNsnqiWnkySyNzZz2TmuiJPKEFW6EmaBluwo/0V v61HwiakXDNgWNkooWZHfMa7MdIMvns9d9V5hMOFWBq3yLUdLu645y1PcRYQDv7vV+M0 Rryw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789370985; x=1789975785; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=iLuGPJOul88SFkcVl5PHBDFHBc0tVdx0/BNU/eqBS78=; b=nEz/LOt3bfaR3ZxakybtRwSSLTlmayazqefYAGORO9PbKkf28UEL1MZH3hWNQSqHan 0zGPm9eYN5hrYGWo+86RHZt0WylyVqlZQgqtiNFItmOQNxaedDVAL9+iQuT4efBmFD24 RnKgeO+F+E/qFlE5PyNVgPZdaBALkeb3CP7y6mXOiPmlNqp3CgW22ns/IQaOl4Uz2gUH dFG9CfG0kBzgbh1eamK+wLYmbCqYbB332MlazrXCKwVFdM7zYpwfS5oK7cPpwNKd/NT2 HQ1cZe9ibZEzywiCoR+xhtWar6TRpuuld4JWgzb5hmcMkXnK7nzS3e6lo0zO+rR1+TAP 40Bw== X-Forwarded-Encrypted: i=1; AKwUvBxufomES7zRMORX7FGHKDOZ6c6aotpilEnUkZVUSmMYwkARMxkLeppE8te846DCQWy0VINxUA4GIL59qWw=@vger.kernel.org X-Gm-Message-State: AFuF++nG/L7yQbTD5gT+1UBlAPPL9AW4cx0Y5+T6p+iZ9UVnXHBUG714 a/UJW5iQgXWInmcwalYpC/BccwA2RR7u4LlnsMifCpjzlGttmoYc9m3X X-Gm-Gg: AYBFou2tsk8zaPtHFSCVU2wptw31BGAsZbPcyd/RQn9tXRO88AhigInG4ZqxZ4tbVD9 vqxY9b9eR7OaTdMT+YoAo6T2gDMSdOTpl77Y2gYVMziHYMT24y5oHSDVwJbvjV9ZeYeXw337+5M sJzIvg0ok/rZKN2iOD44i74XlB1QG6P4xrqmS4fohQV8rrWOIJyvIUdzNL98xO3Imk3Db6ZK0ok RbHQ56H8lL6Chet3Ypyz+Oin8YJJVm/IB8JVOd71U8RUjXJ41Z2OsiT00tri8aMi+EO51ChR1mR 3gBumFkXo4+KBIxVnDv+pcsnuuiWP/2DZBVfcrEKuYsCFUGeaRKkiF3HbH2xU9wGcGggwlKXx3n /u1rj5KLaWaeu1ztpmBMaVSYUxmBIKma51YNgMM+1e3KHkawwamThNrtUov0b9zwAzIu5K50jC4 85c+pwszECu6hvIyS+f9Eeiddad3T5lja1ANbViaeIJssVo67hvLspxXZZQc2366Pief5SFgY54 ozCne9i30FqMrGnSp5Oxtd0lIEbZr+mDO5io2qyAOMC23/8lhdnULs89191dg1rGKogdJc/6e5d lANVGDiMpdIqjWMqaJI1PnX66g== X-Received: by 2002:a17:90b:2809:b0:396:d27b:89b9 with SMTP id 98e67ed59e1d1-39debfa956bmr3527909a91.10.1789370985063; Mon, 14 Sep 2026 00:29:45 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d957131f9sm19598245a91.12.2026.09.14.00.29.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 00:29:44 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 11/13] ASoC: mediatek: mt8189: Validate sysclk frequency Date: Mon, 14 Sep 2026 14:28:40 +0700 Message-ID: <20260914072842.24420-12-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260914072842.24420-1-phucduc.bui@gmail.com> References: <20260914072842.24420-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc A zero frequency causes a modulo-by-zero error when validating the I2S clock frequency. Reject it before performing the validation. Fixes: 7eb153585598 ("ASoC: mediatek: mt8189: add platform driver") Signed-off-by: bui duc phuc --- Changes in v2: - Check for zero frequency since freq is unsigned. sound/soc/mediatek/mt8189/mt8189-dai-i2s.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c b/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c index f20dbb410223..2202fed63fc9 100644 --- a/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c +++ b/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c @@ -1286,6 +1286,9 @@ static int mtk_dai_i2s_set_sysclk(struct snd_soc_dai *dai, dir != SND_SOC_CLOCK_OUT) return -EINVAL; + if (!freq) + return -EINVAL; + i2s_priv = afe_priv->dai_priv[dai->id]; if (!i2s_priv) return -EINVAL; -- 2.43.0