From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D46B3E8328 for ; Mon, 14 Sep 2026 07:29:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370974; cv=none; b=ZCYAcekmmv1gNjSc+qycYDVzxDaaPUv3MDroolWOhV26UN5OgYx1VTSuN0NEpZNwhNmyun253d5njsxXqiU4ioZfGni10i25eUqilYXWmB+5QQX8iL0vDGdOf242A3IsSjgHxAYSSmeSaJ3ms4kaRejEIFtbGmVTq8FwGJfnLXQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370974; c=relaxed/simple; bh=yOM3Ftr+tZ+A5ui4+ZQHA4pRO70m1aCA1F6hMr5fOqY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KrlnNDx/PBTLyYviQL+BFKvKYRc0sjkeoZrmPZlLqd0ldWzrvEOffcFzVNvUauSu5nh4YV0Fd2ceSY2isFh1b9lxFPSJNwR2KN2By1BT1hDCXSjkbYhCvlbKxWIx0nate3ic3lNb9KUK0gt1HVv6soO4pQQ4F1pdcUs3toXtAN0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LNdjVXis; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LNdjVXis" Received: by mail-pj2-f12.google.com with SMTP id 98e67ed59e1d1-396ccd66bb5so1381929a91.0 for ; Mon, 14 Sep 2026 00:29:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789370972; x=1789975772; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kvhy8CjCHaEUNOyzqez3eokLT1azbHniSOhw40sTHWA=; b=LNdjVXisSUAw5dGg7GymYf40hNE6JRhnpXn5mA5waTNlGrXVHbgO6UVZHmm4gSpy/I oSoANvg/MbKLpepRdsq2lUqlPiPXSVThMvNHqdhbNArnJMG946liup4nDTLqBMCSR8HW sJ0o4uK9faIzoaf9935/nWNdFJKqZ/D5me3JCs7lSiTGGi/isIM65sE2v/rEoxKVeUZZ rlT1FCZI8SSYKXT3HD4X1CGQZhPUhGqYvO9dcxzme95YT6Z8qeec0hbL1n+qALgRra2h fWI1wyeyHe6AdTPld2vy+4oYzIe8ip7vwoCapDqsboaw7Yr+1ByRQRYU9hWov143LdRT gyHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789370972; x=1789975772; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=kvhy8CjCHaEUNOyzqez3eokLT1azbHniSOhw40sTHWA=; b=lUtz0oaM6Tz6vb0quSzj2UcVbgVsubuJiywQVNkemEPAGnA4HOwE80NVi6wG1wvHUq jv7OhFZUpn5JI+xBTV5G0DMbnCdJHxL51Q1ojAITPvwCyRRsqcDX3c64NNRCl69oBpWl WXIK4OOtThfJBW+lgdBJdeT7LP+FZo3FE63dhXgdhmdZDtuIPqtnVCk11JYVHp5rr6Jy CdT6gkFRh6WDDEQXaSzyXePAL7soXtpMHAgNQrj/z9cmnpeYHPZFlqSjzBHIa4DanzEg LKAS9T0Hx0To0c+QV6GLv7p+lQfNO8iFjhxlMGAKchZCtW/Pem0UzGS141rJqg5EO0Tt puKw== X-Forwarded-Encrypted: i=1; AKwUvByIb/b5YHCPvnr7/yUGTdgb0A+fEwEbQNmIOuwC9QEI3JBo7IDWvbE1hC5N8Ih8otVp+ZUqW2KDSjFDsmU=@vger.kernel.org X-Gm-Message-State: AFuF++lTPMjmBtEMMESXHOErEC+s2NpkobOcNIvaVH+Sa5uNnvGtwC0c 0e8uyMEiTRj9UyXjXIsK86pqmykcnmFixEeocNs2rE49xIQOmnwjsFmT X-Gm-Gg: AYBFou0lxB3P8Y3MPurXiqH/KWAhM7Qc++yCwJ8yPreKvCeyX9GSH+Cvq23D+yg68ky yGjwEEwijmAaTPEkLC2OiNbCnZMuolXHTIPBkWBbjC3uEHbHdvTLJ3XVvKT39xzXYtOWQ/P/D3D tMkHvDi7ix6YmzS4tKneEMqnmykdrLnDS1/IBzuL2HeajOy9Jzb1WWGwhDs6RMqqjBPAoKsBuxt Ctv4XWQE/n+c8XNhbNWQcu2KgDcOaHvEqygvyCeOG0wUrEMX6MDA8A+28xt6Q0XlmjX6OW8qrV4 P/mQxAbzDxTYCUps+s68mENtp3iSVs2WUxAspkydnkZphZNU9y6s24A3hGR7t4fHOZXLL2wwY1O qWxReAlTD4VRVjDBsQvGY9kb2U5B++zpsX+HMd0cAgbnsyM1ENkuddj1xztqcQgOBC6B27Yx1et QMNsaZMurHE+OEPiswhxgS+6w/vfChi9s4EWyY8en3GDP9uOY/rZ0b03xW5MwfQbV6LUHYJR8mF 2f1rEgx5QEs7OjjCIAC/x3AEqgZO0foasxEQIwp7bKPac6yyQxhwwJSTPB/hxVpXN0S9LpRQjzj ItIhnN2WFQzqOm5/z+BPn02fMg== X-Received: by 2002:a17:90a:1189:b0:39d:f064:3a76 with SMTP id 98e67ed59e1d1-39df06469efmr944725a91.15.1789370972413; Mon, 14 Sep 2026 00:29:32 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d957131f9sm19598245a91.12.2026.09.14.00.29.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 00:29:32 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 08/13] ASoC: mediatek: mt8189: Remove redundant error message Date: Mon, 14 Sep 2026 14:28:37 +0700 Message-ID: <20260914072842.24420-9-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260914072842.24420-1-phucduc.bui@gmail.com> References: <20260914072842.24420-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc The errors handled here are already reported by the called functions, either directly or deeper in the call chain. Therefore, the additional dev_err() and dev_err_probe() call is redundant and can be removed. Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8189/mt8189-afe-pcm.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c b/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c index 67fa40afdefa..981e660981e3 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c @@ -2488,13 +2488,12 @@ static int mt8189_afe_pcm_dev_probe(struct platform_device *pdev) afe->base_addr = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(afe->base_addr)) - return dev_err_probe(dev, PTR_ERR(afe->base_addr), - "AFE base_addr not found\n"); + return PTR_ERR(afe->base_addr); /* init audio related clock */ ret = mt8189_init_clock(afe); if (ret) - return dev_err_probe(dev, ret, "init clock error.\n"); + return ret; /* init memif */ /* IPM2.0 no need banding */ @@ -2528,13 +2527,13 @@ static int mt8189_afe_pcm_dev_probe(struct platform_device *pdev) /* request irq */ irq_id = platform_get_irq(pdev, 0); if (irq_id < 0) - return dev_err_probe(dev, irq_id, "no irq found"); + return irq_id; ret = devm_request_irq(dev, irq_id, mt8189_afe_irq_handler, IRQF_TRIGGER_NONE, "Afe_ISR_Handle", afe); if (ret) - return dev_err_probe(dev, ret, "could not request_irq for Afe_ISR_Handle\n"); + return ret; /* init sub_dais */ INIT_LIST_HEAD(&afe->sub_dais); @@ -2603,10 +2602,8 @@ static int mt8189_afe_pcm_dev_probe(struct platform_device *pdev) &mt8189_afe_component, afe->dai_drivers, afe->num_dai_drivers); - if (ret) { - dev_err(dev, "afe component err: %d\n", ret); + if (ret) return ret; - } return 0; -- 2.43.0