From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C44746D0B6 for ; Mon, 14 Sep 2026 21:10:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789420259; cv=none; b=RbZBqeSwlFzHfTY9CyFgRXE5JmeQFoMdp23DsT8Ci1w4sDRy/fo+mg++C4Hx//JI2Y1ZYizHE66ARZnpHtDCw/4BA208MOE0MXU44WbkZk8cFsXpk3ugxLz4/vXp8BcKTw6R/3WxhalitkjwEWjK1UAgW2CREq8XSPvYjyopY5s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789420259; c=relaxed/simple; bh=Wq4dzX7G0MYHQpVoOYjnieG6feoqecTnIZTO7wV2B34=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pnx2VGN7eyBgP/MPKUug7zQEdDHI1ojzH5VifTnzXFhQDoVUzeAI1J7UDNEB8XpI7bXi6K1dhxrdo6bdGajHiQKAjBoBxDEEiFDTB/m2ffdzBBcelmB+zrJJ8lVUlLLJdEC117YjifmXXprsuc5U7awc5MeBXGQwJ5IuImhXEHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Jp5eldK1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ITYVEI6D; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Jp5eldK1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ITYVEI6D" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68EJYgBn844359 for ; Mon, 14 Sep 2026 21:10:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= p6Z+iVYBfNSCWeowkj5JZHLt7Ogk7p4zAvjEwB8LuWA=; b=Jp5eldK1rwlCLxUp UueWoBWXJgmhAxxZJbDltJvMEbBuiTjtK+F/MeWcjuF4gubumkmh57uSxH+MX7tl vZz6R+KGE8WbZmx+q3oRl+rQj4GSWwpIeULX1PFCku1MK3ZPZN5d8irum5GMz1dy OoFPCwDT2JNDfaUy395rlFi6j3RpYpHyYRdrJdOgpy3JiuD2dmOCdBP9vk85cPzc RIqY0WvNdBK2xRW+2VAxM9ebWX2Z97SDc3x1/+prTV6v3JbpWM4j/7UF8NkcrRlr XLYHEMURqdiCPlZR5n5IKrFFaB5sNZGm1LFBo0El16giNTPDBmQowztDnvJkJsrI fWMccQ== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gpd1f33g6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 14 Sep 2026 21:10:54 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cc4c1fc9ceaso3059698a12.3 for ; Mon, 14 Sep 2026 14:10:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789420253; x=1790025053; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=p6Z+iVYBfNSCWeowkj5JZHLt7Ogk7p4zAvjEwB8LuWA=; b=ITYVEI6D7eMZYMukZDwQfKWMD6iIECYQj7e8CgNRmZj4711JIC64gM2IPHOt/r6+W3 hsb/6NDdff+771jEKBWJq3YUIW7JiRg3R136UX9H8LcX89ZKpQFmYvrOCoUyvUaGYYTX i2D8lWx30YUeriBZYGsDOK7Yxs6jwIiQFHhoYXHR2kv3ivQpXwmwxSy3aHJyZgV0dZfF kgpawJkOAeKEvbiz6g/n0enaN2EhtpxbQ1bhL/i+yeQ0dxIFsiAqaMJFVga/rK4PX/fG ncoGb6ON3x26Uewt63TAppQodq9bt32zVFQnVHdrsh9iAHkK2P2UsWinLc8Y0OPq8KBy whwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789420253; x=1790025053; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=p6Z+iVYBfNSCWeowkj5JZHLt7Ogk7p4zAvjEwB8LuWA=; b=24M5CK5mtrSt+waaR/zlb+UR33HUWZ/+ar9S4PmBniw214hTtWQDPAz7e5dol6Tm/j XUnUVMoGkKKhkJpTetBaxcrmc9aawL/Nae9BLDkcoR77jXSvRh5dHxJOgKPIZ2PIPBMS qM/w8lkmu3yLbokvwjxCjcUAban4ecOlyDEPVlyh2EVjOqW8NGRNK0ujs86bjCw7FzPL USuaPMKA2XC/R2+SO4WrPdHo27IS/wfhgO8kxBsMPc982Kpfg4q9kum1l1tPBlQcxJDm fu2qYS0O9yMRaw5PF/jxOq4eLQXq+SStPbptL5xWXXpKwe7WGNIAfStsVrWxhbyo9u0c 8SKQ== X-Forwarded-Encrypted: i=1; AKwUvBz5lQ3GLC3maF0zjEb5P/1ANafr/2DtgdRg1IsnDDIwX1ZvHlP77E4hrnvChtCOCUj0V84ZP9aFRrJiUY4=@vger.kernel.org X-Gm-Message-State: AFuF++luLlsfR+va1N3YgRT1tXDu/AdHNakvGDnyfeiTasD3w006VYkF 8aBbb1aOS9zEoq42VMxGAtCODb/28GUGaLSFTgKjMF5sn4J45KODc7FWy06DdZILzQGO2WIEzXh 43AhCldMDbjZrhmo+Sxcyn0pJkjaXrVyiiYHmJHw8ld/KTz1vHKYPXpkUDHffV4zneRo= X-Gm-Gg: AYBFou2ybYU3x9z339sqNU5QX0+8IkdzVTvkV0Md5VpE42sVX0dtdmX7ZaSq9pGAyTK eeAFSwZhohOzW/NMGqRQydnM2BRgSyVP6qJnurPMl8SWkBNlHKr3OxZljzEMaxuir3TRJvkWen0 9KJ+5FC09OJ1RtwV3kRJYE6yprziZdqMpgI0axpUm44EJmRvz/Pm00yLqK2wfuvVhqQIAKg3KsS cSMasCf6aTpCkSFl06wvYD1hoaTjCzAe1LmaPYN151yZrEENOGtwZKl+H06Yr4vCEedZ/Ix+SbB y1EJ1KXCyCUmECgb4lnENSwUF1Dt4aJ/wn1jGw2tQhtuPbcAMz77N+4vS+MCwy7xiPyBp+z2/+J KfvfTd21qOOnLENlJxv5f5V2TElU= X-Received: by 2002:a05:6a20:7344:b0:3bf:6d96:ac40 with SMTP id adf61e73a8af0-3db40480717mr8952842637.12.1789420252907; Mon, 14 Sep 2026 14:10:52 -0700 (PDT) X-Received: by 2002:a05:6a20:7344:b0:3bf:6d96:ac40 with SMTP id adf61e73a8af0-3db40480717mr8952794637.12.1789420252504; Mon, 14 Sep 2026 14:10:52 -0700 (PDT) Received: from localhost ([50.35.44.179]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-14365b347e6sm25355458c88.4.2026.09.14.14.10.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 14:10:52 -0700 (PDT) Date: Mon, 14 Sep 2026 14:10:49 -0700 From: Jonathan Cameron To: Nicolin Chen Cc: , , , , , , , , , , Jean-Philippe Brucker , "Eric Auger" , , , , , , , , , Subject: Re: [PATCH v4 10/15] iommu/arm-smmu-v3: Support PRI Page Request in arm_smmu_handle_ppr() Message-ID: <20260914141049.000077cf@oss.qualcomm.com> In-Reply-To: References: <178908564507.2841562.6430226716089872094.b4-review@b4> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: XRteWxXf3yvxuxOuAoH_jBXxfJXdAmF8 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE0MDMwMyBTYWx0ZWRfX+zy2W6ktsY76 r4FPx1kOTitu+Nnef8cTBfvMGFU6YGOmfFqP/caqDGJPWazUpx6VgRV+MVW+29U3J/Q415hQosH h9t+FRrZKZHshNU1ek0KecofpoXOEzY= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE0MDMwMyBTYWx0ZWRfXzvPvCnvV6VQR N2fDMR92PtU+PowRHBy2jIlfvKLRx0QjScoae79fPOOxinwo+/mlVnYc9K10Y3XI9o2XePoI8fL GHNA3/QbEXIATDHQCQ6IIptKoSKrxyj4kzeVJI/e6QEwDZIVe0AkIa2G/BNkCj3nH7+cxU3avEM prsTMisi2sM2WVbBuJtcXhecM1TeMAzLUoBo7J7ytXyyMwk3/8KSm1xPsHgV1u5ZIt+CU6o8o9D Mq90221+usLkCKzv0sY+95sPRSIig+9DhHJsIB91mzXCbQX4cezt3Y7dnLeKAHpyDsSsQTagWE2 agk/jlBGNfddo+fdBBQx5iHgTSlDBeoRClzcr6pGtF9VP1IDCvpS6D7/Up7eTcJZ+f+sh8ioLRc ZuqY2W3e+jl2x/lCRNXAsHOMyWe2X92XhOea9dXBIxNOe5qEew2n3xJ/U5K+gOWfcZWf++vKOuQ 3Qdhp6SaG3UeqDh232Q== X-Authority-Analysis: v=2.4 cv=XKel2ghE c=1 sm=1 tr=0 ts=6aa862de cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=aNnz9XPx1a4JIXSYt2cE/A==:17 a=kj9zAlcOel0A:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=Ikd4Dj_1AAAA:8 a=HAQNk-a_8tHaYfDPudEA:9 a=CjuIK1q_8ugA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-GUID: XRteWxXf3yvxuxOuAoH_jBXxfJXdAmF8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-14_04,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 spamscore=0 bulkscore=0 phishscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609140303 On Fri, 11 Sep 2026 16:16:02 -0700 Nicolin Chen wrote: > On Thu, Sep 10, 2026 at 05:14:05PM -0700, Jonathan Cameron wrote: > > > @@ -2380,9 +2381,47 @@ static void arm_smmu_handle_ppr(struct arm_smmu_device *smmu, u64 *evt) > > > last = FIELD_GET(PRIQ_0_PRG_LAST, evt[0]); > > > grpid = FIELD_GET(PRIQ_1_PRG_IDX, evt[1]); > > > > > > - dev_info(smmu->dev, "unexpected PRI request received:\n"); > > > - dev_info(smmu->dev, > > > - "\tsid 0x%08x.0x%05x: [%u%s] %sprivileged %s%s%s access at iova 0x%016llx\n", > > > + /* > > > + * A PASID Stop Marker (LRW = 0b100) does not expect a response and > > > + * must be discarded before fault reporting: see the documentation > > > + * at iommu_report_device_fault(). > > > + */ > > > + if (last && !(evt[0] & (PRIQ_0_PERM_READ | PRIQ_0_PERM_WRITE))) > > > > There is a bit of spec language about case where there is no PASID > > LWR=0xb100 not being a stop marker, SSV == 0 and should be treated as > > a PRI request. I'm not sure what that means in practice but maybe > > a comment on why that case doesn't matter. Feels like breadcrumbs we > > might need in future. > > That's a sharp one! I didn't find any the practical action was > suggested either. > > I wonder if we should let it fall through instead of a return: > > /* > * A PASID Stop Marker (LRW = 0b100) does not expect a response and > * must be discarded before fault reporting: see the documentation > * at iommu_report_device_fault(). > * > * Gate it on SSV, as without a PASID that same encoding is a PRI Page > * Request and it does expect a response. So let it fall through and be > * answered with a PRI_RESP_FAIL, since iommu_sva_handle_mm() rejects a > * PASID-less fault, or by the PRI_RESP_DENY issued below. > */ > if (last && ssv && !(evt[0] & (PRIQ_0_PERM_READ | PRIQ_0_PERM_WRITE))) > return; > > Thanks > Nicolin Works for me. J