From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F5FC477286 for ; Mon, 14 Sep 2026 14:40:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789396815; cv=none; b=izXM4t95Sl+d7RyhPg+sWkE7Sv2ceJG/xydp6SfgvM183+qdOp2pfkNyTKyuhKcQ9pgGSntvYZF5M26EY7n3mQbdAqRt2yB07Frik4i8sX52GKcY9JJ2F3KX3JaOcvdDOHWchu3EiM57c+Y/YaYo8nkk9bQ5+oKG6DXsTIMeEQM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789396815; c=relaxed/simple; bh=PchcDlD3Npn6+8wPRM9VRYzNcIBmakxNDUNZLTTsXSk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tbl2zjSUeTzde1UF36EWiN16m3X2l8XtG+vULJfqFiUV73u9kf/T2H5yEY/NPD20lzyx2F7GSKuSlcQwsgeDRQphlWf+7KpaOsJdHPNgPfWR/6K12W95v10DOL47T6vnErP8JTz+HiKfewDmN60Ja20h8hYmaDmd/Cue5uln6Ow= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ov0r6epr; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ov0r6epr" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-cc1bc88a20eso4568114a12.3 for ; Mon, 14 Sep 2026 07:40:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789396811; x=1790001611; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/kBzFP/HpzVRM8R641fR3ZeSCydIAXhP1zBP9Whsejw=; b=Ov0r6eprPvy5QIg7aXFGexQt7qTAriSmaBWATxy4Hh21HAuE+6xqi2/GyTSgJYCSl4 jMyGe6Gh7XfR//RWndf7ZJ+jl1/x5D8G5vsD37O4c4BH9+IIVqhaeIjzbvrsnf2VwO1f A2kO+k+NrcWt9xFCuMMKu9i1Pdep0F5v18C6lPs6YPvXInVCLZ2rHMK8CLWXRqq+hn+H 5SnDb9Xde0En3NWVatWPp+sHv+mEJ5WVeoq+WV2cNn5lRBAQM5uYrrxGtpkCjN836+fw L1LwZGedZSFoyFU1lBTx/HYGGXO7QAG9DyW1NrZYwxGk+VUaqYXbAoj/7Xotqk5K2+44 VscA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789396811; x=1790001611; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/kBzFP/HpzVRM8R641fR3ZeSCydIAXhP1zBP9Whsejw=; b=jmr11ncCPVfsZ0+ikgsfwGFopiA5bFWj7GsW1Yxi21nSHcFbNIz6JJb0w57LFEri2t Vdc1mmxH76aUbY45g9+ZRiyuFx0y5eUG9USYFlFKepTLHfSvVPOS2V0U0eHVKPVYZFfD mIQ2mlOBO6oSzDZxH5tkvCp+Q5G/SLuru3cwdrlEhtzidP1pDgn7W0wnltIyq7xBlJzh Zm4IsFJWJ4PSZiRbZGuTCCZSk3aubDSytKr9/Rv0wgcwbtio9dY2NdEGIJycjF083zdq zgQlXCB6ukRUKM38ozQaVt1Q9Aakkd7PVmKL+VEU1W/zgQ7llMpii535B0N9zl6+l9uM vbxQ== X-Forwarded-Encrypted: i=1; AKwUvBxwRMxEImKJR/AQqyzVxSqC/B+nJELRQaVxy6gwO6K8G8CNVEt5HaKBUg9jCeric4jWoaSW5iah9bHirpY=@vger.kernel.org X-Gm-Message-State: AFuF++kSEPSV2KNGkOOY17MMaJyTE8A0q6zCaXs90x70J5LQ+UbigAs4 dTuW+HAabSN4Is/f8p99RkLk93Q2yFRlG7sSk/5dA/nWXMVvj4Ttcec6 X-Gm-Gg: AYBFou2nQuSMIeotdiRd4U7WWyJp/pOHgkJFJ2PmDSfojwCYZm7Vq6qBOR0rGsDiSiq Amz9a9EjDMuLQPtVgZY5+fNCEaVfiixCb8d5EVo9ZYohAthASw+vePXZsuy71nSOY7nEd0oNEay URUnFFOitvKFQdCti4bYB1r/h8tuGsAqEFWJMKLJ2m/hPAl9dAN9YT2whPrTZH2QlFs7/zoyFV9 MKeE/aJvJ0nOx2RlkPH4d835EsYAD6/2IilCjt+mt9EEaFa8lYsh5KQ99I7sl0lS5piXQR9ezbd 1P3QQQbx2Vxc1/HTHOavUn1QD8Ugf/KSC6teD2Yq3I0NKDcLsV5FopLuOwxnijHINUWumVb1Geg LrvF5szDshzVeoPN/YR3/ovSrHVqjpExjHHKN5UQCba2z03sAs2Yc2RnCp8xbF0DJzzuoVM6Iv4 8BAffPfSEB303/hxk7ZGZ6+Kpjh66DDXJ8vsZ7F2xHV/RNeg4F2kTxOk1g0b7tsmR4c0jw9Psf5 pRfR8Hb7MUe0FF5DQ== X-Received: by 2002:a05:6a21:4d06:b0:3da:e1b5:2baa with SMTP id adf61e73a8af0-3db404b4e1dmr6402183637.2.1789396811120; Mon, 14 Sep 2026 07:40:11 -0700 (PDT) Received: from kernel.tail6741c6.ts.net ([185.220.238.35]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc4c6572ecasm5149444a12.22.2026.09.14.07.40.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 07:40:10 -0700 (PDT) From: Kunwu Chan To: paulmck@kernel.org, dlustig@nvidia.com, joelagnelf@nvidia.com, corbet@lwn.net, akiyks@gmail.com, luc.maranget@inria.fr, j.alglave@ucl.ac.uk, dhowells@redhat.com, npiggin@gmail.com, boqun@kernel.org, peterz@infradead.org, will@kernel.org, parri.andrea@gmail.com, stern@rowland.harvard.edu Cc: linux-doc@vger.kernel.org, lkmm@lists.linux.dev, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, rdunlap@infradead.org, skhan@linuxfoundation.org, Kunwu Chan Subject: [PATCH v3 2/2] Documentation/litmus-tests: Add SRCU fastpath scan-before-anchor test Date: Mon, 14 Sep 2026 22:39:42 +0800 Message-ID: <20260914143943.1503066-3-kunwu.chan@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260914143943.1503066-1-kunwu.chan@gmail.com> References: <20260914143943.1503066-1-kunwu.chan@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If the synchronize_srcu_atomic() fastpath instead places its lock scan before the grace-period anchor, the scan can miss a reader whose increment was already visible before the anchor. That reader already existed when the grace period started, so completing the grace period without waiting for it would violate the SRCU grace-period guarantee. This litmus test models the reversed ordering, with the lock scan placed before the grace-period anchor. "seq" models the grace-period anchor in ->srcu_gp_seq and "ctr" models the per-CPU ->srcu_ctrs[].srcu_locks counter. P0 scans the lock counter before writing the anchor, with an smp_mb() between them. P1 models the reader-side counter increment and its smp_mb() from __srcu_read_lock(), which orders the increment against subsequent critical-section access. P2 models an observer that sees the reader's increment before seeing the anchor. The same outcome is allowed with this ordering, and herd7 reports "Sometimes". The litmus-tests README is also updated to describe both SRCU fastpath tests. Tested with herd7 7.58 using linux-kernel.cfg. Signed-off-by: Kunwu Chan --- Documentation/litmus-tests/README | 21 +++++++ .../SRCU-fastpath-scan-before-anchor.litmus | 56 +++++++++++++++++++ 2 files changed, 77 insertions(+) create mode 100644 Documentation/litmus-tests/srcu/SRCU-fastpath-scan-before-anchor.litmus diff --git a/Documentation/litmus-tests/README b/Documentation/litmus-tests/README index 6c666f3422ea..f96eeacb002b 100644 --- a/Documentation/litmus-tests/README +++ b/Documentation/litmus-tests/README @@ -78,3 +78,24 @@ RCU+sync+read.litmus RCU+sync+free.litmus Both the above litmus tests demonstrate the RCU grace period guarantee that an RCU read-side critical section can never span a grace period. + + +SRCU (/srcu directory) +---------------------- + +SRCU-fastpath-anchor-before-scan.litmus + This models the synchronize_srcu_atomic() fastpath with the + grace-period anchor ordered before the lock-counter scan. This + ordering prevents readers that existed before the grace period + from being missed by the scan. See + SRCU-fastpath-scan-before-anchor.litmus for the reversed + ordering. + +SRCU-fastpath-scan-before-anchor.litmus + This models the synchronize_srcu_atomic() fastpath with the + lock-counter scan ordered before the grace-period anchor. This + permits the scan to miss readers that existed before the grace + period, violating the SRCU grace-period guarantee. See + SRCU-fastpath-anchor-before-scan.litmus for the opposite + ordering. + diff --git a/Documentation/litmus-tests/srcu/SRCU-fastpath-scan-before-anchor.litmus b/Documentation/litmus-tests/srcu/SRCU-fastpath-scan-before-anchor.litmus new file mode 100644 index 000000000000..d8808571063f --- /dev/null +++ b/Documentation/litmus-tests/srcu/SRCU-fastpath-scan-before-anchor.litmus @@ -0,0 +1,56 @@ +C SRCU-fastpath-scan-before-anchor + +(* + * Result: Sometimes + * + * If the synchronize_srcu_atomic() fastpath instead places its lock + * scan before the grace-period anchor, the scan can miss a reader whose + * increment was already visible before the anchor. That reader already + * existed when the grace period started, so completing the grace period + * without waiting for it would violate the SRCU grace-period guarantee. + * + * This litmus test models the reversed ordering, with the lock scan + * placed before the grace-period anchor. "seq" models the grace-period + * anchor in ->srcu_gp_seq and "ctr" models the per-CPU + * ->srcu_ctrs[].srcu_locks counter. P0 scans the lock counter before + * writing the anchor, with an smp_mb() between them. P1 models the + * reader-side counter increment and its smp_mb() from + * __srcu_read_lock(), which orders the increment against subsequent + * critical-section access. P2 models an observer that sees the + * reader's increment before seeing the anchor. + * + * The same outcome is allowed with this ordering, and herd7 reports + * "Sometimes". See SRCU-fastpath-anchor-before-scan.litmus for the + * opposite ordering, which forbids this outcome. + *) + +{} + +P0(int *seq, int *ctr) +{ + int r2; + + r2 = READ_ONCE(*ctr); + smp_mb(); + WRITE_ONCE(*seq, 1); +} + +P1(int *ctr, int *x) +{ + WRITE_ONCE(*ctr, 1); + smp_mb(); + WRITE_ONCE(*x, 1); +} + +P2(int *seq, int *ctr) +{ + int r3; + int r4; + + r3 = READ_ONCE(*ctr); + smp_mb(); + r4 = READ_ONCE(*seq); +} + +filter (0:r2 = 0) +exists (2:r3 = 1 /\ 2:r4 = 0) -- 2.43.0