mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Murali Krishna <muralikrishna2444b@gmail.com>
Cc: mani@kernel.org, davem@davemloft.net, edumazet@google.com,
	pabeni@redhat.com, horms@kernel.org,
	linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] net: qrtr: fix coding style issues flagged by checkpatch
Date: Mon, 14 Sep 2026 16:36:58 -0700	[thread overview]
Message-ID: <20260914163658.13cff637@kernel.org> (raw)
In-Reply-To: <20260913180342.8948-2-muralikrishna2444b@gmail.com>

On Sun, 13 Sep 2026 23:33:42 +0530 Murali Krishna wrote:
> Fix several coding style issues in the QRTR subsystem detected by
> checkpatch --strict:
> 
> - af_qrtr.c: fix missing space in pointer cast, "(u8*)" should be
>   "(u8 *)" (ERROR)
> - af_qrtr.c: move trailing "*/" to a separate line in two multi-line
>   block comments to match kernel comment style (WARNING)
> - af_qrtr.c: add missing parameter names to the enqueue_fn function
>   pointer declaration in qrtr_sendmsg() (WARNING)
> - ns.c: remove unnecessary return statement at end of void function
>   service_announce_del() (WARNING)

You seem to have ignored all the automated messages telling you to slow
down. And we do not accept checkpatch fixes, please see below.

Please do not send any more patches to networking for a month.


Quoting documentation:

  Clean-up patches
  ~~~~~~~~~~~~~~~~
  
  Netdev discourages patches which perform simple clean-ups, which are not in
  the context of other work. For example:
  
  * Addressing ``checkpatch.pl``, and other trivial coding style warnings
  * Addressing :ref:`Local variable ordering<rcs>` issues
  * Conversions to device-managed APIs (``devm_`` helpers)
  
  This is because it is felt that the churn that such changes produce comes
  at a greater cost than the value of such clean-ups.
  
  Conversely, spelling and grammar fixes are not discouraged.
  
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches

      reply	other threads:[~2026-09-14 23:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-13 18:03 [PATCH 0/1] " Murali Krishna
2026-09-13 18:03 ` [PATCH 1/1] " Murali Krishna
2026-09-14 23:36   ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260914163658.13cff637@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=muralikrishna2444b@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®