From: Andrew Morton <akpm@linux-foundation.org>
To: Kyle Meyer <kyle.meyer@hpe.com>
Cc: corbet@lwn.net, david@redhat.com, linmiaohe@huawei.com,
shuah@kernel.org, tony.luck@intel.com, jane.chu@oracle.com,
jiaqiyan@google.com, Liam.Howlett@oracle.com, bp@alien8.de,
hannes@cmpxchg.org, jack@suse.cz, joel.granados@kernel.org,
laoar.shao@gmail.com, lorenzo.stoakes@oracle.com,
mclapinski@google.com, mhocko@suse.com, nao.horiguchi@gmail.com,
osalvador@suse.de, rafael.j.wysocki@intel.com, rppt@kernel.org,
russ.anderson@hpe.com, shawn.fan@intel.com, surenb@google.com,
vbabka@suse.cz, linux-acpi@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v3] mm/memory-failure: Support disabling soft offline for HugeTLB pages
Date: Mon, 14 Sep 2026 17:37:00 -0700 [thread overview]
Message-ID: <20260914173700.346dc533f1f21ef170b7722f@linux-foundation.org> (raw)
In-Reply-To: <aqiIEkrc6aDBOqRg@hpe.com>
On Mon, 14 Sep 2026 18:49:38 -0500 Kyle Meyer <kyle.meyer@hpe.com> wrote:
> Soft offlining a HugeTLB page dissolves it, permanently reducing the
> HugeTLB page pool. This can be problematic for workloads that depend on
> a fixed number of HugeTLB pages.
>
> Currently, soft offline must be disabled to prevent HugeTLB pages from
> being soft offlined.
>
> This patch allows soft offline to be disabled for HugeTLB pages while
> remaining enabled for non-HugeTLB pages.
>
> Commit 56374430c5dfc ("mm/memory-failure: userspace controls
> soft-offlining pages") introduced the following sysctl interface to
> control soft offline:
>
> /proc/sys/vm/enable_soft_offline
>
> The interface does not distinguish between page types:
>
> 0 - Soft offline is disabled
> 1 - Soft offline is enabled
>
> Convert enable_soft_offline to a bitmask and support disabling soft
> offline for HugeTLB pages:
>
> Bits:
>
> 0 - Enable soft offline
> 1 - Disable soft offline for HugeTLB pages
>
> Supported values:
>
> 0 - Soft offline is disabled
> 1 - Soft offline is enabled
> 3 - Soft offline is enabled (disabled for HugeTLB pages)
>
> Existing behavior is preserved.
>
> Update documentation and HugeTLB soft offline selftests.
I'm hitting some rejects against
https://lore.kernel.org/20260825085756.63030-4-husong@kylinos.cn.
Please update this against mm.git's mm-unstalbe branch or linux-next.
I'd updated v2's changelog with this:
Tony said:
: Recap of original problem is that some BIOS keep track of error
: threshold per-rank and use this GHES mechanism to report threshold
: exceeded on the rank.
:
: Systems that stay up a long time can accumulate enough soft errors to
: trigger this threshold. But the action of taking a page offline isn't
: going to help. For a 4K page this is merely annoying. For 1G page it
: can mess things up badly.
:
: My original patch for this just skipped the GHES->offline process for
: huge pages. But I wasn't aware of the sysctl control. That provides a
: better solution.
Which is cumbersome but I think there's useful info here so please
incorporate in some way.
> Suggested-by: Tony Luck <tony.luck@intel.com>
> Signed-off-by: Kyle Meyer <kyle.meyer@hpe.com>
v2 had
Reported-by: Shawn Fan <shawn.fan@intel.com>
which got lost.
next prev parent reply other threads:[~2026-09-15 0:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 23:49 Kyle Meyer
2026-09-15 0:37 ` Andrew Morton [this message]
2026-09-15 0:57 ` Kyle Meyer
2026-09-15 8:31 ` Michal Hocko
2026-09-15 17:55 ` Kyle Meyer
2026-09-16 8:52 ` Michal Hocko
2026-09-16 13:08 ` David Hildenbrand (Arm)
2026-09-16 13:19 ` Michal Hocko
2026-09-16 13:28 ` David Hildenbrand (Arm)
2026-09-16 13:45 ` Michal Hocko
2026-09-16 14:30 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260914173700.346dc533f1f21ef170b7722f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=jane.chu@oracle.com \
--cc=jiaqiyan@google.com \
--cc=joel.granados@kernel.org \
--cc=kyle.meyer@hpe.com \
--cc=laoar.shao@gmail.com \
--cc=linmiaohe@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mclapinski@google.com \
--cc=mhocko@suse.com \
--cc=nao.horiguchi@gmail.com \
--cc=osalvador@suse.de \
--cc=rafael.j.wysocki@intel.com \
--cc=rppt@kernel.org \
--cc=russ.anderson@hpe.com \
--cc=shawn.fan@intel.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=tony.luck@intel.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®