mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Ryohei Hashimoto <laurel.medalist12@gmail.com>
Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
	brcm80211-dev-list.pdl@broadcom.com,
	linux-kernel@vger.kernel.org,
	Arend van Spriel <arend.vanspriel@broadcom.com>
Subject: Re: [PATCH wireless-next v3] wifi: brcmfmac: log the firmware status when a connect fails
Date: Mon, 14 Sep 2026 22:05:02 +0200	[thread overview]
Message-ID: <20260914200502.1747715-1-arend.vanspriel@broadcom.com> (raw)
In-Reply-To: <20260913165526.4426-1-laurel.medalist12@gmail.com>

On Mon, 14 Sep 2026 01:55:26 +0900, Ryohei Hashimoto wrote:
> brcmf_bss_connect_done() receives the firmware event in @e but discards it
> on the failure path.  Every failed connect is reported to cfg80211 as
> WLAN_STATUS_AUTH_TIMEOUT (16), whatever the firmware actually said, so
> userspace only ever sees:
> 
>   wlan0: CTRL-EVENT-ASSOC-REJECT bssid=00:00:00:00:00:00 status_code=16

[...]
 
> The status reported to cfg80211 is left alone; changing it would alter what
> userspace sees.
> 
> [1] https://github.com/RPi-Distro/firmware-nonfree/issues/38
> [2] https://github.com/raspberrypi/firmware/issues/1829
> 
> Assisted-by: Claude:claude-opus-5

Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>

Regards,
Arend

> Signed-off-by: Ryohei Hashimoto <laurel.medalist12@gmail.com>
> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 ++
>  1 file changed, 2 insertions(+)

      reply	other threads:[~2026-09-14 20:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-13 16:55 Ryohei Hashimoto
2026-09-14 20:05 ` Arend van Spriel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260914200502.1747715-1-arend.vanspriel@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211@lists.linux.dev \
    --cc=laurel.medalist12@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®