Re: [PATCH 0/5] firewire: ohci: refactor local AT request/response handling

[Takashi Sakamoto <o-takashi@sakamocchi.jp>]

On Sun, Sep 13, 2026 at 07:13:51PM +0900, Takashi Sakamoto wrote:
> This series refactors the handling of asynchronous transactions to the local
> node in the OHCI driver.
> 
> The current implementation has several special cases for transactions to
> the two CSR address ranges on the local node. The code for detecting these
> cases and generating the corresponding response packets is spread across
> conditional and switch statements, making the handling difficult to follow.
> 
> This series first factors out the detection of the CSR address ranges and
> local AT request/response packets. It then simplifies the response handling
> and separates the request and response paths into different helper functions.
> 
> No functional changes are intended.
> 
> 
> Takashi Sakamoto (5):
>   firewire: ohci: use in_range() macro to detect CSR address ranges
>   firewire: ohci: add helper function to detect local AT
>     request/response packets
>   firewire: ohci: refactor multiple calls to fw_fill_response()
>   firewire: ohci: refactor local response packet handling
>   firewire: ohci: refactor handling of local AT request/response packets
> 
>  drivers/firewire/ohci.c | 137 +++++++++++++++++++++++-----------------
>  1 file changed, 78 insertions(+), 59 deletions(-)

Applied to for-next branch.


Regards

Takashi Sakamoto