From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F1CA3F65F7 for ; Mon, 14 Sep 2026 22:53:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789426393; cv=none; b=QVwkOffkK47J7KVC4mGRgghsg95iwNp53lELa1syA71awPkWOepwHb/Q+cbtfgA9UgsMqwOaLQx5PLDRGnfRlPTlDtsDB4ec7ivWII2lcBkfGfNa+4sVAfNhJ+wkdDVFqJDPRnRR+V+l/bZ7lnjb8eANc9o7NIL+Ofu9Sywkjoo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789426393; c=relaxed/simple; bh=ZuOq9RLAaVoK2JQN1iRsIvHe30yGLSunUDOxw5csnQE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GBfYo0dOQw0ydHepsAeUTtTs/qTRNBoiUcP4oqTDkSc6mSdDCT3UJ/PA/ylgifhPPZ3yoEJMu0yD37GkYYWP1FFMK7NhEqZrWeS0CLbW9HpJlIod0AdxWsHzgw1S/L6uFe7BIS3mqsvWAVVDnwN7fR6jUiAaqhSAeJZqIr2M4XA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KOdYmtPr; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KOdYmtPr" Received: by mail-pj2-f12.google.com with SMTP id d9443c01a7336-2d747ed1368so25043085ad.1 for ; Mon, 14 Sep 2026 15:53:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789426391; x=1790031191; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SXpVCxEknnDOBO2wgTMiDMSPtQ3J/1cRefmdmIu8XSU=; b=KOdYmtPrPd0p5M2Ao1rK3dJUTCUCQv7Ie+HD3s8ML2u9XtrWwSp4kU2LFz2Xd2M86K bnVaW4/8K5J1kLWOT6KFZn8z9FhIfIqHVCWQPDISifiFOxA0A1KRhUv5KJPtUtPcd3dA xRo6zMiVLhKIg8+LrCWhtXVjYHWS8lprCT65JtSq+BrMn1XdWLES1BkoQOh8Znyq11BD eQnnCRpYn+cd64S/ohSj147bWxgNx1J8XydzzHz1Qd4ZxbG1XmQSUIx0fkhJCkimv9UF 7Y0ZLPFfIxSf24DK3xAXqoBPAyV74euO1t239CLMvkAPSwsnU5t75lGZ3fYe1SFmx5Yf qsPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789426391; x=1790031191; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=SXpVCxEknnDOBO2wgTMiDMSPtQ3J/1cRefmdmIu8XSU=; b=fDnc30VozKaL2DylwbJpbSJVgXVRLUybwxRP8kLUPKqj+QnJY1HXt64xMOaEUMrm3M +Qj5V/j7YKXGsjMuBl0pB77eYJdSSYwARcT4FIRGvZlhW3p+Viw86zmWzaHkH145N61H iKZkEI9RfX7TbIiEEvfbg9Yi9SBZFq1m+6JX6Q0hnJZDiDicxeWTUc1DjLv3mbPCNseM ZxIE+dQd2K2E9I0famBDBti9pqhtMT/Ko4NwFsRxhjPMTi3ETNvBRJ7WuLFIHwObbZOX TxU4IuNVe+e0uCt9XjegN62h9alb1d9yIoF2PZhBO6atnvGtGmBaMYLz4FY+a/LE95Zi ofLA== X-Forwarded-Encrypted: i=1; AKwUvBy7hDZIGdWWGvYn70iUFZg6FzPuGs7hMCAG9+QQdgYXRd1lznsZM8GYSJGoiklH7ifbV3AEpQ6fMW2UA2k=@vger.kernel.org X-Gm-Message-State: AFuF++k8UQdtCBLKYJtmQRd101zt79c3b3MtshKLRb2mhzpCINjLQVsv T0AkMsL/5X4YxW427DnhV4W1Zokv9B1lAf9oAukwNZVsv9+Kyz8FsmVx X-Gm-Gg: AYBFou2l49qCsXP5LWt6nMcJUOKZKtahsNNI2zi68yFI4tWFtBsAyB2R7Xh+q4PurL3 rcgGnFQ/QSc2xq3hQc/WjWBjEIN1F+FG19xOPAPYQrHEGvWda8hCwQbUabt81pvSK0DI1FwF/QD m/AqMWPy4PxRpYlHWOGnPPWnlM4F1/KWmWzVrQvHNJ5Mki/SGWfO7cAwbRdctWjJHKI3FAnaXHG gxncWLcRIr31a8gOIlEBWBsnUvkl1VPtMs8Zmk2mA7rTAIgl+/LfbEbI/R+MNZHuakVtTaQggq0 VesDedhpcZCsHG52dJHZoRMpZn3SNAJcSwTPtoY1hKWF+VoX7WJo+7nobdi14b80pnlHsMpc1q2 FRuUmCMes6tCZm8govmfgxXSqTmJJn5Wv/SkE/Jq+F/o+HWYyGvgUOMSzL3Vq3k79/gA1uzZ7Nk q8B11mEQzijkShXk0ClRsUZTt3eouP2mcMG/On0jdAUKnKYZAF5hdm2bKYuSstPzpDQ5aFFjj07 0b6TzgVJ2enGtwddmsW8Ej+OpqjFR4USkqAbrRxNDosx9VnwK+Yy8VbsacSB94= X-Received: by 2002:a17:902:d485:b0:2dd:78d1:65c9 with SMTP id d9443c01a7336-2dd78d16661mr9457075ad.19.1789426391520; Mon, 14 Sep 2026 15:53:11 -0700 (PDT) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33bbeb053a5sm14924296eec.27.2026.09.14.15.53.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 15:53:11 -0700 (PDT) From: "Derek J. Clark" To: Jiri Kosina , Benjamin Tissoires Cc: "Pierre-Loup A . Griffais" , "Derek J . Clark" , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@lists.opengamingcollective.org, stable@vger.kernel.org Subject: [PATCH 03/10] HID: hid-lenovo-go-s: Prevent deadlock if device removed during setup Date: Mon, 14 Sep 2026 15:52:56 -0700 Message-ID: <20260914225303.868569-4-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260914225303.868569-1-derekjohn.clark@gmail.com> References: <20260914225303.868569-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit hid_gos_cfg_remove() calls a mutex before canceling delayed work. That delayed work function calls mcu_property_out(), which holds the same mutex. Prevent deadlock my removing the mutex prior to stopping the work. Additionally, since cancel_delayed_work has the potential to re-arm, switch to disable_delayed_work. Fixes: a23f3497bf208c59ad ("HID: hid-lenovo-go-s: Add Lenovo Legion Go S Series HID Driver") Cc: stable@vger.kernel.org Signed-off-by: Derek J. Clark --- drivers/hid/hid-lenovo-go-s.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/hid/hid-lenovo-go-s.c b/drivers/hid/hid-lenovo-go-s.c index 36505d8402ff..8b16fc7d151e 100644 --- a/drivers/hid/hid-lenovo-go-s.c +++ b/drivers/hid/hid-lenovo-go-s.c @@ -1442,8 +1442,7 @@ static int hid_gos_cfg_probe(struct hid_device *hdev, static void hid_gos_cfg_remove(struct hid_device *hdev) { - guard(mutex)(&drvdata.cfg_mutex); - cancel_delayed_work_sync(&drvdata.gos_cfg_setup); + disable_delayed_work_sync(&drvdata.gos_cfg_setup); sysfs_remove_groups(&hdev->dev.kobj, top_level_attr_groups); hid_hw_close(hdev); hid_hw_stop(hdev); -- 2.55.0