From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1F15430CE3; Tue, 15 Sep 2026 17:11:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789492284; cv=none; b=cONfoATeKCO3MKgha6L8BER/OCucvvIukEYjzU1XlRepQZcExrDgu/n08IFH+0VrGoAB968x4Y37pL/IG6nB1h4QZ+hWYahrIot7ccyBfiV39akoUCCpBJAmfOBXeu8ofVm87clCWZ71YYgeKhcmKHtsk73PhauyiEN03STzcfI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789492284; c=relaxed/simple; bh=JoFG42xXlFrpOwjPmldOHD33XrAQFsKfPmpd1YYJuYs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bOh7CAF3bvriZcGga1QeaiM7ZqICVR8s+I2b4PSUjkD5SFy+SQHB/zDS9UVNm8xDq8uY6bTyYZwUs5/swILLxcSauxdrGHc/qDKTxpultTkQ8fHQfRuzoFwAt9p64x16NxLeYi5sMh1MdsA/ZRPDe4XvfSx5S64xaNB+Vu/obb0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ojeqGvK6; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ojeqGvK6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6ABE01F000FF; Tue, 15 Sep 2026 17:11:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789492282; bh=jFlAEYt+vZawiMs/kuFEjFO2eUgqoPaOw/VH8mWz2a0=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=ojeqGvK6ERFbX9+/AgOUlLMmatDui8nsMLT15ihY+1QCz0PJbUmDcfTqg0xDy3zYw 9syoB+HBWM0IYLroGYvC0H2QWa8ydT9X+50yXhZnZud+l8yrvyKxXIx3uNtv4TAeah /GSQnZfbfZpx5+k0Qi8kZKUwNMGcMTS1Zs3Kx2IjrebtkUTJsDCrz546FGbWPfysrj lTVM7AtLnzJySyy8qVjEwlyH7bDo1zSM1SSkO2cZ9OZcemditI3HTMxcjkX4HUxAww icGv1rheCppF3hJ2iVhuaCGrUvhQn9seKRRhIsu3qZb9oWBYcr/hhGaIWx8O6ckCBw Xs/P85mUgXAKg== Date: Tue, 15 Sep 2026 18:11:17 +0100 From: Conor Dooley To: Jonathan Cameron Cc: Chang Yu , Joshua Crofts , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Shi Hao , "Jose A. Perez de Azpillaga" Subject: Re: [PATCH v2 1/2] dt-bindings: iio: light: add as7343 Message-ID: <20260915-gleeful-jester-c8114edf28ff@spud> References: <20260907210042.32552-1-marcus.yu.56@gmail.com> <20260907210042.32552-2-marcus.yu.56@gmail.com> <20260908-dinner-shelve-1d61e19ee3b7@spud> <20260913014203.2bae2222@jic23-hlaptop> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hiBTazCoHelLpgFk" Content-Disposition: inline In-Reply-To: <20260913014203.2bae2222@jic23-hlaptop> --hiBTazCoHelLpgFk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 13, 2026 at 01:42:03AM +0100, Jonathan Cameron wrote: > On Tue, 8 Sep 2026 19:13:55 +0100 > Conor Dooley wrote: >=20 > > On Mon, Sep 07, 2026 at 02:00:41PM -0700, Chang Yu wrote: > > > Add binding for AMS AS7343 which is a 14-channel multi-spectral sensor > > > with i2c address of 0x39. > > >=20 > > > The GPIO pin is described as a generic GPIO for now. Binding design f= or the > > > more advanced measurement/LED synchronization use cases are deferred = to > > > future patches. =20 > >=20 > > Unfortunately, you can't change what you document, so picking something > > correct now is needed - even if the driver doesn't use it yet. >=20 > Definitely needs an outline of how it would be backwards compatible and > an explanation of why not now. Sometimes a portion of the binding is > so uncertain that we do kick it back from initial version but we 'must' > be sure we can extend the binding to new configurations. Normally this > is one of those we are fairly sure, but not entirely sure cases - or > picking between two options where consensus isn't being reached. >=20 > Chang Yu: This sort of things needs discussion and is one of the reasons = to > go slowly. Ye, I note that there are 2 more versions of this since I left this comment, but you seem to be on top of that. > > > Datasheet: https://look.ams-osram.com/m/5f2d27fff9a874d2/original/AS7= 343-14-Channel-Multi-Spectral-Sensor.pdf > > > Signed-off-by: Chang Yu > > > --- > > > Changes in v2: > > > - Add the LDR, the interrupt pin, and the GPIO pin to the bindings. > > > - Fix node name and unit address mismatch. > > > - Include MAINTAINERS changes. > > >=20 > > > .../bindings/iio/light/ams,as7343.yaml | 69 +++++++++++++++++= ++ > > > MAINTAINERS | 6 ++ > > > 2 files changed, 75 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/iio/light/ams,a= s7343.yaml > > >=20 > > > diff --git a/Documentation/devicetree/bindings/iio/light/ams,as7343.y= aml b/Documentation/devicetree/bindings/iio/light/ams,as7343.yaml > > > new file mode 100644 > > > index 000000000000..b06d445b92b3 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/iio/light/ams,as7343.yaml > > > @@ -0,0 +1,69 @@ > > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/iio/light/ams,as7343.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: AMS AS7343 14-Channel Multi-Spectral Sensor > > > + > > > +maintainers: > > > + - Chang Yu > > > + > > > +description: | > > > + The AMS AS7343 is a 14-channel multi-spectral sensor with i2c addr= ess of 0x39. > > > + https://look.ams-osram.com/m/5f2d27fff9a874d2/original/AS7343-14-C= hannel-Multi-Spectral-Sensor.pdf > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - ams,as7343 > > > + > > > + reg: > > > + description: > > > + I2C address of the device (0x39). > > > + maxItems: 1 > > > + > > > + interrupts: > > > + description: > > > + Open drain output active low interrupt pin. > > > + maxItems: 1 > > > + > > > + vdd-supply: true > > > + > > > + ams,led-current-microamp: > > > + description: > > > + The driver current for the external LED connected to the LDR p= in. > > > + minimum: 4000 > > > + maximum: 258000 > > > + multipleOf: 2000 > > > + default: 12000 =20 > >=20 > > Rather than a custom property, the tsl2772 uses led-max-microamp: > > tsl2772.yaml > > 46: led-max-microamp: > > 81: led-max-microamp =3D <100000>; > >=20 > > I wonder if the same should be done here, or if there should be an leds > > subnode? Perhaps the IIO folks can comment on that. >=20 > I don't think we've ever bothered with a subnode as there only tends > to be one of them. Given the enabling etc is all hardware controlled > I'm not sure a more generic LED binding makes sense. I don't know that > much about the led bindings though so maybe it is worth doing a subnode > just to use the leds/common.yaml definition of led-max-microamp? Could always just put a ref in to leds/common.yaml and not bother with a child node. I'd stick with the additionalProperties: false, since there's lots of leds properties that probably don't apply to a device like this. Cheers, Conor. --hiBTazCoHelLpgFk Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaql8NQAKCRB4tDGHoIJi 0jkpAQD4XnALOsGOCfzL84JOorNFWrH1QZUXmcfy0YADuSNd7AEAk3yAMDvYfKC5 kfWzthG0L0lav+z/eUbqj4riKVRyEAA= =Vbb8 -----END PGP SIGNATURE----- --hiBTazCoHelLpgFk--