From: Taniya Das <taniya.das@oss.qualcomm.com>
To: Bjorn Andersson <andersson@kernel.org>,
Abel Vesa <abelvesa@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Ajit Pandey <ajit.pandey@oss.qualcomm.com>,
Imran Shaik <imran.shaik@oss.qualcomm.com>,
Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
Taniya Das <taniya.das@oss.qualcomm.com>
Subject: [PATCH] clk: qcom: Fix default entries for Glymur EVACC and GPUCC
Date: Tue, 15 Sep 2026 12:28:22 +0530 [thread overview]
Message-ID: <20260915-kconfig_updates-v1-1-b9bdf35db955@oss.qualcomm.com> (raw)
The EVA clock controller (CLK_GLYMUR_EVACC) config carried a duplicate
'default m if ARCH_QCOM' line, one of them misplaced before the 'select'
statement, while the graphics clock controller (CLK_GLYMUR_GPUCC) config
was missing the 'default m if ARCH_QCOM' line altogether.
Drop the duplicate on EVACC and add the missing default on GPUCC so both
Qualcomm Glymur clock controllers follow the same
depends on / select / default / help ordering used by the other entries.
Fixes: e291ec812dec ("clk: qcom: Add EVA clock controller driver for Glymur SoC")
Fixes: 67e645285dd0 ("clk: qcom: Add support for GPUCC and GXCLK for Glymur")
Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
---
Fix Kconfig ordering/consistency issues for the Qualcomm Glymur clock
controllers: the EVA clock controller (CLK_GLYMUR_EVACC) carried a
duplicate 'default m if ARCH_QCOM' line, one of them misplaced before the
'select' statement, and the graphics clock controller (CLK_GLYMUR_GPUCC)
was missing the 'default m if ARCH_QCOM' line altogether.
With this change both entries follow the same
depends on / select / default / help ordering used by the other Glymur
clock controller Kconfig entries.
---
drivers/clk/qcom/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index 6ef083f5d9e251d2d2c5592a3f3dd51845dc743b..b3ffe1dced017e6f4bd3f0fa9c11bed5948391fc 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -104,7 +104,6 @@ config CLK_GLYMUR_DISPCC
config CLK_GLYMUR_EVACC
tristate "Glymur EVA Clock Controller"
depends on ARM64 || COMPILE_TEST
- default m if ARCH_QCOM
select CLK_GLYMUR_GCC
default m if ARCH_QCOM
help
@@ -127,6 +126,7 @@ config CLK_GLYMUR_GPUCC
tristate "Glymur Graphics Clock Controller"
depends on ARM64 || COMPILE_TEST
select CLK_GLYMUR_GCC
+ default m if ARCH_QCOM
help
Support for the graphics clock controller on Glymur devices.
Say Y if you want to support graphics controller devices and
---
base-commit: 1a1de54f7369cd2b5bac0f265910e60ad3a6b4c3
change-id: 20260915-kconfig_updates-39a684a748d0
Best regards,
--
Taniya Das <taniya.das@oss.qualcomm.com>
next reply other threads:[~2026-09-15 6:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 6:58 Taniya Das [this message]
2026-09-15 9:41 ` Abel Vesa
2026-09-16 9:00 ` Pankaj Patil
2026-09-16 9:10 ` Pankaj Patil
2026-09-16 22:06 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915-kconfig_updates-v1-1-b9bdf35db955@oss.qualcomm.com \
--to=taniya.das@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=ajit.pandey@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bmasney+clk@redhat.com \
--cc=imran.shaik@oss.qualcomm.com \
--cc=jagadeesh.kona@oss.qualcomm.com \
--cc=jbrunet+clk@baylibre.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®