From: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
To: Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jesszhan0024@gmail.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krishna Manikandan <quic_mkrishn@quicinc.com>,
Abel Vesa <abelvesa@kernel.org>,
Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Yongxing Mou <yongxing.mou@oss.qualcomm.com>
Subject: [PATCH v2 2/3] drm/msm/dpu: Attach INT2 power domain alongside MMCX on Kaanapali
Date: Tue, 15 Sep 2026 17:27:49 +0800 [thread overview]
Message-ID: <20260915-msm_gdsc2-v2-2-9157237b8382@oss.qualcomm.com> (raw)
In-Reply-To: <20260915-msm_gdsc2-v2-0-9157237b8382@oss.qualcomm.com>
Kaanapali's DPU node lists two power domains when its DT provides
both MMCX and INT2 GDSC. The power-domain core only auto-attaches a
single power domain; with two phandles it leaves the device
unattached to either, so attach both explicitly.
MMCX keeps PD_FLAG_REQUIRED_OPP, preserving its existing OPP-based
performance-state voting. INT2 has no OPP of its own and is attached
as a plain runtime-PM supplier, via the device link the attach API
creates automatically, so it needs no manual pm_runtime get/put in
the enable/disable paths.
Platforms with a single power domain are unaffected and continue to
rely on the core's existing single-domain auto-attach.
Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
index da3556eb6ecc..d9c2c8d680fd 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
@@ -12,6 +12,7 @@
#include <linux/debugfs.h>
#include <linux/dma-buf.h>
#include <linux/of_irq.h>
+#include <linux/pm_domain.h>
#include <linux/pm_opp.h>
#include <drm/drm_crtc.h>
@@ -1376,6 +1377,33 @@ static int dpu_kms_mmap_dpu(struct dpu_kms *dpu_kms)
return 0;
}
+static int dpu_kms_attach_power_domains(struct device *dev)
+{
+ static const char * const mmcx_names[] = { "mmcx" };
+ static const char * const int2_names[] = { "int2" };
+ const struct dev_pm_domain_attach_data mmcx_pd = {
+ .pd_names = mmcx_names,
+ .num_pd_names = ARRAY_SIZE(mmcx_names),
+ .pd_flags = PD_FLAG_REQUIRED_OPP,
+ };
+ const struct dev_pm_domain_attach_data int2_pd = {
+ .pd_names = int2_names,
+ .num_pd_names = ARRAY_SIZE(int2_names),
+ };
+ struct dev_pm_domain_list *mmcx_list, *int2_list;
+ int ret;
+
+ if (of_count_phandle_with_args(dev->of_node, "power-domains",
+ "#power-domain-cells") <= 1)
+ return 0;
+
+ ret = devm_pm_domain_attach_list(dev, &mmcx_pd, &mmcx_list);
+ if (ret < 0)
+ return ret;
+
+ return devm_pm_domain_attach_list(dev, &int2_pd, &int2_list);
+}
+
static int dpu_dev_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
@@ -1392,6 +1420,10 @@ static int dpu_dev_probe(struct platform_device *pdev)
dpu_kms->pdev = pdev;
+ ret = dpu_kms_attach_power_domains(dev);
+ if (ret < 0)
+ return dev_err_probe(dev, ret, "failed to attach power domains\n");
+
ret = devm_pm_opp_set_clkname(dev, "core");
if (ret)
return ret;
--
2.43.0
next prev parent reply other threads:[~2026-09-15 9:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 9:27 [PATCH v2 0/3] drm/msm/dpu: Add INT2 GDSC power domain support for Kaanapali Yongxing Mou
2026-09-15 9:27 ` [PATCH v2 1/3] dt-bindings: display: msm: Add INT2 GDSC to Kaanapali DPU Yongxing Mou
2026-09-15 19:34 ` Rob Herring (Arm)
2026-09-16 2:37 ` Yongxing Mou
2026-09-15 9:27 ` Yongxing Mou [this message]
2026-09-15 9:27 ` [PATCH v2 3/3] arm64: dts: qcom: " Yongxing Mou
2026-09-15 9:53 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915-msm_gdsc2-v2-2-9157237b8382@oss.qualcomm.com \
--to=yongxing.mou@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=quic_mkrishn@quicinc.com \
--cc=robh@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=yuanjie.yang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®