From: Konrad Dybcio <konradybcio@kernel.org>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
usb4-upstream@oss.qualcomm.com,
Raghavendra Thoorpu <rthoorpu@qti.qualcomm.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: [PATCH] usb: dwc3: Resend full Data Packet for non-compliant USB3.1 devices
Date: Tue, 15 Sep 2026 21:03:43 +0200 [thread overview]
Message-ID: <20260915-topic-usb3_tunneling_fixup-v1-1-61264d3103cb@oss.qualcomm.com> (raw)
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Some non-compliant devices require that a full Data Packet (and not
only the header) is resent upon LBAD. One such device is the USB3
protocol adapter within the Qualcomm USB4 router.
DWC3 has a toggle to enable that behavior within LLINKDBGCTRL, use it.
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
drivers/usb/dwc3/core.c | 8 ++++++++
drivers/usb/dwc3/core.h | 2 ++
2 files changed, 10 insertions(+)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index fd5c2cd36c59..d375ebee297b 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -1514,6 +1514,14 @@ int dwc3_core_init(struct dwc3 *dwc)
}
}
+ if (DWC3_IP_IS(DWC31) || DWC3_IP_IS(DWC32)) {
+ for (int i = 0; i < dwc->num_usb3_ports; i++) {
+ reg = dwc3_readl(dwc, DWC3_LLINKDBGCTRL(i));
+ reg |= DWC3_LLINKDBGCTRL_RETRY_DP;
+ dwc3_writel(dwc, DWC3_LLINKDBGCTRL(i), reg);
+ }
+ }
+
/*
* STAR 9001346572: This issue affects DWC_usb31 versions 1.80a and
* prior. When an active endpoint not currently cached in the host
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 608daeb7ef10..6af644a9672d 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -180,6 +180,8 @@
#define DWC3_OSTS 0xcc10
#define DWC3_LLUCTL(n) (0xd024 + ((n) * 0x80))
+#define DWC3_LLINKDBGCTRL(n) (0xd058 + ((n) * 0x80))
+#define DWC3_LLINKDBGCTRL_RETRY_DP BIT(31)
/* Bit fields */
---
base-commit: 1a1de54f7369cd2b5bac0f265910e60ad3a6b4c3
change-id: 20260915-topic-usb3_tunneling_fixup-8c0fb73edec8
Best regards,
--
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
next reply other threads:[~2026-09-15 19:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 19:03 Konrad Dybcio [this message]
2026-09-23 2:02 ` Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915-topic-usb3_tunneling_fixup-v1-1-61264d3103cb@oss.qualcomm.com \
--to=konradybcio@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rthoorpu@qti.qualcomm.com \
--cc=usb4-upstream@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®