mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Im7CK <computergod47@gmail.com>
Cc: linux-kbuild@vger.kernel.org, nsc@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: fix grammar in output Makefile .gitignore generation comment
Date: Mon, 14 Sep 2026 18:37:52 -0700	[thread overview]
Message-ID: <20260915013752.GA1794450@ax162> (raw)
In-Reply-To: <CACgbi99eSJRx-q5yZR3cMheDaDxKKpExg_fkzapbM8B9YuSh6Q@mail.gmail.com>

Hi,

On Sun, Sep 13, 2026 at 08:24:32PM +0530, Im7CK wrote:
> Fixed grammar in the comment describing the generation of the output
> Makefile and .gitignore file.
> 
> Signed-off-by: Mebecool1 <computergod47@gmail.com>
> ---
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 66654fa71..13236b460 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -681,8 +681,8 @@ ifdef building_out_of_srctree
>  # outputmakefile generates a Makefile in the output directory, if using a
>  # separate output directory. This allows convenient use of make in the
>  # output directory.
> -# At the same time when output Makefile generated, generate .gitignore to
> -# ignore whole output directory
> +# At the same time as the output Makefile is generated, generate .gitignore to
> +# ignore the whole output directory.
> 

Your email client mangled this patch, it cannot be applied. Please read

  https://docs.kernel.org/process/email-clients.html

for some information on clients and git send-email or consider using

  https://b4.docs.kernel.org/en/latest/contributor/overview.html

to use 'b4 prep' and 'b4 send' to properly handle some of that in a more
user-friendly manner. An example of that workflow (use the kbuild tree
as the base though: https://git.kernel.org/pub/scm/linux/kernel/git/kbuild/linux.git/):

  https://github.com/ClangBuiltLinux/linux/issues/2093#issuecomment-2932754317

Additionally, you need to signoff your patch with a proper name, as
neither Im7CK or Mebecool1 are a "known identity" per

  https://docs.kernel.org/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

-- 
Cheers,
Nathan

  reply	other threads:[~2026-09-15  1:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-13 14:54 Im7CK
2026-09-15  1:37 ` Nathan Chancellor [this message]
2026-09-15  6:26 Aayansh Ranjan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260915013752.GA1794450@ax162 \
    --to=nathan@kernel.org \
    --cc=computergod47@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nsc@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®