From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv2-f12.google.com (mail-qv2-f12.google.com [74.125.230.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B3123CFF6B for ; Tue, 15 Sep 2026 02:04:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789437856; cv=none; b=ALRce/DfBHqLleVPdtzQ6QkYGN0NhIIwKfO9n9vL/EJQqFyUMZFh0JMltxgcLlux67BDcfc2COA6y5UsJfbKo0nRrf2NlT8DkEobPa7tL3/N6OTMJAvk7E3wgu81L6kMNxKWdy2L1RfOjnL+DBQC7rL9amO0sGpcmRXMjKE0mSw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789437856; c=relaxed/simple; bh=Fcw039KrkxGKVWLTft+Guz2bGKn9Me6A8sWpvgD3JoU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HogV91w6ixz4OS0xtJ3CqRLLo4jm+m5ysEgl6MieF8wUQezJqn7iWExMbSS+yyWah6fILA4X8vP7gQAelZHtjU81z4gfQViSJW0YdVtEdDFwV52TIgU0CJgWX0/tP2FirYH3gkYA8bYQTMOmmV10onkABNbVeUdFj67sfZuTTKQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hEnxM/jX; arc=none smtp.client-ip=74.125.230.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hEnxM/jX" Received: by mail-qv2-f12.google.com with SMTP id 6a1803df08f44-91058dd77a2so41931096d6.3 for ; Mon, 14 Sep 2026 19:04:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789437853; x=1790042653; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ijUVaQx/mDvllGL84fcjqcGETQyV2GszfE4nAG9CvaQ=; b=hEnxM/jXNA5WFb3EwKhx1DF8S58K08nRHmbvT+4T041tstO6Uj2hS7lxCjVHd4fkz5 p0xDJVskoLvnGj9E2B8ljjdtFVghsJO+63kUx61TX5i1IGjofURLyG9ROs+thRsyyHmk +h+vT0zjTaA/cMEmVkzJiP3I9jIARCq+IpCexgsVww6vOIdDn77OQPd9F81sMYe+9AiD NZSJqjxOYfQetMOvTwAQKLuXAVULDgTeOVAnKPdD6+naxrcazJYa28HADfjGMlMNokKi PJfdFUOhIOVZH/nsOPujZG5mozQ9suWzUvnrfNdSP8UDjm4K73LQJ2WAOq2LjZcVJEau Z3vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789437853; x=1790042653; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ijUVaQx/mDvllGL84fcjqcGETQyV2GszfE4nAG9CvaQ=; b=GTMZuuCs+NDEndn95JPUihtYgcs00HR5lWUU4dg6rSx/ZG6Dmn+iKrSRuPYxYm+90W JMF+maAPABsrkPBWDMI5k9GILr8DSdCKstil82PFmcPRm9760HqXgOvb1lvilT2GuMlb qsoF449AT1e99xai8cac9zq8gXfi2NBuqOZxU2EIZCXUYfyqcTGPHFmyvQoqW/7iP4dp u0WLUxkpSER2Sf3g69WWXK5wp1rohK6vqXudNvqF3xaivbj0bl9pMOlaopJnq8fKQ8P0 XlydUC429fO7qDFE096smAm4lxjjh9Ez+8Zgqp0m3t27oYp1VdFdWdmn6jqW3MKSIbpD H2pA== X-Forwarded-Encrypted: i=1; AKwUvBxkwRVQpI8I2EV2W1Ax+YmPjvQIIqRqYx+Z9GdspiMDabrOcMpA4O0w/3MaXAydyjnPKraLF1UB1r+Jg08=@vger.kernel.org X-Gm-Message-State: AFuF++mURLo4WXvUf2aGxBw/2a5ch1KnfgEVhCEMEgoC651VrVSsI7vW 5vH6WOlNy4sWecmwss3bJSoP5EGus7OC7PmE5GeW2UOzN7B14fTxwRY= X-Gm-Gg: AYBFou2ZAq+odF9+wdCM2nU8LS3R06QcplHYoEKmKRQQWLTnYsNKqo9rJxYv7KzQMph wUPnCDZxQbx2QocNEFJVWCwqcyaMVxAiw5nL7/jgwP/WsH3hHHMZdzfRCvMimAeawvsJwO1zR/b QJFr0N6Pb5R2/PPgm1g59a/HC8pwCOxIoMvDmhqgounnPxhBotM1KcE4gp4oR1JhyIRCQ1IOUkY gXKHC2I6Q1wlMRJzvCMIZi5yIlOVr2SNONZsi99Sxsmccdh5qeQxUMcTJGAC5wmoYuZud915onJ 01PB92hTEi/9UB/HAvGQLjXN+5vRq80PoR53XWu+eFbS2XzFTm0lYU3ql1n7OPkfnBxzh2QE/D2 BqLdrmnQ6mJZJOlRY0L19AgAl/jK4ieXRxF0gaV1g5CVU5WasVudD/dWQj+arXMh8fY7ohnD83T BISWx6aDH77HA1VHvdNZa2ZxBDE6JAUlZZ8HvXuRkuZsZy0YWHm+SSUX/QxutA4qhIq4IhdhYMz KjBvY/6UzPKRwW5rXqL2NUNupF2Ifx6ZUnVmMB7yCUDINGwNojusZr31mZHcSibwhXLIb/FBABm kpt/yOsCeILmSODapNNHag3GFjy/Z246DpPLacQQBjsxnquxsEd46uGP8Xp4KTSTNNymTg== X-Received: by 2002:a05:620a:4888:b0:939:d762:e2d8 with SMTP id af79cd13be357-93a299943efmr847619485a.31.1789437848647; Mon, 14 Sep 2026 19:04:08 -0700 (PDT) Received: from 6e-wmo5420-02.ad.psu.edu.net (6e-wmo5420-02.ad.psu.edu. [104.39.213.233]) by smtp.gmail.com with ESMTPSA id af79cd13be357-939e7f18628sm1138775685a.13.2026.09.14.19.04.06 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 14 Sep 2026 19:04:06 -0700 (PDT) From: Myeonghun Pak To: netdev@vger.kernel.org Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH net] net: tulip: dmfe: Disable PCI device on removal Date: Mon, 14 Sep 2026 22:03:59 -0400 Message-ID: <20260915020359.89842-1-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit dmfe_init_one() enables the PCI device and balances that reference on probe failures, but dmfe_remove_one() leaves the device enabled. Disable it after unregistering the network device and releasing the driver's mappings, DMA buffers and PCI regions. This issue is already present in the initial Git import; its pre-Git introduction is unknown. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Assisted-by: LLM Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/net/ethernet/dec/tulip/dmfe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/dec/tulip/dmfe.c b/drivers/net/ethernet/dec/tulip/dmfe.c index dabc091..dcf6848 100644 --- a/drivers/net/ethernet/dec/tulip/dmfe.c +++ b/drivers/net/ethernet/dec/tulip/dmfe.c @@ -528,6 +528,7 @@ static void dmfe_remove_one(struct pci_dev *pdev) TX_BUF_ALLOC * TX_DESC_CNT + 4, db->buf_pool_ptr, db->buf_pool_dma_ptr); pci_release_regions(pdev); + pci_disable_device(pdev); free_netdev(dev); /* free board information */ }