From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C2FA3CDBA5 for ; Tue, 15 Sep 2026 08:19:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789460399; cv=none; b=pasAUrYe4wAkmuWJ4Bbjs9YDEosuQZ4FzgQz4aC+vkH6iLh6B3ov5SjJK5tOgMFy0qF/4ETVpJPQEdLYCRxvfx4mqwyRtM/FdejHnhBqK+/GhM0oll3tor/Jx9IQwd9QVb/cHnQzpGutmYxB2w6cjHRuK0NR/zr8NP9Mdy4CgWM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789460399; c=relaxed/simple; bh=hwfRqXyDJjrWnLmHCCnSyQ5c6I5VKxxwWvdwR4gczDI=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=Co6rkadS9D/BbHgcL2pSclgLm0fkXvgKMQ7O5imKBPeWZlEFrD+d3pq/+E0Lm8TVhnXZTwMEBTJsqpCHphkYybv5SyZc/1/7E12hD4HnAkB5ZqTBtOQ1xbwnj2sHorfgHikxZuf9ye7zeKo1EyL2D36vfIHTOcm38rKSXbrJGr0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--morbo.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=kFStyNsf; arc=none smtp.client-ip=209.85.215.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--morbo.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kFStyNsf" Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cc489e7a701so6024077a12.2 for ; Tue, 15 Sep 2026 01:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1789460390; x=1790065190; darn=vger.kernel.org; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:mime-version:date:from:to:cc:subject:date:message-id :reply-to:content-type; bh=cTJ+iDaVRz+oQczzBBEu9x7Pp5Lm2h3B0iGAZglcmy4=; b=kFStyNsf6no/miZzS9f9e0bO+LbLlx0nALsKxyWWFxRsfeWL4uq54zP/54wKmdnETs JN6+GIzvVSSoy0wHCDekSB2YCv/Q4L3cDh7T/w4TP9GVWYWDoLdns/B+Un0epV6L8yRw xCHA+NayFImP2wwXOZrL7HyXmPEyzDrV0R2ZwHZ1jOpUfNkSEjbgXDcOs13Ty3xfcI/z jNWMggNlw/e20k1m4NQfDF7+hjJAPr3+U1awQi+C1Rajk+IrxjV6vzYuAlBs+HPzOGu7 Df1YM916Vv17Ue4q+ylkCKnNZIt1wsePHKdGVoP8bsJhgUOMlEKy6MReKjTz7SCij8mt cpyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789460390; x=1790065190; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:mime-version:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=cTJ+iDaVRz+oQczzBBEu9x7Pp5Lm2h3B0iGAZglcmy4=; b=By35KS1Pu7KajVat+sR/PxhmJujthL9xT/UZgmxCbmJhriyA7OShq65AMJpvGyaXVM i5mSKJ/kRItkz8wMdYBOwRr0x/k6txVx0EKhZIkclxhrv7AvOI+1wnJAxUmvwyL1WUzm ObDMZZtv4gx6rMx9P4Vub46QFEl6h0nGA694wIBk+8XbW4EJD+NykInnWaf6j8ynTE2w ub2KkOkAs4ekJSoW8PqC6EmsP1xuvCh9rbnlDghB/4oJ4e0SDamQzNVBV5/3CvpMFdvz UJsw9F+vARSFsLChE0udXT01rUT0v+Z44aKoW0ML7FZMeaYXCSHuOSXNBC4hs3dnNrGu jhPA== X-Gm-Message-State: AFuF++mvYzMCx/GuqcHh0hpYABWi7WLSgXIjEqb397dbuIYh9W3T1+AO zgCeg3EkyH9LRTRiSfD/JezAwlmNBnPNcZHVAX3ewXJgMDaHDTpYRWl7wncMO1qLZzpGeagKq9v c4IqIr5mbc+A8NRkBcBLM5YWxEW0kjL8ybefB6MOuv7k7j/J/y973qap2iF2UIwCBTLtEsSW/Qx wap8FeS9Rc4DYUhGY7eGbCDoM6aWok023LJTCRRw== X-Received: from pgbo14.prod.google.com ([2002:a63:5a0e:0:b0:cc4:337f:e10f]) (user=morbo job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:7d9f:b0:3b4:61f:1fec with SMTP id adf61e73a8af0-3db4038ec7cmr15429477637.2.1789460388838; Tue, 15 Sep 2026 01:19:48 -0700 (PDT) Date: Tue, 15 Sep 2026 08:18:17 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.55.0.1032.g73a4cd73de-goog Message-ID: <20260915081910.4142719-1-morbo@google.com> Subject: [PATCH 00/28] Replace remaining strlcat() call sites with snprintf()/seq_buf() From: Bill Wendling To: linux-kernel@vger.kernel.org Cc: Bill Wendling , Russell King , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Ian Abbott , H Hartley Sweeten , Tony Luck , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matthew Brost , "=?UTF-8?q?Thomas=20Hellstr=C3=B6m?=" , Rodrigo Vivi , Dmitry Torokhov , Matthias Schwarzott , Mauro Carvalho Chehab , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Arend van Spriel , Rob Herring , Saravana Kannan , Krzysztof Kozlowski , Sylwester Nawrocki , Peter Griffin , Alim Akhtar , Linus Walleij , Anil Gurumurthy , Sudarsana Kalluru , "Martin K. Petersen" , Trond Myklebust , Anna Schumaker , Mike Marshall , Martin Brandenburg , Kees Cook , Jiri Pirko , Simon Horman , Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Jaroslav Kysela , Takashi Iwai , Andrew Morton , "Mike Rapoport (Microsoft)" , Kanglong Wang , Tiezhu Yang , Qiang Ma , Randy Dunlap , Pengpeng Hou , Ard Biesheuvel , Breno Leitao , Thorsten Blum , Harshit Mogalapalli , Greg Kroah-Hartman , Lyude Paul , Ashutosh Desai , Imre Deak , Dmitry Baryshkov , Johan Hovold , Johannes Berg , Miri Korenblit , Alexander Stein , Cryolitia PukNgae , Jiaming Zhang , Will Porter , Cen Zhang , "=?UTF-8?q?C=C3=A1ssio=20Gabriel?=" , Rong Zhang , Arun Raghavan , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-edac@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-scsi@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, linux-hardening@vger.kernel.org, linux-sound@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable strlcat() is deprecated: like strcat(), it requires re-scanning the destination string from the beginning on every call, which is O(n^2) when used to build up a string incrementally, and its truncation behavior is easy to get wrong. See: https://github.com/KSPP/linux/issues/370 This series removes the remaining strlcat() call sites in the tree (plus the one inside fortify-string.h's strcat() implementation itself), replacing each with snprintf(), scnprintf(), or the seq_buf() API, whichever best fits the surrounding code. One unrelated fix is included. While auditing drivers/edac/thunderx_edac.c for its strlcat() conversion, "EDAC/thunderx: Fix stale error context in thunderx_l2c_threaded_isr()" addresses a pre-existing bug, present since the driver's original 2017 commit: thunderx_l2c_threaded_isr() computes its ring "tail"/"ctx" once before its drain loop and never recomputes them per iteration, unlike the analogous OCX handlers in the same file, so it re-reports the same ring entry for every queued error instead of draining the ring. It's split out as its own patch, ahead of the strlcat() conversion for that file, so it can be reviewed and backported independently of the rest of this series. Bill Wendling (28): ALSA: ac97: Refactor snd_ac97_get_name() to use snprintf() sunrpc: Refactor rpc_sockaddr2uaddr() to use snprintf() instead of strlcat() ARM: atags: Replace strlcat() with snprintf() for cmdline extend scsi: bfa: Use snprintf() in bfa_fcs_fabric_nsymb_init() ALSA: usb-audio: Refactor usb_audio_make_longname() to use seq_buf comedi: comedi_bond: Refactor strlcat() to seq_buf in do_dev_config() scsi: bfa: Use snprintf() in bfa_fcs_fabric_psymb_init() devlink: Refactor strlcat() to seq_buf in __devlink_compat_running_version() drm/dp_mst: Refactor build_mst_prop_path() to use seq_buf of/fdt: Replace strlcat() with snprintf() in early_init_dt_scan_chosen() wifi: brcmfmac: Replace strlcat() with snprintf() in brcmf_fw_alloc_request() fortify: Convert strlcat() to snprintf() in strcat() i40e: Replace strlcat() with snprintf() in i40e_nvm_version_str() ALSA: usb-audio: Refactor append_ctl_name() to use snprintf() orangefs: Use seq_buf for debug help string generation pinctrl: samsung: Use snprintf() to construct pin bank names MIPS: cmdline: Refactor bootcmdline_append() to use snprintf() LoongArch: Refactor bootcmdline_init() to use seq_buf instead of strlcat() x86/setup: Use snprintf() to concatenate builtin and boot command lines parisc: Refactor strlcat() to seq_buf in setup_cmdline() NFS: nfsroot: Refactor root_nfs_cat() to use snprintf() media: si2165: Use snprintf() to format frontend name Input: synaptics_usb - use seq_buf and snprintf() for name and phys EDAC/thunderx: Fix stale error context in thunderx_l2c_threaded_isr() EDAC/thunderx: Replace strlcat() with seq_buf wifi: wil6210: Refactor resume_triggers2string() to use seq_buf drm/xe/pf: Convert strlcat() to seq_buf in control_read() drm/xe/pf: Refactor strlcat() to seq_buf in sched_group_engines_read() arch/arm/kernel/atags_parse.c | 7 +- arch/loongarch/kernel/setup.c | 22 +++-- arch/mips/kernel/setup.c | 21 ++++- arch/parisc/kernel/setup.c | 16 ++-- arch/x86/kernel/setup.c | 8 +- drivers/comedi/drivers/comedi_bond.c | 16 ++-- drivers/edac/thunderx_edac.c | 67 ++++++++++------ drivers/gpu/drm/display/drm_dp_mst_topology.c | 15 ++-- drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c | 24 +++--- drivers/input/mouse/synaptics_usb.c | 29 ++++--- drivers/media/dvb-frontends/si2165.c | 17 ++-- drivers/net/ethernet/intel/i40e/i40e.h | 15 +++- drivers/net/wireless/ath/wil6210/wmi.c | 38 +++++---- .../broadcom/brcm80211/brcmfmac/firmware.c | 21 ++--- drivers/of/fdt.c | 11 ++- drivers/pinctrl/samsung/pinctrl-samsung.c | 3 +- drivers/scsi/bfa/bfa_fcs.c | 80 +++++-------------- fs/nfs/nfsroot.c | 11 ++- fs/orangefs/orangefs-debugfs.c | 36 ++++----- include/linux/fortify-string.h | 7 +- net/devlink/dev.c | 8 +- net/sunrpc/addr.c | 16 ++-- sound/pci/ac97/ac97_codec.c | 9 ++- sound/usb/card.c | 58 +++++++++----- sound/usb/mixer.c | 8 +- 25 files changed, 309 insertions(+), 254 deletions(-) --- Cc: Russell King Cc: Huacai Chen Cc: WANG Xuerui Cc: Thomas Bogendoerfer Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: x86@kernel.org Cc: "H. Peter Anvin" Cc: Ian Abbott Cc: H Hartley Sweeten Cc: Tony Luck Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Simona Vetter Cc: Matthew Brost Cc: "Thomas Hellstr=C3=B6m" Cc: Rodrigo Vivi Cc: Dmitry Torokhov Cc: Matthias Schwarzott Cc: Mauro Carvalho Chehab Cc: Tony Nguyen Cc: Przemek Kitszel Cc: Andrew Lunn Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Arend van Spriel Cc: Rob Herring Cc: Saravana Kannan Cc: Krzysztof Kozlowski Cc: Sylwester Nawrocki Cc: Peter Griffin Cc: Alim Akhtar Cc: Linus Walleij Cc: Anil Gurumurthy Cc: Sudarsana Kalluru Cc: "Martin K. Petersen" Cc: Trond Myklebust Cc: Anna Schumaker Cc: Mike Marshall Cc: Martin Brandenburg Cc: Kees Cook Cc: Jiri Pirko Cc: Simon Horman Cc: Chuck Lever Cc: Jeff Layton Cc: NeilBrown Cc: Olga Kornievskaia Cc: Dai Ngo Cc: Tom Talpey Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Bill Wendling Cc: Andrew Morton Cc: "Mike Rapoport (Microsoft)" Cc: Kanglong Wang Cc: Tiezhu Yang Cc: Qiang Ma Cc: Randy Dunlap Cc: Pengpeng Hou Cc: Ard Biesheuvel Cc: Breno Leitao Cc: Thorsten Blum Cc: Harshit Mogalapalli Cc: Greg Kroah-Hartman Cc: Lyude Paul Cc: Ashutosh Desai Cc: Imre Deak Cc: Dmitry Baryshkov Cc: Johan Hovold Cc: Johannes Berg Cc: Miri Korenblit Cc: Alexander Stein Cc: Cryolitia PukNgae Cc: Jiaming Zhang Cc: Will Porter Cc: Cen Zhang Cc: "C=C3=A1ssio Gabriel" Cc: Rong Zhang Cc: Arun Raghavan Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: loongarch@lists.linux.dev Cc: linux-mips@vger.kernel.org Cc: linux-parisc@vger.kernel.org Cc: linux-edac@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: intel-xe@lists.freedesktop.org Cc: linux-input@vger.kernel.org Cc: linux-media@vger.kernel.org Cc: intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org Cc: linux-wireless@vger.kernel.org Cc: brcm80211@lists.linux.dev Cc: brcm80211-dev-list.pdl@broadcom.com Cc: devicetree@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-gpio@vger.kernel.org Cc: linux-scsi@vger.kernel.org Cc: linux-nfs@vger.kernel.org Cc: devel@lists.orangefs.org Cc: linux-hardening@vger.kernel.org Cc: linux-sound@vger.kernel.org --=20 2.47.3