From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej2-f12.google.com (mail-ej2-f12.google.com [74.125.228.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F41BB46C83E for ; Tue, 15 Sep 2026 08:49:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789462151; cv=none; b=D5/SJrl+06/xW/9X1i9LK3Rrw/is9xysJtRbBkabc3IRNgBoH97gw+Bkms3EAb/SuoIlGma58VOfRU6VOWcnJhbOHv31knsMUqaRynyRPErKtAXoYBpLojTdlEJsDKbr6gQlTaPxL2v4uvxJ/FV2NB0/6LDkBEoMvAUYbe7Z/T4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789462151; c=relaxed/simple; bh=RM4LDmfKFGK73do6/gb46bD7wd1gb1ydtCtOaLRCVj8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l+Dog61hmVXwWq7nFjxdf2fff/VIFo2E6oR1axFUYn7uKPP1FJGywY+sbtgo4egJFahr/6V4JEbyzlZpZ4OSLETlNf/OLwhtXlY711Hu3QqJOuTbBMPWmEmzOzFOBxCNrqml0zsykFgCQNHSNpqpMYB9kUjhPryXqZHiwoAP9Do= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KktpPCss; arc=none smtp.client-ip=74.125.228.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KktpPCss" Received: by mail-ej2-f12.google.com with SMTP id a640c23a62f3a-c254f9f7dbeso5086566b.0 for ; Tue, 15 Sep 2026 01:49:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789462147; x=1790066947; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8Okn9/8O1LREB/jJobsvVn4jcYarpZ/VFVWZ8aLiwsI=; b=KktpPCssJreyDDQzViiVOFxY2tZiG2nZfX/fuEO2p25pOhCtPfGfP+GQJNipKF01Cv zH/N83vsKqJVTaILZ/M6RQW5Sm2eYqYvk2zETQcuNSLbW4ys+Kp7x+FwmRbKUXicQyLj yzqICVKJ8zmlJSAXmUUu7Oe368EMyy5SJjaFXxYBz07RIZcjPOy8B/wu8N1TvPuFUwq3 V/tHkcKVz6x6oiQjzHynLRCbLmTJ8aBXQCTT9pNdAHYgozy/xM5JXa/x+XD0EsMekaBH IgIfWImU2fgspjOUrR3TaJ9xFsid7Ssg9DQWAt1gd/af6/4pdOnKv6r0ufjHOE4EMYB1 0JMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789462147; x=1790066947; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=8Okn9/8O1LREB/jJobsvVn4jcYarpZ/VFVWZ8aLiwsI=; b=HPYk535sY+RoyjxCBzpMUWOaK+XUXfIOMMmrlkk4Br/E+mrvbQE9agwHD/fcB2Hy20 +xZtzPgDLKrJi1g5iU8dUXEPouJ3BrJB9QsDjpQroZJ57IyR+X7WUcmlZ9nfW4DMuw9e Sjqs9JwnD5yCoZyNzJ0WiurJxrHcYYg/EkSm2sLUXqowcmdH5GA7oTamxOVGFLeZSAVi S+Exe72qpWMOtExfn8G4gdxY4i6BE7oY3oYcLktq76vX3+SKi67wb3N42TVj84p6lq9V hkgrQog9mSxXaVUMIx3c93CUvY0B11KUpDIsZv2fW9pk4ns2PLpnYhDeaIplHd1NEwMD mg4Q== X-Forwarded-Encrypted: i=1; AKwUvBwEXT5XBtVbrspd8Xy04RlVe1qkeKKqntmZAdAIF/Q8mzNYOU1wo8ITV3UIak+LBwP7IvVFvjDGqtstwOE=@vger.kernel.org X-Gm-Message-State: AFuF++kjTW4ZZqNbWlC/jC2GZpDuP8ur1V3HfWgugDpiFeWr/SbJiRoS szhfSrnUZ/ggojze9N1AN1Z9PkSUh4X5cSyvSHgEtoNgEkWHRZ4ryeDT X-Gm-Gg: AYBFou3/SXA15PbnA8YNYwKtsvwezLheGIVQYFcdVGDweXjhbugz4P0bUM8d5qkZU8x XqNMhNnDxwaAEYN5JqpiNdk7upzDxiQc0oxLbWGiqCm4nHaYZG94tJ368JgPIldzP/iAAHU5r/1 6eao/tGLgbaj/TChVNXCV7NHs32t44mi8I/WsgrCkAxuMWgSJm7JBQmssQWJKDFFkLQfpGmtDK6 TSp0R8mcqmGW6YQOXIxN93NzqUA7+hxn+fApqETeJpJDPUAqghSwh8nfR2kP8fb3c74sGYokAR8 1kRzcPCqcZnitQf63ZcoNY/Z77tNC8kyLpfkcMH+OlyzGMmtxViiYnDFVtHyAIPIEdrgCVdYzqA vwYddtDvokx0uQapTDwgLyq2GsRCO9+k47ow2iVur/chHWqIiHEPxIMbqflKgbs87HK/jbGOHFj n09yBqpAVbWRYbHEceBxqT2p/ID4S5CSZJv39VPN89a2zrl8K1a0ntDNvZc8k+v6QRUUOTJz8EG 8F7DGry2HdPfSsKcQxjmi5PyVM+Q63TchQzMU+NQP4= X-Received: by 2002:a17:907:3e29:b0:c29:583a:c291 with SMTP id a640c23a62f3a-c29d77ed37cmr13864166b.21.1789462147034; Tue, 15 Sep 2026 01:49:07 -0700 (PDT) Received: from workstation (161-53-210-87.ftth.glasoperator.nl. [87.210.53.161]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2966067101sm552702966b.35.2026.09.15.01.49.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 01:49:06 -0700 (PDT) From: Stanislav Zaikin To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Stanislav Zaikin , Konrad Dybcio Subject: [PATCH v4 2/3] power: supply: qcom_battmgr: add Xiaomi taoyao support Date: Tue, 15 Sep 2026 10:49:00 +0200 Message-ID: <20260915084901.56622-3-zstaseg@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260915084901.56622-1-zstaseg@gmail.com> References: <20260915084901.56622-1-zstaseg@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The Xiaomi taoyao firmware defines an additional BATT_CONSTANT_CURRENT property (ID 12) between BATT_CHG_CTRL_LIM_MAX and BATT_TEMP, shifting all higher battery property IDs by one. Signed-off-by: Stanislav Zaikin Reviewed-by: Konrad Dybcio --- drivers/power/supply/qcom_battmgr.c | 86 +++++++++++++++++++++++++++-- 1 file changed, 82 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c index 490137a23d00..1ff079750807 100644 --- a/drivers/power/supply/qcom_battmgr.c +++ b/drivers/power/supply/qcom_battmgr.c @@ -23,6 +23,7 @@ enum qcom_battmgr_variant { QCOM_BATTMGR_SC8280XP, QCOM_BATTMGR_SM8350, QCOM_BATTMGR_SM8550, + QCOM_BATTMGR_TAOYAO, QCOM_BATTMGR_X1E80100, }; @@ -451,16 +452,87 @@ static const u8 sm8350_bat_prop_map[] = { [POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD] = BATT_CHG_CTRL_END_THR, }; +/* + * Xiaomi Taoyao firmware has BATT_CONSTANT_CURRENT (ID 12) inserted + * between BATT_CHG_CTRL_LIM_MAX and BATT_TEMP, shifting all subsequent + * IDs by one. + */ +static const u8 taoyao_bat_prop_map[] = { + [POWER_SUPPLY_PROP_STATUS] = BATT_STATUS, + [POWER_SUPPLY_PROP_HEALTH] = BATT_HEALTH, + [POWER_SUPPLY_PROP_PRESENT] = BATT_PRESENT, + [POWER_SUPPLY_PROP_CHARGE_TYPE] = BATT_CHG_TYPE, + [POWER_SUPPLY_PROP_CAPACITY] = BATT_CAPACITY, + [POWER_SUPPLY_PROP_VOLTAGE_OCV] = BATT_VOLT_OCV, + [POWER_SUPPLY_PROP_VOLTAGE_NOW] = BATT_VOLT_NOW, + [POWER_SUPPLY_PROP_VOLTAGE_MAX] = BATT_VOLT_MAX, + [POWER_SUPPLY_PROP_CURRENT_NOW] = BATT_CURR_NOW, + [POWER_SUPPLY_PROP_TEMP] = BATT_TEMP + 1, + [POWER_SUPPLY_PROP_TECHNOLOGY] = BATT_TECHNOLOGY + 1, + [POWER_SUPPLY_PROP_CHARGE_COUNTER] = BATT_CHG_COUNTER + 1, + [POWER_SUPPLY_PROP_CYCLE_COUNT] = BATT_CYCLE_COUNT + 1, + [POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN] = BATT_CHG_FULL_DESIGN + 1, + [POWER_SUPPLY_PROP_CHARGE_FULL] = BATT_CHG_FULL + 1, + [POWER_SUPPLY_PROP_MODEL_NAME] = BATT_MODEL_NAME + 1, + [POWER_SUPPLY_PROP_TIME_TO_FULL_AVG] = BATT_TTF_AVG + 1, + [POWER_SUPPLY_PROP_TIME_TO_EMPTY_AVG] = BATT_TTE_AVG + 1, + [POWER_SUPPLY_PROP_INTERNAL_RESISTANCE] = BATT_RESISTANCE + 1, + [POWER_SUPPLY_PROP_STATE_OF_HEALTH] = BATT_SOH, + [POWER_SUPPLY_PROP_POWER_NOW] = BATT_POWER_NOW + 1, + [POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD] = BATT_CHG_CTRL_START_THR + 1, + [POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD] = BATT_CHG_CTRL_END_THR + 1, +}; + +/* + * Reverse mapping from Xiaomi Taoyao firmware property IDs to canonical + * kernel property IDs. + */ +static const u8 taoyao_to_canonical[] = { + [BATT_STATUS] = BATT_STATUS, + [BATT_HEALTH] = BATT_HEALTH, + [BATT_PRESENT] = BATT_PRESENT, + [BATT_CHG_TYPE] = BATT_CHG_TYPE, + [BATT_CAPACITY] = BATT_CAPACITY, + [BATT_SOH] = BATT_SOH, + [BATT_VOLT_OCV] = BATT_VOLT_OCV, + [BATT_VOLT_NOW] = BATT_VOLT_NOW, + [BATT_VOLT_MAX] = BATT_VOLT_MAX, + [BATT_CURR_NOW] = BATT_CURR_NOW, + [BATT_CHG_CTRL_LIM] = BATT_CHG_CTRL_LIM, + [BATT_CHG_CTRL_LIM_MAX] = BATT_CHG_CTRL_LIM_MAX, + [BATT_CHG_CTRL_LIM_MAX + 1] = 0xff, /* BATT_CONSTANT_CURRENT - never requested */ + [BATT_TEMP + 1] = BATT_TEMP, + [BATT_TECHNOLOGY + 1] = BATT_TECHNOLOGY, + [BATT_CHG_COUNTER + 1] = BATT_CHG_COUNTER, + [BATT_CYCLE_COUNT + 1] = BATT_CYCLE_COUNT, + [BATT_CHG_FULL_DESIGN + 1] = BATT_CHG_FULL_DESIGN, + [BATT_CHG_FULL + 1] = BATT_CHG_FULL, + [BATT_MODEL_NAME + 1] = BATT_MODEL_NAME, + [BATT_TTF_AVG + 1] = BATT_TTF_AVG, + [BATT_TTE_AVG + 1] = BATT_TTE_AVG, + [BATT_RESISTANCE + 1] = BATT_RESISTANCE, + [BATT_POWER_NOW + 1] = BATT_POWER_NOW, + [BATT_POWER_AVG + 1] = BATT_POWER_AVG, + [BATT_CHG_CTRL_EN + 1] = BATT_CHG_CTRL_EN, + [BATT_CHG_CTRL_START_THR + 1] = BATT_CHG_CTRL_START_THR, + [BATT_CHG_CTRL_END_THR + 1] = BATT_CHG_CTRL_END_THR, +}; + static int qcom_battmgr_bat_sm8350_update(struct qcom_battmgr *battmgr, enum power_supply_property psp) { unsigned int prop; int ret; - if (psp >= ARRAY_SIZE(sm8350_bat_prop_map)) - return -EINVAL; - - prop = sm8350_bat_prop_map[psp]; + if (battmgr->variant == QCOM_BATTMGR_TAOYAO) { + if (psp >= ARRAY_SIZE(taoyao_bat_prop_map)) + return -EINVAL; + prop = taoyao_bat_prop_map[psp]; + } else { + if (psp >= ARRAY_SIZE(sm8350_bat_prop_map)) + return -EINVAL; + prop = sm8350_bat_prop_map[psp]; + } mutex_lock(&battmgr->lock); ret = qcom_battmgr_request_property(battmgr, BATTMGR_BAT_PROPERTY_GET, prop, 0); @@ -1381,6 +1453,11 @@ static void qcom_battmgr_sm8350_callback(struct qcom_battmgr *battmgr, switch (opcode) { case BATTMGR_BAT_PROPERTY_GET: property = le32_to_cpu(resp->intval.property); + + if (battmgr->variant == QCOM_BATTMGR_TAOYAO && + property < ARRAY_SIZE(taoyao_to_canonical)) + property = taoyao_to_canonical[property]; + if (property == BATT_MODEL_NAME) { if (payload_len != sizeof(resp->strval)) { dev_warn(battmgr->dev, @@ -1617,6 +1694,7 @@ static const struct of_device_id qcom_battmgr_of_variants[] = { { .compatible = "qcom,sc8280xp-pmic-glink", .data = (void *)QCOM_BATTMGR_SC8280XP }, { .compatible = "qcom,sm8550-pmic-glink", .data = (void *)QCOM_BATTMGR_SM8550 }, { .compatible = "qcom,x1e80100-pmic-glink", .data = (void *)QCOM_BATTMGR_X1E80100 }, + { .compatible = "xiaomi,taoyao-pmic-glink", .data = (void *)QCOM_BATTMGR_TAOYAO }, /* Unmatched devices falls back to QCOM_BATTMGR_SM8350 */ {} }; -- 2.53.0