From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: broonie@kernel.org
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: [PATCH] ASoC: cs35l56: Add KUnit tests for regmap defaults table
Date: Tue, 15 Sep 2026 11:31:21 +0100 [thread overview]
Message-ID: <20260915103121.3306373-1-rf@opensource.cirrus.com> (raw)
Add test cases to cs35l56-shared-test to sanity-check the regmap defaults
table:
- Table is sorted in order of increasing address (which also means there
cannot be duplicate entries).
- Volatile registers don't have a default.
- Defaulted registers are readable.
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
---
sound/soc/codecs/cs35l56-shared-test.c | 56 ++++++++++++++++++++++++++
1 file changed, 56 insertions(+)
diff --git a/sound/soc/codecs/cs35l56-shared-test.c b/sound/soc/codecs/cs35l56-shared-test.c
index 4f52c8a192e55..34bb3d44b51f1 100644
--- a/sound/soc/codecs/cs35l56-shared-test.c
+++ b/sound/soc/codecs/cs35l56-shared-test.c
@@ -29,6 +29,7 @@ struct cs35l56_shared_test_priv {
struct faux_device *gpio_dev;
struct cs35l56_shared_test_mock_gpio *gpio_priv;
struct regmap *registers;
+ const struct regmap_config *regmap_config;
unsigned int reg_offset;
struct cs35l56_base *cs35l56_base;
u8 applied_pad_pull_state[CS35L56_MAX_GPIO];
@@ -614,6 +615,55 @@ static void cs35l56_shared_test_get_speaker_id_from_host_gpio(struct kunit *test
KUNIT_EXPECT_EQ(test, cs35l56_get_speaker_id(priv->cs35l56_base), param->spkid);
}
+static void cs35l56_shared_test_sorted_regmap_defaults(struct kunit *test)
+{
+ struct cs35l56_shared_test_priv *priv = test->priv;
+ const struct reg_default *defaults;
+ int i;
+
+ KUNIT_ASSERT_NOT_NULL(test, priv->regmap_config);
+ defaults = priv->regmap_config->reg_defaults;
+ KUNIT_ASSERT_NOT_NULL(test, defaults);
+ KUNIT_ASSERT_NE(test, priv->regmap_config->num_reg_defaults, 0);
+
+ for (i = 1; i < priv->regmap_config->num_reg_defaults; i++)
+ KUNIT_EXPECT_LT(test, defaults[i - 1].reg, defaults[i].reg);
+}
+
+static void cs35l56_shared_test_regmap_defaults_not_volatile(struct kunit *test)
+{
+ struct cs35l56_shared_test_priv *priv = test->priv;
+ struct cs35l56_base *cs35l56_base = priv->cs35l56_base;
+ const struct regmap_config *config = priv->regmap_config;
+ int i;
+
+ KUNIT_ASSERT_NOT_NULL(test, config);
+ KUNIT_ASSERT_NOT_NULL(test, config->volatile_reg);
+
+ for (i = 0; i < config->num_reg_defaults; i++) {
+ KUNIT_EXPECT_FALSE(test,
+ config->volatile_reg(cs35l56_base->dev,
+ config->reg_defaults[i].reg));
+ }
+}
+
+static void cs35l56_shared_test_regmap_defaults_readable(struct kunit *test)
+{
+ struct cs35l56_shared_test_priv *priv = test->priv;
+ struct cs35l56_base *cs35l56_base = priv->cs35l56_base;
+ const struct regmap_config *config = priv->regmap_config;
+ int i;
+
+ KUNIT_ASSERT_NOT_NULL(test, config);
+ KUNIT_ASSERT_NOT_NULL(test, config->readable_reg);
+
+ for (i = 0; i < config->num_reg_defaults; i++) {
+ KUNIT_EXPECT_TRUE(test,
+ config->readable_reg(cs35l56_base->dev,
+ config->reg_defaults[i].reg));
+ }
+}
+
static int cs35l56_shared_test_case_regmap_init(struct kunit *test,
const struct regmap_config *regmap_config)
{
@@ -645,6 +695,8 @@ static int cs35l56_shared_test_case_regmap_init(struct kunit *test,
kunit_add_action_or_reset(test, regmap_exit_wrapper,
cs35l56_base->regmap));
+ priv->regmap_config = regmap_config;
+
return 0;
}
@@ -862,6 +914,10 @@ static struct kunit_case cs35l56_shared_test_cases[] = {
cs35l56_shared_test_host_gpio_spkid_gen_params,
{ KUNIT_SPEED_SLOW }),
+ KUNIT_CASE(cs35l56_shared_test_sorted_regmap_defaults),
+ KUNIT_CASE(cs35l56_shared_test_regmap_defaults_not_volatile),
+ KUNIT_CASE(cs35l56_shared_test_regmap_defaults_readable),
+
{ }
};
--
2.47.3
next reply other threads:[~2026-09-15 10:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 10:31 Richard Fitzgerald [this message]
2026-09-15 14:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915103121.3306373-1-rf@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®