From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs2-f12.google.com (mail-vs2-f12.google.com [74.125.227.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9438641A574 for ; Tue, 15 Sep 2026 11:14:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789470869; cv=none; b=IiKBEAYIOEoBaUn9Q/YMvC8x996xxJFQtL0RqWVfLyknALQ/rb3ALWauNAf7CWwBc6HCeNUZfGrm6BvvXdhVLb9SQ36MiL0yzO/e10Uv9A1rdAUOab1lggYUDeqBesV2cYmPauT44mIn8s8O9Rhc27exYASXX1rV0LJw3E6lsVU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789470869; c=relaxed/simple; bh=/oB6vaOXGg5+3zOLKgYNrRDA/rQtpvhIZtESt0iNrCU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pRA+9EHfouf79b2gLS8vB8QuxUoQq548AX7pKXEyO9plRLt5IPnylqzvJdOUQM+RnV4agzPz53HZxvgH1TT+2KhspjUA76dyfecStOPXt6dwDjA4fqnpkpRTTxS0Gz2g7to53si5kRUB2mouN65BEIxRKJrC6F5hqY/JJIf7cRs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IrFmsY8V; arc=none smtp.client-ip=74.125.227.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IrFmsY8V" Received: by mail-vs2-f12.google.com with SMTP id 71dfb90a1353d-5c67e4d9197so2538294e0c.0 for ; Tue, 15 Sep 2026 04:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789470866; x=1790075666; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=FAuAan9y645zprFQBzGcUeZpc28nMxYe+p5U/JKA+9w=; b=IrFmsY8Vm0oNl1Slv+vA+t2gkkYrXCSzo7+aq4bNg73a8fCBGC62P1o8bRgzt42PAA QfDAm3zXPzDF3CaKfFaL7eiB/gUD7fvfCWOMpxqSVRPHo597txkiRUOmb2XZpfEIN6PF giXqxEPkPfz2X7YqXc8XmAtZCJuTiuUDlJp8XCNz98vbTFEnHAkLHj9mEKUd6ZapdDX4 5iDyMK+u+ZyZ2hgx8+mMhm3zHNCt7FWw629UZkpfU7zKt6MsZIbS6/o0YKzx72Y5wPLT zZCpuq7WXyOQPFTyE3iLd/QjUb6VOMyIdd41mVFcfXFS2+mzy7knUk0S6kz1HDiiisj8 CAvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789470866; x=1790075666; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FAuAan9y645zprFQBzGcUeZpc28nMxYe+p5U/JKA+9w=; b=WY9+CGRe9GmvWW0PtDK/knVCXpajjNUdnKF0aE5Jxf1ZI+trRp/Pys0oTp7tRJgy6O PjI7aqLRHOkqRrIxZ1LNOQBqdGwv0y2e+E4HW5B5lQVh21Cf4n3K3QnmejwW24q/mPf9 /s3RgjSMfbtUvUmzVzPTR+9+ZVr4e5+dJ2QQNYraWN/lB5SzsI4ou5/c5OBCfiqUOvkr 7D+f9qcMyg+/LoryoIliBLrsMZmK9Ois8UCsCs6/eldx4riYiuw+bt0BpH0wnC48i6h3 gNl2k5U/tKwi458htVd4VP2jUggIk6ZiVhJfeUp61VX8cgWUX2lQ74jD/0lb0bO/6lFW y3uA== X-Forwarded-Encrypted: i=1; AKwUvBzz8Zz2tGEgLje8pb+pAD9x3Kw4bQVbG0M86ublee5fVSVAykvPByzcUj8vI/o1jemrxaLQFLLW5doFZQE=@vger.kernel.org X-Gm-Message-State: AFuF++m5xkmWAIGHlry1TwqT9yn1vHW2piO8edrGv7sJnFOtTND9hvxx RS5Jn8urIDp45mfWP2NWMygYrji2F8wMl22bada0FeMlBUD7Sv6Bow3q X-Gm-Gg: AYBFou0Qo/ZlEZnvfT+z8bwrIUD6TnkOYTmrsNyHnB77Tn2VLvVuADfR1iIapeUTr/Z 1lKMQ7UYu4JC0u2YZrpzIJ1QdmU0zp0yB1nG5+G560mwbyWaOftkHJQ3FX0iE+R7pAOXFsrjgPV F7cN40kJKcBIrmNMpF3a16wlrH8U+XnLqy6lQb02PhNRH5eMv1Bn1MQ/tMvu3BLp0lW4eeC3WVo OkWaN3b9juSOv4yNdk4LMa+Uv6vgoUvKdRLNIMkvlnpaZF7zb+63hesEbE1bMu1+TIA/P7V5Acq l4tbsAzlaOwkzujpyZQoV/ovSv+ZIrSZ1KDEEx2CBuYBVinHhb/806RkBT+aeC+NAVrRnkDzwCC k5+NE04FUPwcJQqakryQdbVYERxtHD+a/NtL2TBkiJti/jPP6hdQ4FLRKzrwQhwyg1pue+7S/Ux SQxnRIgHtQKJS8M8WhLzV/L4UZRlZW4VjN3F7e5ZN1XgMXV4ePvNcX5e45wX8veS78 X-Received: by 2002:a05:6122:894:b0:5c7:ebed:1018 with SMTP id 71dfb90a1353d-5c981d87e33mr4414877e0c.8.1789470866398; Tue, 15 Sep 2026 04:14:26 -0700 (PDT) Received: from beelink.. ([187.13.206.89]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5c846f76238sm14577407e0c.2.2026.09.15.04.14.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 04:14:26 -0700 (PDT) From: Aldo Ariel Panzardo To: Stefano Garzarella Cc: virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Aldo Ariel Panzardo Subject: [PATCH] vsock: preserve child namespace mode on an empty write Date: Tue, 15 Sep 2026 08:14:17 -0300 Message-ID: <20260915111417.2726515-1-qwe.aldo@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit __vsock_net_mode_string() returns success without updating new_mode when the write length is zero. Its caller then reads the uninitialized enum and may permanently store a stack-derived value in the write-once child mode. Initialize new_mode from the current child mode so that an empty write is a no-op. Fixes: eafb64f40ca4 ("vsock: add netns to vsock core") Cc: stable@vger.kernel.org Signed-off-by: Aldo Ariel Panzardo --- net/vmw_vsock/af_vsock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c index 622dbd0467..61163357ae 100644 --- a/net/vmw_vsock/af_vsock.c +++ b/net/vmw_vsock/af_vsock.c @@ -2878,6 +2878,7 @@ static int vsock_net_child_mode_string(const struct ctl_table *table, int write, int ret; net = container_of(table->data, struct net, vsock.child_ns_mode); + new_mode = vsock_net_child_mode(net); ret = __vsock_net_mode_string(table, write, buffer, lenp, ppos, vsock_net_child_mode(net), &new_mode); -- 2.43.0