From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B6D63D34B3; Tue, 15 Sep 2026 12:05:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789473928; cv=none; b=t0aU7tIWK5ugezysbnTb2kFi99o8MHEUzPNC2yTEJOv1s1QeZlBEkgb9rf1sX8VXr1QRTDjf080JYuG/SpUu2Lz30C5T7Dab+0RFbTI+uZN3xlC+mlJvNjFAg1N1/91iZqqHv8C34J1pLhTjIzhUtRrTWVvhFb8nadq1ub5jImo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789473928; c=relaxed/simple; bh=9fBEtIbr3AFyAksoQqS3Fbydy5vpB4nMaKZT39mGc48=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=VXXF8OM130Sh+nW/+VkPutQ//qz9eEy1Gyk/K2SI7FWB/WPIPPARkdThkYntKsOKS9H6HA0rNX161aCQhGANuIcU4KSgnjzJbTlKeyeXx9UvcQxdeJnL6oh5kv3lazdtvaCBxJY/eorc3eSMIzu8Ovum9yFUhX8Cil4TSVpNZeg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ciTyjsYi; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ciTyjsYi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4910B1F000FF; Tue, 15 Sep 2026 12:05:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789473927; bh=9fBEtIbr3AFyAksoQqS3Fbydy5vpB4nMaKZT39mGc48=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ciTyjsYio6YcUd6U+CzkUXMFWJVI5JN8YpF3LWAF35D4RcZO6WNyNNLXWTcTNKx/k phMotj0kCSRJiLRwEB6PukDAqeOWTf+ZkB0jp+D5F2leVdFoUNkcjEaKJx1upIioCP CUcHsmrqrKX9GAlkCPX6E26buGa/rDYMQLBRn2YZpYiLqv6kE2OPMZp+B2G/43JgPY VQ3gvXiSdHMDyE74NA/AxGmidg9o/oGBR74v2qXcAt1S74qyth1DbIflVP8V9zvpQm 0rcjVCp5RxoIduGdCiF4608I/waS+6ME56RhQGnLGMkkRdYNrNVYyQVY30p5DEkuKy JPaEc4INykdeQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH RFC POC 25/50] file: reimplement FD_PREPARE() on the deferred fd_prepare() path Reply-To: sashiko-reviews@lists.linux.dev To: "Linus Torvalds" , "Christian Brauner" Cc: "Jens Axboe" , "Peter Zijlstra" , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, "Michael S. Tsirkin" , linux-mm@kvack.org, linux-hyperv@vger.kernel.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, linux-parisc@vger.kernel.org, linux-gpio@vger.kernel.org, virtualization@lists.linux.dev, "Ingo Molnar" , linux-um@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-csky@vger.kernel.org, "Alexander Viro" , bpf@vger.kernel.org, linux-snps-arc@lists.infradead.org, io-uring@vger.kernel.org, =?utf-8?b?Q2hyaXN0aWFuIEJyYXVuZXIgKEFtdXRhYmxlKQ==?= , "Oleg Nesterov" , "Eugenio Perez" , kexec@lists.infradead.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-arm-msm@vger.kernel.org, "Jann Horn" , "David Airlie" , linux-sh@vger.kernel.org, "Jan Kara" , linux-fsdevel@vger.kernel.org In-Reply-To: <20260915-work-fd-reserve-unify-folded-v1-25-4d5217d6b246@kernel.org> References: <20260915-work-fd-reserve-unify-folded-v1-0-4d5217d6b246@kernel.org> <20260915-work-fd-reserve-unify-folded-v1-25-4d5217d6b246@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 15 Sep 2026 12:05:24 +0000 Message-Id: <20260915120525.4910B1F000FF@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > The FD_PREPARE() cleanup class allocated and installed immediately and > required fd_publish() to be the last thing that could fail. Reimplement > it on the deferred path. FD_PREPARE() reserves a slot with fd_prepare() > and stages the file on it. The syscall exit installs on success and > drops on error. fd_prepare_fd() and fd_prepare_file() now read the slot. > fd_publish() is gone. >=20 > Convert every FD_PREPARE() user since fdf.err can now become a simple > IS_ERR(fdf). >=20 > Signed-off-by: Christian Brauner (Amutable) Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260915-work-fd-re= serve-unify-folded-v1-0-4d5217d6b246@kernel.org?part=3D25