From: patryk.dankow@protonmail.com
To: platform-driver-x86@vger.kernel.org
Cc: "Patryk Dańków" <patryk.dankow@protonmail.com>,
corentin.chary@gmail.com, luke@ljones.dev,
denis.benato@linux.dev, hansg@kernel.org,
ilpo.jarvinen@linux.intel.com, linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] platform/x86: asus-wmi: Add mute LED support
Date: Tue, 15 Sep 2026 17:41:28 +0000 [thread overview]
Message-ID: <20260915174110.67871-2-patryk.dankow@protonmail.com> (raw)
In-Reply-To: <20260915174110.67871-1-patryk.dankow@protonmail.com>
From: Patryk Dańków <patryk.dankow@protonmail.com>
Add support for WMI device 0x0004001c and register it as the
platform::mute LED using the audio-mute trigger.
The device ID is present in the PM3406CKA DSDT and is also used
by GHelper for controlling the same LED.
Tested on ASUS ExpertBook PM3406CKA.
Signed-off-by: Patryk Dańków <patryk.dankow@protonmail.com>
---
drivers/platform/x86/asus-wmi.c | 26 +++++++++++++++++++++-
include/linux/platform_data/x86/asus-wmi.h | 1 +
2 files changed, 26 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index a65090429ca7..d7c100dc2020 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -262,6 +262,7 @@ struct asus_wmi {
struct led_classdev lightbar_led;
int lightbar_led_wk;
struct led_classdev micmute_led;
+ struct led_classdev mute_led;
struct led_classdev camera_led;
struct workqueue_struct *led_workqueue;
struct work_struct tpd_led_work;
@@ -2054,6 +2055,16 @@ static int micmute_led_set(struct led_classdev *led_cdev,
return err < 0 ? err : 0;
}
+static int mute_led_set(struct led_classdev *led_cdev,
+ enum led_brightness brightness)
+{
+ int state = brightness != LED_OFF;
+ int err;
+
+ err = asus_wmi_set_devstate(ASUS_WMI_DEVID_MUTE_LED, state, NULL);
+ return err < 0 ? err : 0;
+}
+
static enum led_brightness camera_led_get(struct led_classdev *led_cdev)
{
struct asus_wmi *asus;
@@ -2084,6 +2095,7 @@ static void asus_wmi_led_exit(struct asus_wmi *asus)
led_classdev_unregister(&asus->wlan_led);
led_classdev_unregister(&asus->lightbar_led);
led_classdev_unregister(&asus->micmute_led);
+ led_classdev_unregister(&asus->mute_led);
led_classdev_unregister(&asus->camera_led);
if (asus->led_workqueue)
@@ -2176,7 +2188,19 @@ static int asus_wmi_led_init(struct asus_wmi *asus)
asus->micmute_led.default_trigger = "audio-micmute";
rv = led_classdev_register(&asus->platform_device->dev,
- &asus->micmute_led);
+ &asus->micmute_led);
+ if (rv)
+ goto error;
+ }
+
+ if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_MUTE_LED)) {
+ asus->mute_led.name = "platform::mute";
+ asus->mute_led.max_brightness = 1;
+ asus->mute_led.brightness_set_blocking = mute_led_set;
+ asus->mute_led.default_trigger = "audio-mute";
+
+ rv = led_classdev_register(&asus->platform_device->dev,
+ &asus->mute_led);
if (rv)
goto error;
}
diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/platform_data/x86/asus-wmi.h
index b5ed8c83ace1..3810c4a0da23 100644
--- a/include/linux/platform_data/x86/asus-wmi.h
+++ b/include/linux/platform_data/x86/asus-wmi.h
@@ -54,6 +54,7 @@
#define ASUS_WMI_DEVID_LED5 0x00020015
#define ASUS_WMI_DEVID_LED6 0x00020016
#define ASUS_WMI_DEVID_MICMUTE_LED 0x00040017
+#define ASUS_WMI_DEVID_MUTE_LED 0x0004001C
/* Disable Camera LED */
#define ASUS_WMI_DEVID_CAMERA_LED_NEG 0x00060078 /* 0 = on (unused) */
--
2.55.0
next prev parent reply other threads:[~2026-09-15 17:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 17:41 [PATCH 0/2] Add ASUS ExpertBook " patryk.dankow
2026-09-15 17:41 ` patryk.dankow [this message]
2026-09-15 19:43 ` [PATCH 1/2] platform/x86: asus-wmi: Add " Denis Benato
2026-09-15 17:41 ` [PATCH 2/2] ALSA: hda/realtek: Add mute LED support for ASUS PM3406CKA patryk.dankow
2026-09-16 7:40 ` Takashi Iwai
2026-09-18 18:27 ` [PATCH 0/2] Add ASUS ExpertBook mute LED support Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915174110.67871-2-patryk.dankow@protonmail.com \
--to=patryk.dankow@protonmail.com \
--cc=corentin.chary@gmail.com \
--cc=denis.benato@linux.dev \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®