From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv2-f12.google.com (mail-qv2-f12.google.com [74.125.230.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D0CA4BE435 for ; Tue, 15 Sep 2026 18:12:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789495960; cv=none; b=Uv7n1A9U4y8rRZrRZ/44G2CYq68oS8UvOoQ/gUdNSM7MaHTExZoH3h/xkVde48Q7N6bY3kJ/GUcFFAq2PSmx2ySvM/GcFm7CUmwDdnhVpSsujBGBodKBYO+oE+FJhQVZELIpuNHa39ETbI5xboBWCqIchlFTbC23GnECNpj55xw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789495960; c=relaxed/simple; bh=h784MP3GL66ANK9SwpoPDMFk96LfsbUTuZMSPWcnTck=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=npbVZFw1HmHUNLkOtZm4L3yVkWeEcCtuM6UJT7FzuewMXZJFnXqBb/5tOcHSK8Gta2GLaPPoX3y3lzQ1jvSU4E3HGwa9fjymx7djbazaJCOF9voXSJTX8EikTgvi3cjIhO+Uyzk40WJJzTB06q5B9vaBaqINQTbcJaJ4k02lSdM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cURIcHye; arc=none smtp.client-ip=74.125.230.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cURIcHye" Received: by mail-qv2-f12.google.com with SMTP id 6a1803df08f44-910537b51a0so498796d6.3 for ; Tue, 15 Sep 2026 11:12:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789495958; x=1790100758; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=6fvPaWKuH74Rj66uteSOuQL+AbF/NoYDvfe8MEEc324=; b=cURIcHyeNK1GRgwEqc50vW+lkGUm9P32lQhAMw6XirfmUJD3K/w7Hf93Pez+NBmx+3 S7FY9pLPf2A9LzatZPxtkhjL5aQ+r6bOcAqId8tPrGmEI75Ql7C7my4OQ8UEtNvk9CPn D3GV446IYqwhpTslYnooAlEG26T9dR9V79MZjAf4xSFwMiLhOvDDAn5jlKjyw/goRLL5 /NSrygzb5X/8TnpFmwKRCJ9ZTm4ozItXqMWR0sjNYKUiZGgVmZbPfzhxyqAGMbKSXQ1l 9SezDuaPbIRt8q3oOL5Sauu+7l/7CahwH3WhrR3cRMiFMIVcpR3/CfG41qmlPWDO+/ta Rd+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789495958; x=1790100758; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6fvPaWKuH74Rj66uteSOuQL+AbF/NoYDvfe8MEEc324=; b=GjdAzIw2PXeXkZ1k6UtJRlBPTMr6PZ1OoFwV40jqfs/iu8nB0TJE7jvGHXN7PaS+zy EStrV9vbP5YdFlg1sl9Y9PC4J5MLiJwuX0Va0ruhzueUlyV6Giao2zIr/ektWzfu41K9 BHOMaUfH9MJ1w6ogLj0/vnyWoE88UHhkGQwXXwNviuBJeh7zI/aRBVnLUhYu3VJq3G9+ YHr/3oz+3yebkAoAKMEzVHr7NgOJX4+HfXDHGsV7R3OH6lCneBcmpKThvxltEyPrxP1B CM/2CgOh5wHrK5471PzahORXaUo5+khvjH5iV10hUL6PxuRGlvKhQXHHOs0f/dVvqxjV UP4A== X-Forwarded-Encrypted: i=1; AKwUvByy0HGYpMEni3DorU7JU6+Y4NRFgokiQHdN6dAi3gWe4y0ZKtIsY0Z4XHRvfr+H4QHjhpMlSFtNhlMZGL8=@vger.kernel.org X-Gm-Message-State: AFuF++kmdHLpr4Yo9R8IMnvJwWK8hVmJg+MPhp6ftK24//lX0rrL3Wl3 MeEEJBLlkKwUfeuvHZyer8YPwyubpZGziMEEHlX8xz5e/egfk1Ri1PvW6cnLqw== X-Gm-Gg: AYBFou2tqty9xuhKSXyiUFpQzgVniT22SzEXw0P/UcSl5K9KZqD7toEo4TdjkrDyJSq KYvg0Cm7YmytYZvklp8b86+VJP5bG1qycZgf9A7nTVCMt39Ksj53ds1maq/Cn9NYczFHfCaSUYL Wr6czIBZy26gtEORdHz5YNIm8/ta23vXWxzbldv6C1lPdyAx858qBlZPma2XC+jJWxAhZ9UrtD5 LysnghRjG3U0feUvpZQNmBT4QOm3gm56Qi25yJWwlZeJnHvvIE7r2qKzgr514aMC5ygq4xgTVVn wxMCyJUoyeJLKxQnWWEXmFPFfhFhB7dDvIUvlOepCN7DN8psKTeujrQmSsz5/IvwiSMqX7dH0UF 6ajXxGDc/QpQoTFrMMsxMIqgE6EeQTvoE0l6q3GXmyKch9x0QbLjrlFj1JmEsVDnXcO1PwdvyPy 5xMiMPPBSASZ7c06K1pIkjljdSuCLI6qLijOrqwpqY/ZPjZCuTfZ6Q8ag97iH8A8zCy8nnFW9/M 7V+TNozJsDTnSASo2AZZ3X2b1t8lopTXhUcjbvsM1K+OxHTYG+9zPwiEXzyuxTzyUpEtwHUaFqD mQwLvCZCO8d1fULiwZ+h0nJc+fhBam26cpmsLMnrYqk3wVeU X-Received: by 2002:a05:6214:2128:b0:911:2a79:cf11 with SMTP id 6a1803df08f44-9123a526c78mr33549316d6.22.1789495957590; Tue, 15 Sep 2026 11:12:37 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9123bed6f76sm4250996d6.43.2026.09.15.11.12.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 11:12:37 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , "Christophe Leroy (CS GROUP)" , linux-kernel@vger.kernel.org (open list), linuxppc-dev@lists.ozlabs.org (open list:FREESCALE SOC DRIVERS), linux-arm-kernel@lists.infradead.org (moderated list:FREESCALE SOC DRIVERS) Subject: [PATCH] dmaengine: bestcomm: use platform machinery to get irq Date: Tue, 15 Sep 2026 11:12:34 -0700 Message-ID: <20260915181234.9839-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit platform_get_irq() avoids having to explicitly map and dispose of an irq by having the platform_device machinery take care of it. This requires replacing the device_node with a platform_device in the bcom_eng struct so that platform_get_irq() can use it. Conveniently, this also allows getting rid of of_node_get and of_node_put as the platform_device machinery also handles that. Adjust the goto labels in bcom_task_alloc to match what is being freed. Signed-off-by: Rosen Penev --- drivers/dma/bestcomm/bestcomm.c | 47 ++++++++-------------- include/linux/fsl/bestcomm/bestcomm_priv.h | 2 +- 2 files changed, 18 insertions(+), 31 deletions(-) diff --git a/drivers/dma/bestcomm/bestcomm.c b/drivers/dma/bestcomm/bestcomm.c index 241a91936fe8..1006030ff167 100644 --- a/drivers/dma/bestcomm/bestcomm.c +++ b/drivers/dma/bestcomm/bestcomm.c @@ -47,6 +47,7 @@ bcom_task_alloc(int bd_count, int bd_size, int priv_size) { int i, tasknum = -1; struct bcom_task *tsk; + int irq; /* Don't try to do anything if bestcomm init failed */ if (!bcom_eng) @@ -67,30 +68,32 @@ bcom_task_alloc(int bd_count, int bd_size, int priv_size) if (tasknum < 0) return NULL; + irq = platform_get_irq(bcom_eng->pdev, tasknum); + if (irq < 0) + goto err1; + /* Allocate our structure */ tsk = kzalloc(sizeof(struct bcom_task) + priv_size, GFP_KERNEL); if (!tsk) - goto error; + goto err1; tsk->tasknum = tasknum; if (priv_size) tsk->priv = (void*)tsk + sizeof(struct bcom_task); /* Get IRQ of that task */ - tsk->irq = irq_of_parse_and_map(bcom_eng->ofnode, tsk->tasknum); - if (!tsk->irq) - goto error; + tsk->irq = irq; /* Init the BDs, if needed */ if (bd_count) { tsk->cookie = kmalloc_array(bd_count, sizeof(void *), GFP_KERNEL); if (!tsk->cookie) - goto error; + goto err2; tsk->bd = bcom_sram_alloc(bd_count * bd_size, 4, &tsk->bd_pa); if (!tsk->bd) - goto error; + goto err3; memset_io(tsk->bd, 0x00, bd_count * bd_size); tsk->num_bd = bd_count; @@ -99,17 +102,12 @@ bcom_task_alloc(int bd_count, int bd_size, int priv_size) return tsk; -error: - if (tsk) { - if (tsk->irq) - irq_dispose_mapping(tsk->irq); - bcom_sram_free(tsk->bd); - kfree(tsk->cookie); - kfree(tsk); - } - +err3: + kfree(tsk->cookie); +err2: + kfree(tsk); +err1: bcom_eng->tdt[tasknum].stop = 0; - return NULL; } EXPORT_SYMBOL_GPL(bcom_task_alloc); @@ -125,7 +123,6 @@ bcom_task_free(struct bcom_task *tsk) bcom_eng->tdt[tsk->tasknum].stop = 0; /* Free everything */ - irq_dispose_mapping(tsk->irq); bcom_sram_free(tsk->bd); kfree(tsk->cookie); kfree(tsk); @@ -377,16 +374,12 @@ static int mpc52xx_bcom_probe(struct platform_device *op) if (IS_ERR(regs)) return PTR_ERR(regs); - /* Get the bestcomm node */ - of_node_get(op->dev.of_node); - /* Prepare SRAM */ ofn_sram = of_find_matching_node(NULL, mpc52xx_sram_ids); if (!ofn_sram) { printk(KERN_ERR DRIVER_NAME ": " "No SRAM found in device tree\n"); - rv = -ENODEV; - goto error_ofput; + return -ENODEV; } rv = bcom_sram_init(ofn_sram, DRIVER_NAME); of_node_put(ofn_sram); @@ -394,7 +387,7 @@ static int mpc52xx_bcom_probe(struct platform_device *op) if (rv) { printk(KERN_ERR DRIVER_NAME ": " "Error in SRAM init\n"); - goto error_ofput; + return rv; } /* Get a clean struct */ @@ -405,8 +398,7 @@ static int mpc52xx_bcom_probe(struct platform_device *op) } /* Save the node */ - bcom_eng->ofnode = op->dev.of_node; - + bcom_eng->pdev = op; bcom_eng->regs = regs; bcom_eng->regs_base = res_bcom->start; @@ -426,8 +418,6 @@ static int mpc52xx_bcom_probe(struct platform_device *op) kfree(bcom_eng); bcom_eng = NULL; bcom_sram_cleanup(); -error_ofput: - of_node_put(op->dev.of_node); printk(KERN_ERR "DMA: MPC52xx BestComm init failed !\n"); @@ -443,9 +433,6 @@ static void mpc52xx_bcom_remove(struct platform_device *op) /* Cleanup SRAM */ bcom_sram_cleanup(); - /* Release the node */ - of_node_put(bcom_eng->ofnode); - /* Release memory */ kfree(bcom_eng); bcom_eng = NULL; diff --git a/include/linux/fsl/bestcomm/bestcomm_priv.h b/include/linux/fsl/bestcomm/bestcomm_priv.h index 3b52f3ffbdf8..cddde7c74cb5 100644 --- a/include/linux/fsl/bestcomm/bestcomm_priv.h +++ b/include/linux/fsl/bestcomm/bestcomm_priv.h @@ -66,7 +66,7 @@ struct bcom_tdt { * This holds all info needed globaly to handle the engine */ struct bcom_engine { - struct device_node *ofnode; + struct platform_device *pdev; struct mpc52xx_sdma __iomem *regs; phys_addr_t regs_base; -- 2.55.0