From: Thorsten Blum <blum@kernel.org>
To: Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Ard Biesheuvel <ardb@kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Thomas Zimmermann <tzimmermann@suse.de>,
"Pratyush Yadav (Google)" <pratyush@kernel.org>,
Breno Leitao <leitao@debian.org>,
Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
Javier Martinez Canillas <javierm@redhat.com>,
Francesco Pompo <francescopompo2@gmail.com>,
Lenny Szubowicz <lszubowi@redhat.com>,
x86@kernel.org, Thorsten Blum <blum@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
Ingo Molnar <mingo@kernel.org>
Subject: [PATCH 2/2] x86/setup: Use struct_size() for setup_data sizes
Date: Wed, 16 Sep 2026 00:03:24 +0200 [thread overview]
Message-ID: <20260915220324.103216-4-blum@kernel.org> (raw)
In-Reply-To: <20260915220324.103216-3-blum@kernel.org>
Use struct_size(), which provides additional compile-time checks for
structures with flexible array members (e.g., __must_be_array()), to
calculate struct setup_data sizes.
Signed-off-by: Thorsten Blum <blum@kernel.org>
---
arch/x86/kernel/setup.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index cda6adb9f69c..20facddee922 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -19,6 +19,7 @@
#include <linux/iscsi_ibft.h>
#include <linux/kexec_handover.h>
#include <linux/memblock.h>
+#include <linux/overflow.h>
#include <linux/panic_notifier.h>
#include <linux/pci.h>
#include <linux/random.h>
@@ -487,7 +488,7 @@ static void __init parse_setup_data(void)
u32 data_len, data_type;
data = early_memremap(pa_data, sizeof(*data));
- data_len = data->len + sizeof(struct setup_data);
+ data_len = struct_size(data, data, data->len);
data_type = data->type;
pa_next = data->next;
early_memunmap(data, sizeof(*data));
@@ -584,7 +585,7 @@ static void __init memblock_x86_reserve_range_setup_data(void)
len = sizeof(*data);
pa_next = data->next;
- memblock_reserve_kern(pa_data, sizeof(*data) + data->len);
+ memblock_reserve_kern(pa_data, struct_size(data, data, data->len));
if (data->type == SETUP_INDIRECT) {
len += data->len;
prev parent reply other threads:[~2026-09-15 22:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 22:03 [PATCH 1/2] efistub/x86: " Thorsten Blum
2026-09-15 22:03 ` Thorsten Blum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915220324.103216-4-blum@kernel.org \
--to=blum@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=francescopompo2@gmail.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=hpa@zytor.com \
--cc=ilias.apalodimas@linaro.org \
--cc=javierm@redhat.com \
--cc=leitao@debian.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lszubowi@redhat.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=pratyush@kernel.org \
--cc=rppt@kernel.org \
--cc=tglx@kernel.org \
--cc=tzimmermann@suse.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®