From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2C783F3288; Tue, 15 Sep 2026 06:38:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789454299; cv=none; b=YSNflli8Rkti+athzz332V7YoDwGvq9PfeBrAfiMgxkMtfErCswcI7Q2Xr8HKLniBPotip9dv9QwucTelY/ZXH2/5A0VvOgilEcphmbBb4XfjUELdj/XTMI3jEIqMGzm4kVBvDexoBXY6cQO6C464aluOPWFCPG4Y/aNGz/5d0Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789454299; c=relaxed/simple; bh=PgjRTvTAHrwKCDdjNiJHiFkJhHXrCmPKkGWxNpnWORw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ace8rJyWsJZPu6sLdzv8yzoJEvN39c6KJm20dXqWNBxujcZIyQz8YV2gQLrHpqSaJ1Lk6mHCMR5fkb001bMN5CLkdxEfEZb4IvwdoXQGnZ4RE+k+LGEWM769kQ3GIwAYcGaxuWQM3na3s6Y9klg8R1rNPtRTU2wnGae9HjoP6Pk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=YY1bG9dA; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="YY1bG9dA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF37D1F000FF; Tue, 15 Sep 2026 06:38:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789454297; bh=LWPrHZnTBm1zbpSh+cz5mP04/qKKlvCYU336N/nh6J4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=YY1bG9dAry15f+VVA7k2SUjSdp9V9IWbEvIRZ9fsMcEXe3OfekmLKznzCqjvY0e4c MCGgOup4TRxZt39+J3wTo+tmapq0eAigaHhgpBnbCd1idM2G49P4iYOk/K66EkwTZ9 RILLMsV5K2Sw5ZNaagq9lVN6JUj+MFS/gpeu0hFo= Date: Tue, 15 Sep 2026 08:36:23 +0200 From: Greg Kroah-Hartman To: Xiang Mei Cc: co , linux-usb@vger.kernel.org, Valentina Manea , Shuah Khan , Hongren Zheng , Suwan Kim , linux-kernel@vger.kernel.org Subject: Re: [BUG] drivers/usb: NULL pointer dereference in stub_recv_cmd_submit() Message-ID: <2026091546-spoiler-borax-ed6c@gregkh> References: <2026091217-almighty-slouching-de2c@gregkh> <2026091348-sheep-showman-5a20@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Sep 14, 2026 at 03:11:08PM -0700, Xiang Mei wrote: > On Sun, Sep 13, 2026 at 2:19 AM Greg Kroah-Hartman > wrote: > > > > On Sat, Sep 12, 2026 at 11:41:00AM -0700, Xiang Mei wrote: > > > On Fri, Sep 11, 2026 at 10:47 PM Greg Kroah-Hartman > > > wrote: > > > > > > > > On Sat, Sep 12, 2026 at 02:06:13AM +0000, co wrote: > > > > > This is a bug report, not a patch submission. See > > > > > https://bugs.sh/reporting.html > > > > > > > > > > We found a bug reachable in: > > > > > > > > > > path drivers/usb/usbip > > > > > crash NULL pointer dereference in stub_recv_cmd_submit() > > > > > commit 2f1baf1fc892 ("Merge tag 'trace-v7.2-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace") > > > > > > > > > > Config, environment, the sanitizer report and a C reproducer follow. > > > > > > > > > > == Notes =============================================================== > > > > > If you fix this bug, this tag credits the report and lets us > > > > > close it on our side: > > > > > > > > > > Reported-by: co+66c3f58096d0bde8@bugs.sh > > > > > > > > > > Everything in this mail is validated by the reproducer below. > > > > > > > > > > We also hold an unreviewed LLM-generated analysis and candidate > > > > > patch. The same reproducer panics the unpatched kernel and runs > > > > > clean with that patch applied. Use it as a starting point, or ignore > > > > > it and write your own: > > > > > > > > > > patch.diff https://bugs.sh/b/66c3f58096d0bde8/patch.diff > > > > > > > > Please just submit patches like normal, in a format that can be applied, > > > > and do not make us go to random links to attempt to get any information. > > > > That's not how kernel development works at all. > > > > > > > > > > Hi Greg, > > > > > > Sorry about this. We may have misunderstood your earlier reply in this thread: > > > > > > "But sure, posting bug reports is fine, but again, patches are better :)" > > > > > > https://lore.kernel.org/all/2026090139-shortlist-junkie-9bee@gregkh/#t > > > > > > We interpreted this as meaning that sending bug reports without > > > patches was acceptable. We understand your concern with the current > > > format, and we will stop sending reports in this format to you and > > > linux-usb@vger.kernel.org. > > > > > > To make sure we understand correctly and follow the appropriate > > > practice going forward, should we: > > > > > > 1. Send pure bug reports without any LLM-generated analysis or > > > candidate patch, similar to the bug reports syzbot sends to kernel > > > mailing lists; > > > 2. For USB, do not send bug reports and only submit patches in the > > > normal kernel format; or > > > 3. More generally, do not send bug reports to Linux kernel mailing > > > lists and only submit patches in the normal kernel format? > > > > > > Sorry again for the misunderstanding, and thanks for taking the time > > > to clarify this despite your busy schedule. > > > > Think about what _you_ would want to see if you were on the receiving > > end of hundreds of patches a week. Would you want to see a vague email > > with links required to dig stuff out to potentially have to make up a > > fix yourself for an unknown and poorly worded description, or would you > > want a real patch, in mergable format, that describes the problem and > > how it is being resolved? > > > > I think the latter :) > > > > > > > Right now, most developers just ignore syzbot reports, as we are > > drowning in real fixes from developers instead. There's no need for us > > to go research new fixes when we are having a hard time keeping on top > > of the stuff people are sending us that are in mergable state already! > > > > You are right. We understand how overloaded maintainers and reviewers > are right now. > > It's true that bug reports without a mergeable patch still take > maintainers' attention, even when no response is expected. > > We'd still like to make one last request: would it be okay to continue > sending a small number of reports to other lists, with no external > links (just PoC and crash sanitizer log)? We'd take responsibility for > each report and follow up with a patch, even if no one responds. We > just hope that contributors who know the subsystem better might be > interested in helping us check the issues. Why not just send patches to resolve the issues? That's the best thing to work from, especially as you have ways to test if your patch is correct or not. thanks, greg k-h