mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maria Lisina <sekoohaka.sarisan@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	 Lee Jones <lee@kernel.org>
Cc: mfd@lists.linux.dev, linux-kernel@vger.kernel.org,
	 Maria Lisina <sekoohaka.sarisan@gmail.com>
Subject: [PATCH v7 2/4] mfd: intel-lpss: Use plain octal values for file permissions
Date: Wed, 16 Sep 2026 21:23:48 +0500	[thread overview]
Message-ID: <20260916-intel-lpss-debugfs-v7-2-eb51d41f55e0@gmail.com> (raw)
In-Reply-To: <20260916-intel-lpss-debugfs-v7-0-eb51d41f55e0@gmail.com>

S_IRUGO macro is obsoleted and not recommended to use,
therefore replace it with plain octal values.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Maria Lisina <sekoohaka.sarisan@gmail.com>
---
 drivers/mfd/intel-lpss.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
index b6958e99cf54d3c8eeca1ba38055a9389678f6c3..190de88d146aae9418566adf36a47d11afa90b2a 100644
--- a/drivers/mfd/intel-lpss.c
+++ b/drivers/mfd/intel-lpss.c
@@ -151,9 +151,9 @@ static void intel_lpss_debugfs_add(struct intel_lpss *lpss)
 	/* Cache the values into lpss structure */
 	intel_lpss_cache_ltr(lpss);
 
-	debugfs_create_x32("capabilities", S_IRUGO, dir, &lpss->caps);
-	debugfs_create_x32("active_ltr", S_IRUGO, dir, &lpss->active_ltr);
-	debugfs_create_x32("idle_ltr", S_IRUGO, dir, &lpss->idle_ltr);
+	debugfs_create_x32("capabilities", 0444, dir, &lpss->caps);
+	debugfs_create_x32("active_ltr", 0444, dir, &lpss->active_ltr);
+	debugfs_create_x32("idle_ltr", 0444, dir, &lpss->idle_ltr);
 
 	lpss->debugfs = dir;
 }

-- 
2.47.3


  parent reply	other threads:[~2026-09-16 16:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16 16:23 [PATCH v7 0/4] mfd: intel-lpss: Clean up and modernize DebugFS usage Maria Lisina
2026-09-16 16:23 ` [PATCH v7 1/4] mfd: intel-lpss: Remove redundant DebugFS error check Maria Lisina
2026-09-16 16:23 ` Maria Lisina [this message]
2026-09-16 16:23 ` [PATCH v7 3/4] mfd: intel-lpss: Remove extra DebugFS dentry Maria Lisina
2026-09-16 16:23 ` [PATCH v7 4/4] mfd: intel-lpss: Switch to debugfs_remove() Maria Lisina
2026-09-17  5:34 ` [PATCH v7 0/4] mfd: intel-lpss: Clean up and modernize DebugFS usage Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260916-intel-lpss-debugfs-v7-2-eb51d41f55e0@gmail.com \
    --to=sekoohaka.sarisan@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mfd@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®