From: phucduc.bui@gmail.com
To: Mark Brown <broonie@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Cyril Chao <Cyril.Chao@mediatek.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Dan Carpenter <error27@gmail.com>,
cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH v3 00/12] ASoC: mediatek: mt8189: Improve error handling
Date: Wed, 16 Sep 2026 12:00:07 +0700 [thread overview]
Message-ID: <20260916050020.14575-1-phucduc.bui@gmail.com> (raw)
From: bui duc phuc <phucduc.bui@gmail.com>
Hi all,
This series addresses part of the error handling in the MT8189 AFE driver.
It propagates errors from clock operations and runtime resume, validates
clock parameters, and removes redundant error messages.
In v2, there was discussion about checking the return value of
regmap_update_bits(). While opinions differed, the existing driver already
checks it in mt8189_afe_enable_top_cg(), which is used by
mt8189_apll1_enable() and mt8189_apll2_enable() touched by this series.
Therefore, I keep these checks and add the corresponding error paths for
consistency.
Compile-tested only.
Link v1 :
https://lore.kernel.org/all/20260910125742.150902-1-phucduc.bui@gmail.com/
Link v2:
https://lore.kernel.org/all/20260914072842.24420-1-phucduc.bui@gmail.com/
Changes in v2:
- Update the names of the goto labels.
- Check for zero frequency since freq is unsigned.
Changes in v3:
- Add Angelo's Reviewed-by tag.
- Restore the existing afe->regmap checks,
making the separate patch for missing regmap unnecessary.
- Do not pre-initialize ret; set ret = 0 in the default case throughout
the series.
Best regards,
Phuc
bui duc phuc (12):
ASoC: mediatek: mt8189: Propagate APLL enable errors
ASoC: mediatek: mt8189: Propagate MCK enable errors
ASoC: mediatek: mt8189: Validate MCK ID
ASoC: mediatek: mt8189: Propagate reg_rw clock errors
ASoC: mediatek: mt8189: Use dev_err_probe() for clock errors
ASoC: mediatek: mt8189: Propagate runtime resume errors
ASoC: mediatek: mt8189: Remove redundant error message
ASoC: mediatek: mt8189: Propagate APLL errors
ASoC: mediatek: mt8189: Propagate MCLK errors
ASoC: mediatek: mt8189: Validate sysclk frequency
ASoC: mediatek: mt8189: Propagate TDM clock errors
ASoC: mediatek: mt8189: Validate TDM MCLK frequency
sound/soc/mediatek/mt8189/mt8189-afe-clk.c | 134 +++++++++++++++------
sound/soc/mediatek/mt8189/mt8189-afe-pcm.c | 45 ++++---
sound/soc/mediatek/mt8189/mt8189-dai-i2s.c | 18 ++-
sound/soc/mediatek/mt8189/mt8189-dai-tdm.c | 19 ++-
4 files changed, 154 insertions(+), 62 deletions(-)
--
2.43.0
next reply other threads:[~2026-09-16 5:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 5:00 phucduc.bui [this message]
2026-09-16 5:00 ` [PATCH v3 01/12] ASoC: mediatek: mt8189: Propagate APLL enable errors phucduc.bui
2026-09-16 5:00 ` [PATCH v3 02/12] ASoC: mediatek: mt8189: Propagate MCK " phucduc.bui
2026-09-16 5:00 ` [PATCH v3 03/12] ASoC: mediatek: mt8189: Validate MCK ID phucduc.bui
2026-09-16 5:00 ` [PATCH v3 04/12] ASoC: mediatek: mt8189: Propagate reg_rw clock errors phucduc.bui
2026-09-16 5:00 ` [PATCH v3 05/12] ASoC: mediatek: mt8189: Use dev_err_probe() for " phucduc.bui
2026-09-16 5:00 ` [PATCH v3 06/12] ASoC: mediatek: mt8189: Propagate runtime resume errors phucduc.bui
2026-09-16 5:00 ` [PATCH v3 07/12] ASoC: mediatek: mt8189: Remove redundant error message phucduc.bui
2026-09-16 5:00 ` [PATCH v3 08/12] ASoC: mediatek: mt8189: Propagate APLL errors phucduc.bui
2026-09-16 5:00 ` [PATCH v3 09/12] ASoC: mediatek: mt8189: Propagate MCLK errors phucduc.bui
2026-09-16 5:00 ` [PATCH v3 10/12] ASoC: mediatek: mt8189: Validate sysclk frequency phucduc.bui
2026-09-16 5:00 ` [PATCH v3 11/12] ASoC: mediatek: mt8189: Propagate TDM clock errors phucduc.bui
2026-09-16 5:00 ` [PATCH v3 12/12] ASoC: mediatek: mt8189: Validate TDM MCLK frequency phucduc.bui
2026-09-16 10:19 ` [PATCH v3 00/12] ASoC: mediatek: mt8189: Improve error handling AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916050020.14575-1-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=Cyril.Chao@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=cassiogabrielcontato@gmail.com \
--cc=cezary.rojewski@intel.com \
--cc=error27@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®