From: Leo Yan <leo.yan@arm.com>
To: Yuanfang Zhang <yuanfang.zhang@oss.qualcomm.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@arm.com>,
James Clark <james.clark@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
kernel@oss.qualcomm.com, coresight@lists.linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH] coresight: handle runtime PM resume failures
Date: Wed, 16 Sep 2026 11:30:42 +0100 [thread overview]
Message-ID: <20260916103042.GH200420@e132581.arm.com> (raw)
In-Reply-To: <20260911-b4-coresight-runtime-pm-failures-v1-1-acdf49756e11@qti.qualcomm.com>
On Fri, Sep 11, 2026 at 03:28:52AM -0700, Yuanfang Zhang wrote:
[...]
> Replace the remaining pm_runtime_get_sync() calls with
> pm_runtime_resume_and_get(), which restores the runtime PM usage count
> when resume fails. Abort before accessing hardware and propagate the
> error to the caller.
The change makes sense to me.
> In coresight_get_ref(), unwind the module and device references.
Sashiko reported a pre-existing issue where the callers don't handle
errors returned by coresight_get_ref() [1]. In this case, we need to
remove nodes from path->path_list and release them. However, this
should be done in a separate patch.
[1] https://sashiko.dev/#/patchset/20260911-b4-coresight-runtime-pm-failures-v1-1-acdf49756e11%40qti.qualcomm.com
> Signed-off-by: Yuanfang Zhang <yuanfang.zhang@oss.qualcomm.com>
Thanks for the fix! Feel free to add:
Reviewed-by: Leo Yan <leo.yan@arm.com>
prev parent reply other threads:[~2026-09-16 10:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 10:28 Yuanfang Zhang
2026-09-11 13:11 ` Ulf Hansson
2026-09-16 10:30 ` Leo Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916103042.GH200420@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@linaro.org \
--cc=kernel@oss.qualcomm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mike.leach@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=yuanfang.zhang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®