From: Vincent Donnefort <vdonnefort@google.com>
To: rostedt@goodmis.org, mhiramat@kernel.org,
linux-trace-kernel@vger.kernel.org
Cc: mathieu.desnoyers@efficios.com, kernel-team@android.com,
linux-kernel@vger.kernel.org, devnexen@gmail.com,
Vincent Donnefort <vdonnefort@google.com>
Subject: [PATCH v2 0/2] ring-buffer: Clean up resize_disabled checks
Date: Wed, 16 Sep 2026 16:28:11 +0100 [thread overview]
Message-ID: <20260916152813.105082-1-vdonnefort@google.com> (raw)
ring_buffer_subbuf_order_set() checks for resize_disabled twice under
the same buffer->mutex hold. Moreover, this check duplicates the logic
in ring_buffer_resize(). Create a common helper rb_resize_disabled() to
factor out this code and drop redundant checks.
Additionally, remove the unnecessary cpumask_test_cpu() in
ring_buffer_subbuf_order_set() as for_each_buffer_cpu() already
iterates over buffer->cpumask.
v2:
- Split cpumask_test_cpu() cleanup into its own patch (Steven)
- Remove another unnecessary cpumask_test_cpu() (David)
v1: https://lore.kernel.org/all/20260914175907.1027349-1-vdonnefort@google.com/
Vincent Donnefort (2):
ring-buffer: Clean up resize_disabled checks
ring-buffer: Remove unnecessary cpumask_test_cpu
kernel/trace/ring_buffer.c | 70 +++++++++++++++-----------------------
1 file changed, 28 insertions(+), 42 deletions(-)
base-commit: fd73f4a6659897191fa0d40695fe370925dd3780
--
2.55.0.1082.g2b9226bbc0-goog
next reply other threads:[~2026-09-16 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 15:28 Vincent Donnefort [this message]
2026-09-16 15:28 ` [PATCH v2 1/2] " Vincent Donnefort
2026-09-16 15:28 ` [PATCH v2 2/2] ring-buffer: Remove unnecessary cpumask_test_cpu Vincent Donnefort
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916152813.105082-1-vdonnefort@google.com \
--to=vdonnefort@google.com \
--cc=devnexen@gmail.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®