mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luis Henriques <luis@igalia.com>
To: Miklos Szeredi <miklos@szeredi.hu>,
	Amir Goldstein <amir73il@gmail.com>,
	Chen Linxuan <me@black-desk.cn>, Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>
Cc: fuse-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org,
	Matt Harvey <mharvey@jumptrading.com>,
	kernel-dev@igalia.com, Luis Henriques <luis@igalia.com>
Subject: [RFC PATCH v4 0/8] fuse: caches documentation and testing
Date: Wed, 16 Sep 2026 16:56:21 +0100	[thread overview]
Message-ID: <20260916155629.32421-1-luis@igalia.com> (raw)

Hi!

I'm sending v4 of this patchset.  It tries to fix the problems identified
in the previous version, both by Amir's review and by the sashiko code
review system.

Note however that there were issues identified by the code review system
in the last patch (the readdir kselftest) which I decided not to
implement.  Those issues are real *if* the file system is used outside the
scope of these tests.  A more robust solution could have been based the
libfuse examples, but I thought that wouldn't be needed and I decided to
use a more simplistic approach.  (Maybe that was a wrong decision.)

Finally, here's the (main!) changes since v3:

- Document:
  - Simplified text by removing a lot of details; also used Amir's suggested
    text
  - Added document to index.rst and fixed some typos (sashiko review
    system).
- Added extra struct fuse_common_ctx to reduce test boilerplate even more (Amir)
- Fixed several {} mismatches, and reshaped some error handling code (Amir)
- symlink test:
  - fixed ->lookup() issue previously identified by sashiko, and that I
    had missed (Amir)
  - fix wrong login in fs_lookup() (sashiko)
- readdir test:
  - use constant value for mtime (Amir)
  - Removed redundant condition in fs_lookup() (sashiko)
- acl test:
  - use constant uid/gid for ->lookup() and ->getattr() (sashiko)
  - fix possible memcpy undef behaviour with a NULL source (sashiko)

Luis Henriques (8):
  Documentation: fuse: add document on caches being used by FUSE
  selftests/fuse: convert fusectl test to fuse3
  selftests/fuse: check that fusectlfs is mounted
  selftests/fuse: factor-out test fixture setup/teardown
  selftests/fuse: use dynamically allocated memory to store ACLs
  selftests/fuse: add some extra ACL caching tests
  selftests/fuse: add fuse symlink caching test
  selftests/fuse: add fuse readdir caching test

 .../filesystems/fuse/fuse-caches.rst          | 148 +++++++++
 Documentation/filesystems/fuse/index.rst      |   1 +
 .../selftests/filesystems/fuse/.gitignore     |   3 +
 .../selftests/filesystems/fuse/Makefile       |  28 +-
 .../filesystems/fuse/fuse_acl_cache_test.c    | 304 ++++++++++++++----
 .../selftests/filesystems/fuse/fuse_common.c  |  58 ++++
 .../selftests/filesystems/fuse/fuse_common.h  |  31 ++
 .../selftests/filesystems/fuse/fuse_mnt.c     |  17 +-
 .../fuse/fuse_readdir_cache_test.c            | 274 ++++++++++++++++
 .../fuse/fuse_symlink_cache_test.c            | 163 ++++++++++
 .../selftests/filesystems/fuse/fusectl_test.c |   9 +-
 11 files changed, 953 insertions(+), 83 deletions(-)
 create mode 100644 Documentation/filesystems/fuse/fuse-caches.rst
 create mode 100644 tools/testing/selftests/filesystems/fuse/fuse_common.c
 create mode 100644 tools/testing/selftests/filesystems/fuse/fuse_common.h
 create mode 100644 tools/testing/selftests/filesystems/fuse/fuse_readdir_cache_test.c
 create mode 100644 tools/testing/selftests/filesystems/fuse/fuse_symlink_cache_test.c


             reply	other threads:[~2026-09-16 15:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16 15:56 Luis Henriques [this message]
2026-09-16 15:56 ` [RFC PATCH v4 1/8] Documentation: fuse: add document on caches being used by FUSE Luis Henriques
2026-09-16 15:56 ` [RFC PATCH v4 2/8] selftests/fuse: convert fusectl test to fuse3 Luis Henriques
2026-09-16 15:56 ` [RFC PATCH v4 3/8] selftests/fuse: check that fusectlfs is mounted Luis Henriques
2026-09-16 15:56 ` [RFC PATCH v4 4/8] selftests/fuse: factor-out test fixture setup/teardown Luis Henriques
2026-09-16 15:56 ` [RFC PATCH v4 5/8] selftests/fuse: use dynamically allocated memory to store ACLs Luis Henriques
2026-09-16 15:56 ` [RFC PATCH v4 6/8] selftests/fuse: add some extra ACL caching tests Luis Henriques
2026-09-16 15:56 ` [RFC PATCH v4 7/8] selftests/fuse: add fuse symlink caching test Luis Henriques
2026-09-16 15:56 ` [RFC PATCH v4 8/8] selftests/fuse: add fuse readdir " Luis Henriques

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260916155629.32421-1-luis@igalia.com \
    --to=luis@igalia.com \
    --cc=amir73il@gmail.com \
    --cc=corbet@lwn.net \
    --cc=fuse-devel@lists.linux.dev \
    --cc=kernel-dev@igalia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=me@black-desk.cn \
    --cc=mharvey@jumptrading.com \
    --cc=miklos@szeredi.hu \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®