From: Wentao Liang <vulab@iscas.ac.cn>
To: andy@kernel.org
Cc: dan@dlrobertson.com, dlechner@baylibre.com,
jagathjog1996@gmail.com, jic23@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
nuno.sa@analog.com, Wentao Liang <vulab@iscas.ac.cn>,
stable@vger.kernel.org
Subject: [PATCH] iio: accel: bma400: Fix trigger reference leak in bma400_probe()
Date: Wed, 16 Sep 2026 16:08:25 +0000 [thread overview]
Message-ID: <20260916160825.2082355-1-vulab@iscas.ac.cn> (raw)
Move indio_dev->trig = iio_trigger_get(data->trig) after the
devm_request_threaded_irq() and triggered buffer setup succeed. If
either fails before INDIO_BUFFER_TRIGGERED is set, the IIO core does
not put the trigger reference in iio_dev_release(), leaking it.
Fixes: ffe0ab6a9698 ("iio: accel: bma400: Add triggered buffer support")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
drivers/iio/accel/bma400_core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/accel/bma400_core.c b/drivers/iio/accel/bma400_core.c
index 05f72707f830..a5889b67585e 100644
--- a/drivers/iio/accel/bma400_core.c
+++ b/drivers/iio/accel/bma400_core.c
@@ -1783,7 +1783,6 @@ int bma400_probe(struct device *dev, struct regmap *regmap, int irq,
return dev_err_probe(data->dev, ret,
"iio trigger register fail\n");
- indio_dev->trig = iio_trigger_get(data->trig);
ret = devm_request_threaded_irq(dev, irq, NULL,
&bma400_interrupt,
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
@@ -1799,6 +1798,9 @@ int bma400_probe(struct device *dev, struct regmap *regmap, int irq,
return dev_err_probe(data->dev, ret,
"iio triggered buffer setup failed\n");
+ if (irq > 0)
+ indio_dev->trig = iio_trigger_get(data->trig);
+
return devm_iio_device_register(dev, indio_dev);
}
EXPORT_SYMBOL_NS(bma400_probe, "IIO_BMA400");
--
2.34.1
next reply other threads:[~2026-09-16 16:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 16:08 Wentao Liang [this message]
2026-09-17 0:17 ` Jonathan Cameron
2026-09-17 0:21 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916160825.2082355-1-vulab@iscas.ac.cn \
--to=vulab@iscas.ac.cn \
--cc=andy@kernel.org \
--cc=dan@dlrobertson.com \
--cc=dlechner@baylibre.com \
--cc=jagathjog1996@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®