From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F09514D6C3D for ; Wed, 16 Sep 2026 16:11:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789575071; cv=none; b=S0egiOZ6TKoo6XZbJjpXLHxQTUiM+PIZMBmR8O3ww00jxolifwZ6y9Pi0Dce76Sk/4kAf739gKZWKEJbEoXqw4VxVhrqN2xybENaV1X5FBW2jdQWvjA9gviSlGMutx2lLd4sW3gPNkvGol4f2F+bUnPCfCFb5gKItPvjW2pgkfI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789575071; c=relaxed/simple; bh=rgu65xROSdjmMwwKg8YIQlif7PhAj3pgiF80j2ZjCnk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CaOXZqI/crmIzFae+aRTM6RBNRlTN3aGRwKmO52Ho1nOK/udt/wl7/ZumznS9aTnr3RnTic/NLIhuAA5K+bc4WNwAKk6R1OQI9UAty68v81Dyq2CTjglf0elf/061sC/4mco971XdaJVA0K8eEGBZ973HLX5hjmimbeEslkiyRU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E315w2u3; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E315w2u3" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49c5a927a1fso725655e9.2 for ; Wed, 16 Sep 2026 09:11:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789575068; x=1790179868; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rgu65xROSdjmMwwKg8YIQlif7PhAj3pgiF80j2ZjCnk=; b=E315w2u3x7mEyLAdk8Xpk+oiZOXezh9l3hJV+Ay/1r4Br2eBFs7nfwF8czMWwSiypf ez1+f3ajj3o/6EakWSXBY+e1WM8F0fS/CKY4t/lbcLcuHc+om/iDD4hFEdwsmValDaQY /pMS25VZBxv+pNz/PTp1Yw7jFHDtdRGT63hNDKDvwYpkbxm7Aoa9LG1VS+V14b56xhVX FZ3LcvP/i1mYKxp8gjL5gTaGSKFVMzeO04bALSfBHFrfFIm/M27BLtBXCrqgJMPCdTMH a2elfRM+4M4cqoGiK6Gc19+7nXaA+B5pW2u5dSjLDZvWf6vjewdbuR4uexKKtjCvKPhA KdKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789575068; x=1790179868; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=rgu65xROSdjmMwwKg8YIQlif7PhAj3pgiF80j2ZjCnk=; b=sWV5pS9ndacldscAUdoxRDJofIFS+SAgtZQ51d2pCiE5d75XKx4dkSNf4oVCdjaTTp lUNdMgR4s3ozcrtpsLtUh3zvrQ51DIknofxPqMoO5WuR2I70an3VZJQIYLxq/M+ragPX YHEWj+DdunwPwivVTniRS1ohxYVP2vkE1WXClmznfO4O6lYNyvCEd8D04N112JKmaiLJ HvW/wZO376Tcuhy8oCs1cVizR+7ySEtHWoz3eEqPVKYQcc1bUSDRmIdZTf+RQytjqd9c XsAknvCuQ56BwMEXmaEab2dl3egV/w5Pj6gRTOb0mcAJEyr0lI1moKH2lZY8eyGVDgbu p15w== X-Forwarded-Encrypted: i=1; AKwUvBzTzh3MEi88fhI5ZaVVFr4CN/Nb73h8eQ3J9SbQ3ggHXkfp0k2aqTWEOSt0CEGd83/Qok2fH9GhQBRm2U0=@vger.kernel.org X-Gm-Message-State: AFuF++mkGT5FtC4+m3LjPfjp9+negSAqfnfMiCVLKrV5Rj2DHWEzOVGS O9sNtoPhx675DcnYjP7grZsoWsGF6RYQ3ytR0iHXvtTu1ex83+b1XjUt X-Gm-Gg: AYBFou0OOnXYvCHej9M3S+JrMI+PWluAkqlm8E0X52e+r2twKKms/e6egish2MDzwtq /1LjbQTzkqbXPDfq0TMavn1aw65nBiW6Q7503LP71YJK7NDeiq6LLhUOBw30cj00BQKtskHFbOj aiDio41a+3HkOGnr5hmL0NxgCVz/QE1ov52gV8D/YKn4dN1jyC+hseeV05Zym8V49g6fII/CJES 4XsBxvC4ltcOOnj1AYd+fcvnbG2Yp4BG6PhmMrPLIurFH8pDmQcMsM/RkdiTujM24VRIapHToFW axZ+lLTWa6TWbEWjY2LIGRRVZ+d1AbwIbeis/zPn1+FGn8h1zNVMp4p+iHShzqJgf95rQwJPRRt UhB6OG/yCDSOmGioATQcWKZLCxr3jHzywUOHWylQgxqLU0G4GwKJeurgQWXwSYS/gAVzyJgcn43 EGSUXgIpIMwfyr1+W+Hyr70TAYvJgtFPYU2xszt4wzt/zbpKsTHerBZ++9Y1aXyETpPM78vFhOK Ino9u/17rweVs3JyI2BEJl4GHyYwlMfgmpCOzwmL14bC3QQbhjejISbDQSAe3zT/bToyM7OgVVt maqkO9CabUSi X-Received: by 2002:a05:600c:5489:b0:49c:f9b8:bae0 with SMTP id 5b1f17b1804b1-49eb732b2c8mr38610325e9.2.1789575067984; Wed, 16 Sep 2026 09:11:07 -0700 (PDT) Received: from OrangePi5-Plus.BB-HOME (20014C4E1B8E02002D5AB124699B1F76.dsl.pool.telekom.hu. [2001:4c4e:1b8e:200:2d5a:b124:699b:1f76]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fbd24774esm2002115e9.10.2026.09.16.09.11.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 09:11:07 -0700 (PDT) From: Igor Paunovic To: Wentao Liang Cc: Igor Paunovic , tomeu@tomeuvizoso.net, ogabbay@kernel.org, jeff.hugo@oss.qualcomm.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 2/4] accel/rocket: fix runtime PM refcount leak in rocket_job_run() Date: Wed, 16 Sep 2026 18:10:53 +0200 Message-ID: <20260916161053.11926-1-royalnet026@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260915041047.1724928-1-vulab@iscas.ac.cn> References: <20260915041047.1724928-1-vulab@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Wentao, This looks already fixed in mainline by commit 9b2dedadf6a9 ("accel/rocket: Fix error path handling in rocket_job_run()"), which is in v7.3-rc1, and the same code is in the 7.2.y and 6.18.y stable trees. There, rocket_job_run() already uses pm_runtime_resume_and_get() and drops the reference with pm_runtime_put() when iommu_attach_group() fails. Your diff is against the older rocket_job.c (index ac51bff39833, the v7.1/v7.2 file), so it no longer applies to current mainline. I checked this with the help of an LLM assistant, against the git.kernel.org trees. Igor