From: Wentao Liang <vulab@iscas.ac.cn>
To: andy@kernel.org
Cc: dlechner@baylibre.com, jic23@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
nuno.sa@analog.com, tomasz.duszynski@octakon.com,
Wentao Liang <vulab@iscas.ac.cn>,
stable@vger.kernel.org
Subject: [PATCH] iio: chemical: scd30: Fix trigger reference leak in scd30_setup_trigger()
Date: Wed, 16 Sep 2026 16:28:17 +0000 [thread overview]
Message-ID: <20260916162817.2083674-1-vulab@iscas.ac.cn> (raw)
The reference taken with iio_trigger_get() is only dropped by
iio_dev_release() when INDIO_BUFFER_TRIGGERED is set. Failure of
devm_request_threaded_irq() in scd30_setup_trigger(), or of triggered
buffer setup in scd30_probe(), returns before that mode is set and
leaks the reference acquired for indio_dev->trig. Take the reference
after the IRQ request succeeds and set up the trigger after the
buffer so that only failures with the mode already set follow the
iio_trigger_get().
Fixes: 64b3d8b1b0f5 ("iio: chemical: scd30: add core driver")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
drivers/iio/chemical/scd30_core.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/chemical/scd30_core.c b/drivers/iio/chemical/scd30_core.c
index a665fcb78806..dc56291e1892 100644
--- a/drivers/iio/chemical/scd30_core.c
+++ b/drivers/iio/chemical/scd30_core.c
@@ -644,8 +644,6 @@ static int scd30_setup_trigger(struct iio_dev *indio_dev)
if (ret)
return ret;
- indio_dev->trig = iio_trigger_get(trig);
-
/*
* Interrupt is enabled just before taking a fresh measurement
* and disabled afterwards. This means we need to ensure it is not
@@ -659,6 +657,8 @@ static int scd30_setup_trigger(struct iio_dev *indio_dev)
if (ret)
return dev_err_probe(dev, ret, "failed to request irq\n");
+ indio_dev->trig = iio_trigger_get(trig);
+
return 0;
}
@@ -710,16 +710,16 @@ int scd30_probe(struct device *dev, int irq, const char *name, void *priv,
if (ret)
return dev_err_probe(dev, ret, "failed to reset device\n");
+ ret = devm_iio_triggered_buffer_setup(dev, indio_dev, NULL, scd30_trigger_handler, NULL);
+ if (ret)
+ return ret;
+
if (state->irq > 0) {
ret = scd30_setup_trigger(indio_dev);
if (ret)
return dev_err_probe(dev, ret, "failed to setup trigger\n");
}
- ret = devm_iio_triggered_buffer_setup(dev, indio_dev, NULL, scd30_trigger_handler, NULL);
- if (ret)
- return ret;
-
ret = scd30_command_read(state, CMD_FW_VERSION, &val);
if (ret)
return dev_err_probe(dev, ret, "failed to read firmware version\n");
--
2.34.1
next reply other threads:[~2026-09-16 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 16:28 Wentao Liang [this message]
2026-09-17 0:30 ` Jonathan Cameron
2026-11-06 11:38 ` Wentao Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916162817.2083674-1-vulab@iscas.ac.cn \
--to=vulab@iscas.ac.cn \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=stable@vger.kernel.org \
--cc=tomasz.duszynski@octakon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®