From: Rob Herring <robh@kernel.org>
To: Lucas Tanure <tanure@linux.com>
Cc: Ulf Hansson <ulfh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Chuan Liu <chuan.liu@amlogic.com>, Jian Hu <jian.hu@amlogic.com>,
Ronald Claveau <linux-kernel-dev@aliel.fr>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: mmc: amlogic,meson-gx-mmc: document the T7 pipeline clock
Date: Wed, 16 Sep 2026 15:37:01 -0500 [thread overview]
Message-ID: <20260916203701.GA1463751-robh@kernel.org> (raw)
In-Reply-To: <20260905153234.133217-2-tanure@linux.com>
On Sat, Sep 05, 2026 at 04:32:31PM +0100, Lucas Tanure wrote:
> The SD/eMMC controllers of the T7 SoC are physically far from the
> NIC_MATRIX bus fabric, so the hardware design inserts a pipeline stage
> in the middle of the bus path to help timing closure. This stage is fed
> by its own gate clock and, when that clock is disabled, a controller
> that starts a DMA transfer can never complete it.
>
> Allow a fourth clock entry, named "pipeline", and require it for the
> amlogic,t7-mmc compatible. The other controllers of this family keep
> the existing three clocks.
Did the SD controller not work without this clock? If it did, then this
is an ABI break which is evident by the current warning in linux-next.
Rob
next prev parent reply other threads:[~2026-09-16 20:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-05 15:32 [PATCH v2 0/4] amlogic: t7: give the MMC bus pipeline clock real consumers Lucas Tanure
2026-09-05 15:32 ` [PATCH v2 1/4] dt-bindings: mmc: amlogic,meson-gx-mmc: document the T7 pipeline clock Lucas Tanure
2026-09-07 17:34 ` Conor Dooley
2026-09-16 20:37 ` Rob Herring [this message]
2026-09-05 15:32 ` [PATCH v2 2/4] mmc: meson-gx: enable the bus pipeline clock on T7 Lucas Tanure
2026-09-10 7:13 ` Neil Armstrong
2026-09-05 15:32 ` [PATCH v2 3/4] arm64: dts: amlogic: t7: add the pipeline clock to the MMC controllers Lucas Tanure
2026-09-10 7:13 ` Neil Armstrong
2026-09-05 15:32 ` [PATCH v2 4/4] clk: meson: t7: don't mark sys_ampipe_nand as critical Lucas Tanure
2026-09-10 7:13 ` Neil Armstrong
2026-09-12 0:08 ` Brian Masney
2026-09-12 7:50 ` Lucas Tanure
2026-09-12 15:50 ` Jerome Brunet
2026-09-11 15:40 ` [PATCH v2 0/4] amlogic: t7: give the MMC bus pipeline clock real consumers Ulf Hansson
2026-09-15 15:55 ` Lucas Tanure
2026-09-16 9:50 ` Neil Armstrong
2026-09-16 10:04 ` (subset) " Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916203701.GA1463751-robh@kernel.org \
--to=robh@kernel.org \
--cc=bmasney+clk@redhat.com \
--cc=chuan.liu@amlogic.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jian.hu@amlogic.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel-dev@aliel.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=sboyd@kernel.org \
--cc=tanure@linux.com \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®