From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f12.google.com (mail-wr2-f12.google.com [74.125.225.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3814E4E1C8B for ; Wed, 16 Sep 2026 20:53:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789592050; cv=none; b=L3SFDTA/ckzT1IWKkdBbSYEEFdRr+vmqJ99m66ZI3grZOmulGYa8H1BE5SniL7SVKZUxd1Xs4fAYhPK8FW1rIbVHFotzLSsDkhLujLoWLR6o5YoQjsZ6BMA1CLvlDl5UQW1rJNXAVemQxITyMPJsVcVgE+notAFXhv/vSA3nt0g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789592050; c=relaxed/simple; bh=pI6wT2AVh5yAvV66BledWhgr6biNtXsQP6dV0Cf2EOo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Oqh2bIglbEbcYdLccrXXju8ZyP6gDLZdQoKWVQGhmtOvvi1CW5dQqC7xwtOnT9xJ6Gro5b2Ns3jYtMbqlTQ48Q9g404BH5m5ERCKN9DUPj0P3OHigbEGd+AfWmukKZJwH8xBxvyHKA90evxN1YPDxBEQ2bwB0sHUUawTdR5ZtaI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qWCLFauk; arc=none smtp.client-ip=74.125.225.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qWCLFauk" Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-482f633ece3so108793f8f.3 for ; Wed, 16 Sep 2026 13:53:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789592013; x=1790196813; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vQCQCsXRyOMK2lxbcg+U/XVY1PZxvpDAiiCFQ6+e0aY=; b=qWCLFauku+QrSmjWXbodOKbkW7XrPKG5pYD61LeUZK9V8LLDFhCYpaboZO3hnIbCw9 WdqPMlnpEC4v6PsRBm+MDwlmde7K4rpki7vmjKsW27IxNaL+RkSpplZeCemt3Kr9PiyA QYoXDLpgutSonA/1rdhMonvWl1XsZY1iZsd2Bt0bARNULBonTUEG4MoQTDosNkqKYnNS jFaDnUraHYWQ71nqUa/ZM2+QvspnLec37/qfmcE2lGP9j4SkxiHqHJaemRYwstJ7fdM5 3kE9IFl1IK8qETf6cWrAqv/5zBexGW5O/MLOXpbwbKMWr5GEiagpX4BupcO929luz7cA lw5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789592013; x=1790196813; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=vQCQCsXRyOMK2lxbcg+U/XVY1PZxvpDAiiCFQ6+e0aY=; b=DB1FOJo9sQmIJTwE9G4Z9zhHCGvkGP+BAy0eUV+cBY0qJXGdzf6j3E/rbvbU4KeGik 9V3q2DNCveA99DKNqKKOezy7X0pT/EOmfivTnafPlvV+ZKMxbppNzrOVcEjnnXde6N1h FGQqJggpauzCK54pYvIocp2tsxSIpX0UCzoVaBoh2UIZNe4UAMVJ57y/xGnNpMoloxX2 fOIa4lvA2O1pDafdizWB7I1Yr32RpfLSMNPiPZfSLvBGQBaYsErD6pzhe/33L6bU4qj3 q6//3MEIQbYkrz+u23n8teE8MgsgRhSgsEGbp14T+KspNCzNPyUcuz7LJga3o3Q20wwm M0lg== X-Forwarded-Encrypted: i=1; AKwUvBxgzpAO644uw0D7oKbLwdePgQM1DgDNcgqISfthr/utdtvHGpfbd/eKxorfLHf1xWCsoMcoh62kD2ljPnU=@vger.kernel.org X-Gm-Message-State: AFuF++mNJps2IxRZLaFlBbPH/zruvJoh77m8BwwmovT+Q957xbL1x5mf qhL4JkSHJBlTFQ/QQRVFPB3fN2WHpY+QHgANQsm28r//Yflz30qLTgFZ X-Gm-Gg: AYBFou1U2WY10nAE1Ep8k8a0mRq+enQOvrV3+GXtd6FfThbk+BLHYfoEFZuTB/4Sm1I vepLapwdGa3m0KkMEBBfx1BFcE0hZWy9B5yJ03w0w8BZrukwGKUDLhAntIFDcT3euM49w2sEeBz p9+4LOlawByu5EdYVzhFzQv54L/rrCyix0emHrqH9ob0OIvUQJuKCQRz9eZw8GdzQ1/5zkq5ZjA faKSTmjP04c3WU1l71/WpS/P/IOViOoaifvP/deYFHSFu80qJ6nApSfJn/7qY1YiNytM+/9Ymhv lELDsP7N49EL/USB1EGQYSODXYGNPGjoBVMAWyaVm8NR4a3XBYbemhZf6JOu5oa0Ht7f45zlDqL JL/G2VfKzl4sfyLl7IvJyr8x0QXHJ/TgoJwdOlyH+lDaPNImXRi3ro8atYiwtWELZblRWSY4DnL RUpbMCldaqYmxcdXyLNHHtrHtcdWVGCKR8ibJo6foA3qOXw67DyP9jp/xX2apqkf0xkKwu6Q== X-Received: by 2002:a05:6000:1a8b:b0:486:fed8:8710 with SMTP id ffacd0b85a97d-4870d16b67fmr5230115f8f.38.1789592013464; Wed, 16 Sep 2026 13:53:33 -0700 (PDT) Received: from antoniarch ([78.210.41.3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4870bef7678sm11086166f8f.2.2026.09.16.13.53.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 13:53:33 -0700 (PDT) From: Antoni Pokusinski To: alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Antoni Pokusinski Subject: [PATCH v7 4/9] rtc: abx80x: properly handle shared IRQs Date: Wed, 16 Sep 2026 22:51:33 +0200 Message-ID: <20260916205138.16771-5-apokusinski01@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260916205138.16771-1-apokusinski01@gmail.com> References: <20260916205138.16771-1-apokusinski01@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The abx80x RTC driver registers its interrupt handler with IRQF_SHARED, but the handler always returned IRQ_HANDLED and cleared the status register even when no interrupt source from the RTC was active. This could cause the driver to claim interrupts belonging to other devices sharing the same IRQ line and could also clear unrelated status bits in the RTC status register. Only handle the interrupt when the alarm or watchdog flags are set, and clear only those interrupt status bits that were handled. Return IRQ_NONE when the interrupt was not generated by the RTC. Fixes: 718a820a303c ("rtc: abx80x: add alarm support") Signed-off-by: Antoni Pokusinski --- drivers/rtc/rtc-abx80x.c | 52 ++++++++++++++++++++++++++++++++++++++-- 1 file changed, 50 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-abx80x.c b/drivers/rtc/rtc-abx80x.c index 44de234efecf..2fd0079b7c51 100644 --- a/drivers/rtc/rtc-abx80x.c +++ b/drivers/rtc/rtc-abx80x.c @@ -51,12 +51,18 @@ #define ABX8XX_CTRL2_RSVD BIT(5) #define ABX8XX_REG_IRQ 0x12 +#define ABX8XX_IRQ_EX1E BIT(0) +#define ABX8XX_IRQ_EX2E BIT(1) #define ABX8XX_IRQ_AIE BIT(2) +#define ABX8XX_IRQ_TIE BIT(3) +#define ABX8XX_IRQ_BLIE BIT(4) #define ABX8XX_IRQ_IM_1_4 (0x3 << 5) #define ABX8XX_REG_CD_TIMER_CTL 0x18 #define ABX8XX_REG_OSC 0x1c +#define ABX8XX_OSC_ACIE BIT(0) +#define ABX8XX_OSC_OFIE BIT(1) #define ABX8XX_OSC_FOS BIT(3) #define ABX8XX_OSC_BOS BIT(4) #define ABX8XX_OSC_ACAL_512 BIT(5) @@ -266,6 +272,7 @@ static irqreturn_t abx80x_handle_irq(int irq, void *dev_id) struct i2c_client *client = dev_id; struct abx80x_priv *priv = i2c_get_clientdata(client); struct rtc_device *rtc = priv->rtc; + unsigned int status_flags_clear; int status; guard(mutex)(&priv->lock); @@ -284,9 +291,15 @@ static irqreturn_t abx80x_handle_irq(int irq, void *dev_id) if (status & ABX8XX_STATUS_WDT) dev_alert(&client->dev, "watchdog timeout interrupt.\n"); - i2c_smbus_write_byte_data(client, ABX8XX_REG_STATUS, 0); + status_flags_clear = status & (ABX8XX_STATUS_AF | ABX8XX_STATUS_WDT); - return IRQ_HANDLED; + if (status_flags_clear) { + i2c_smbus_write_byte_data(client, ABX8XX_REG_STATUS, + status & ~status_flags_clear); + return IRQ_HANDLED; + } + + return IRQ_NONE; } static int abx80x_read_alarm(struct device *dev, struct rtc_wkalrm *t) @@ -942,6 +955,41 @@ static int abx80x_probe(struct i2c_client *client) i2c_set_clientdata(client, priv); + /* Disable unused interrupts */ + data = i2c_smbus_read_byte_data(client, ABX8XX_REG_IRQ); + if (data < 0) { + dev_err(&client->dev, "Unable to read irq register\n"); + return -EIO; + } + + err = i2c_smbus_write_byte_data(client, ABX8XX_REG_IRQ, + data & ~(ABX8XX_IRQ_EX1E | + ABX8XX_IRQ_EX2E | + ABX8XX_IRQ_TIE | + ABX8XX_IRQ_BLIE)); + if (err < 0) { + dev_err(&client->dev, "Unable to write irq register\n"); + return -EIO; + } + + data = i2c_smbus_read_byte_data(client, ABX8XX_REG_OSC); + if (data < 0) { + dev_err(&client->dev, "Unable to read Oscillator Control register\n"); + return -EIO; + } + + /* Unlock write access to Oscillator Control Register */ + if (abx80x_write_config_key(client, ABX8XX_CFG_KEY_OSC) < 0) + return -EIO; + + err = i2c_smbus_write_byte_data(client, ABX8XX_REG_OSC, + data & ~(ABX8XX_OSC_ACIE | + ABX8XX_OSC_OFIE)); + if (err < 0) { + dev_err(&client->dev, "Unable to write Oscillator Control register\n"); + return -EIO; + } + if (abx80x_caps[part].has_wdog) { err = abx80x_setup_watchdog(priv); if (err) -- 2.55.0