From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00E0C3D0C1D for ; Wed, 16 Sep 2026 22:42:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789598532; cv=none; b=NYrRq0qxWPDRBL9o/vy4VVWveaMuZLWxKGNAU9WU7+BZ+9APP41pY3HR60Ois5lYCj/BP+ybEhQ9J7MecOwrY7vS66CLLz/zoh7bGEyeYQo1JV01ACkn/AiFAjIqT8rVWqybMVBMjkB5vMUIkpWTlMPqpv+yG2DjdnPdxK3Jcqg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789598532; c=relaxed/simple; bh=hHZxIDfTTXE3RHk4SVGuQUCFQzj7YuaDChZ/jubhCR8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BAB8HJQiAcDbJH4GkB1PPYlU9hGyHzqOVS+aVfBGRnLtc/ZDnclwetBpyKbgQCVixpuV5tFnWoCGT0PHGVTuik3vHztVmMtqEsYpXm4sDjznNV8ZpIUlgvAPBxIds61MNh1fIwTbnFgG+jnw8jmw1ounjMGJz5F+oSuXdgBH/5o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WB43xwvO; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WB43xwvO" Received: by mail-pj2-f13.google.com with SMTP id d9443c01a7336-2d747ee1f9bso1946065ad.3 for ; Wed, 16 Sep 2026 15:42:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789598519; x=1790203319; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=wqgRj8Zu/oLhBcm8V6wCiIRsYY69FuThlNcNP+a4SnE=; b=WB43xwvOFQXKyCtk4CbeeisHyQMEpJ37kTc6qrBserLKkEJ+JSBJVsaECsZXxPHvyz f1LKiNm422G6ok3ezdi0SHD2Rfo5IN7RAvc1mm9cOXpJ52qnczDg9AGXLsrwpzebJNU3 vmgdIOz1gZgZaINwpnmk0ZDDeXvYxollmVWLBPfyfmcBG2EaRMc4+Dwj3gVu40OI0RBS 7aN+lKAWAaxudruPgicfkuJAqDmE5JQpUQCqoYKdXxoYYhhjkSQww7zVcg76PEqDmZu8 CI8/vU3LJDRA9vZIWLvlZcDhosja1MTMPs3zIGUuhDwRnHfCXLeSNhZkDAgR849hkRJL IQ1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789598519; x=1790203319; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wqgRj8Zu/oLhBcm8V6wCiIRsYY69FuThlNcNP+a4SnE=; b=krf+YEEqF93+PWTsYsm2VVH9bgy+JbF+QAgPJUdGD6cv5mDgOswbIHjGUHvV2U+11C qP5gzjXPDsRly7K5xcRYQfRFDxYAclfYQEJzPBwbBiVgbVtPx38CpcOUEtXjyApZnr1g V5bWe4rxMFKB3lN2+x/CctSloHyB+R38Pc98lfotmSmXYEBEjSK2hTsHYRIzhN+j+2py ajhS+C3Y3voUDkopgqOT+J0mARrcTms2q4M4mytLxdpvinsEUvCS3XOnMX+g4h+fR5Ik BxTCfofSMnTGwXP4MDjplqLNX//wxQOelu6+I6kPHFixODGLGQvWGsxcbM+0T0jFnTd3 u0zA== X-Forwarded-Encrypted: i=1; AKwUvBz9M/NKnZsE/rjSs7egeS4Kj6ANcMyL7Z/7bP19+PhZs1x9pgtquyDvQtUQe30WYj2eWWOEYiwDv1sNkeY=@vger.kernel.org X-Gm-Message-State: AFuF++nLZCkL0X0pN6B8puiLxIk7VHPjcO6oN3onPDDGX7suD8ezXZED fy5AWJtrtw95BjAR5F3WlcbwYBk2edQBtErxlXM8TEOxloxP07IMFPQx X-Gm-Gg: AYBFou3QDusRJH08aAgrobmaxf+WkALXz23t+IJNL19vli+Yb4GcH6QJBtM89IR9zA9 mK3yfivs95IUsRshUYrPLS0uCXRkrMcXRXltcGHAaQ6MtZEsePwbynebF5383iLRx0dqZLwdXYc uc3xBW3HQDD5zil8LFe5Yl+Ev1Vf/G1OlLsmzcpNjY6KkoXsEA4a3bVhI8beg6X18hONJkHqjBv UxtZhxshcJ5O5FIfxCOvWyL/VKnUr3B80nmAf5QKlo6vsYRb7Xv4z+N9rwWVEfbePP/dokFQFjw iebIxZxLDr4Vq0IPm7vpNXvqhzS8lSZkJNrwOb8pNbxt5TDCNCs5/DowEYzcds9M1foMImVZTtt NloZ9oFzMENctLfXKDtErdUYm0ZIbJW7qz2O42UHoSQyDOotJj3VHDMwsXjWLTmPTgEFacSOHz0 biHKQC9pW8gs5dpz9IyqOKIc5Q0ZJCDsj8tplPjWtTpWB6Uq368sfo+odAxPMpw4j8Cye4XrNy7 2Qm5/irU1tIlQd5tRGJVexlw27umLcdMMsKLk5UJJUvBdicrdhFGd1VuCYrGhb1RbPBuRbSvUrC yD67P378CcBwOTsgmrlI1r15V4iaqJu6x8tdiyEbYSIqRM/y X-Received: by 2002:a17:90b:560e:b0:39e:3bd2:8998 with SMTP id 98e67ed59e1d1-39e3bd28b84mr1304054a91.22.1789598519204; Wed, 16 Sep 2026 15:41:59 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-14395caccf1sm8260106c88.2.2026.09.16.15.41.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 15:41:58 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , "Christophe Leroy (CS GROUP)" , linux-kernel@vger.kernel.org (open list), linuxppc-dev@lists.ozlabs.org (open list:FREESCALE SOC DRIVERS), linux-arm-kernel@lists.infradead.org (moderated list:FREESCALE SOC DRIVERS) Subject: [PATCHv2] dmaengine: bestcomm: use platform machinery to get irq Date: Wed, 16 Sep 2026 15:41:56 -0700 Message-ID: <20260916224156.276511-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit platform_get_irq() avoids having to explicitly map and dispose of an irq by having the platform_device machinery take care of it. This requires replacing the device_node with a platform_device in the bcom_eng struct so that platform_get_irq() can use it. Conveniently, this also allows getting rid of of_node_get and of_node_put as the platform_device machinery also handles that. Replace the open-coded resource lookup, request_mem_region, ioremap and the manual iounmap/release_mem_region cleanup in probe/remove with the managed devm_platform_get_and_ioremap_resource() helper. This removes the now-unused error-unmap/release paths and simplifies the driver. Adjust the goto labels in bcom_task_alloc to match what is being freed. Signed-off-by: Rosen Penev --- v2: resend. drivers/dma/bestcomm/bestcomm.c | 47 ++++++++-------------- include/linux/fsl/bestcomm/bestcomm_priv.h | 2 +- 2 files changed, 18 insertions(+), 31 deletions(-) diff --git a/drivers/dma/bestcomm/bestcomm.c b/drivers/dma/bestcomm/bestcomm.c index 241a91936fe8..1006030ff167 100644 --- a/drivers/dma/bestcomm/bestcomm.c +++ b/drivers/dma/bestcomm/bestcomm.c @@ -47,6 +47,7 @@ bcom_task_alloc(int bd_count, int bd_size, int priv_size) { int i, tasknum = -1; struct bcom_task *tsk; + int irq; /* Don't try to do anything if bestcomm init failed */ if (!bcom_eng) @@ -67,30 +68,32 @@ bcom_task_alloc(int bd_count, int bd_size, int priv_size) if (tasknum < 0) return NULL; + irq = platform_get_irq(bcom_eng->pdev, tasknum); + if (irq < 0) + goto err1; + /* Allocate our structure */ tsk = kzalloc(sizeof(struct bcom_task) + priv_size, GFP_KERNEL); if (!tsk) - goto error; + goto err1; tsk->tasknum = tasknum; if (priv_size) tsk->priv = (void*)tsk + sizeof(struct bcom_task); /* Get IRQ of that task */ - tsk->irq = irq_of_parse_and_map(bcom_eng->ofnode, tsk->tasknum); - if (!tsk->irq) - goto error; + tsk->irq = irq; /* Init the BDs, if needed */ if (bd_count) { tsk->cookie = kmalloc_array(bd_count, sizeof(void *), GFP_KERNEL); if (!tsk->cookie) - goto error; + goto err2; tsk->bd = bcom_sram_alloc(bd_count * bd_size, 4, &tsk->bd_pa); if (!tsk->bd) - goto error; + goto err3; memset_io(tsk->bd, 0x00, bd_count * bd_size); tsk->num_bd = bd_count; @@ -99,17 +102,12 @@ bcom_task_alloc(int bd_count, int bd_size, int priv_size) return tsk; -error: - if (tsk) { - if (tsk->irq) - irq_dispose_mapping(tsk->irq); - bcom_sram_free(tsk->bd); - kfree(tsk->cookie); - kfree(tsk); - } - +err3: + kfree(tsk->cookie); +err2: + kfree(tsk); +err1: bcom_eng->tdt[tasknum].stop = 0; - return NULL; } EXPORT_SYMBOL_GPL(bcom_task_alloc); @@ -125,7 +123,6 @@ bcom_task_free(struct bcom_task *tsk) bcom_eng->tdt[tsk->tasknum].stop = 0; /* Free everything */ - irq_dispose_mapping(tsk->irq); bcom_sram_free(tsk->bd); kfree(tsk->cookie); kfree(tsk); @@ -377,16 +374,12 @@ static int mpc52xx_bcom_probe(struct platform_device *op) if (IS_ERR(regs)) return PTR_ERR(regs); - /* Get the bestcomm node */ - of_node_get(op->dev.of_node); - /* Prepare SRAM */ ofn_sram = of_find_matching_node(NULL, mpc52xx_sram_ids); if (!ofn_sram) { printk(KERN_ERR DRIVER_NAME ": " "No SRAM found in device tree\n"); - rv = -ENODEV; - goto error_ofput; + return -ENODEV; } rv = bcom_sram_init(ofn_sram, DRIVER_NAME); of_node_put(ofn_sram); @@ -394,7 +387,7 @@ static int mpc52xx_bcom_probe(struct platform_device *op) if (rv) { printk(KERN_ERR DRIVER_NAME ": " "Error in SRAM init\n"); - goto error_ofput; + return rv; } /* Get a clean struct */ @@ -405,8 +398,7 @@ static int mpc52xx_bcom_probe(struct platform_device *op) } /* Save the node */ - bcom_eng->ofnode = op->dev.of_node; - + bcom_eng->pdev = op; bcom_eng->regs = regs; bcom_eng->regs_base = res_bcom->start; @@ -426,8 +418,6 @@ static int mpc52xx_bcom_probe(struct platform_device *op) kfree(bcom_eng); bcom_eng = NULL; bcom_sram_cleanup(); -error_ofput: - of_node_put(op->dev.of_node); printk(KERN_ERR "DMA: MPC52xx BestComm init failed !\n"); @@ -443,9 +433,6 @@ static void mpc52xx_bcom_remove(struct platform_device *op) /* Cleanup SRAM */ bcom_sram_cleanup(); - /* Release the node */ - of_node_put(bcom_eng->ofnode); - /* Release memory */ kfree(bcom_eng); bcom_eng = NULL; diff --git a/include/linux/fsl/bestcomm/bestcomm_priv.h b/include/linux/fsl/bestcomm/bestcomm_priv.h index 3b52f3ffbdf8..cddde7c74cb5 100644 --- a/include/linux/fsl/bestcomm/bestcomm_priv.h +++ b/include/linux/fsl/bestcomm/bestcomm_priv.h @@ -66,7 +66,7 @@ struct bcom_tdt { * This holds all info needed globaly to handle the engine */ struct bcom_engine { - struct device_node *ofnode; + struct platform_device *pdev; struct mpc52xx_sdma __iomem *regs; phys_addr_t regs_base; -- 2.55.0