mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicolas Schier <n.schier@fritz.com>
To: Julian Braha <julianbraha@gmail.com>
Cc: nathan@kernel.org, nico@fluxnic.net, rdunlap@infradead.org,
	grahamr@qti.qualcomm.com, kees@kernel.org, pengpeng@iscas.ac.cn,
	vegard.nossum@oracle.com, linux-kernel@vger.kernel.org,
	linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v2 5/5] kconfig: use unsigned integers for hex range checks
Date: Thu, 17 Sep 2026 18:36:56 +0200	[thread overview]
Message-ID: <20260917-nocturnal-dramatic-donkey-e1f8e1@l-nschier-aarch64> (raw)
In-Reply-To: <20260915211508.291790-6-julianbraha@gmail.com>

On Tue, Sep 15, 2026 at 10:15:08PM +0100, Julian Braha wrote:
> While 'hex' values should use the bounds of 64-bit unsigned integers, the
> range values are treated as signed (checks use strtoll).
> 
> For example:
> 
>   config HEX_RANGE
>     hex
>     range 0 0xfffffffffffffffe
>     default 0xffffffffffffffff
> 
> the default value should adjust down to the upper bound of
> 0xfffffffffffffffe, but since the check incorrectly parses both as
> LLONG_MAX, the value stays at the out-of-range default of
> 0xffffffffffffffff.
> 
> To fix this, let's use a union of signed and unsigned integers to
> represent both 'int' and 'hex' range values, then use both strtoll and
> strtoull where appropriate.
> 
> Assisted-by: LLM
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
>  scripts/kconfig/symbol.c                      | 41 ++++++++++++++-----
>  .../kconfig/tests/warn_changed_input/Kconfig  |  5 +++
>  .../tests/warn_changed_input/expected_config  |  1 +
>  3 files changed, 36 insertions(+), 11 deletions(-)
> 

Thanks for the whole patch-set, I appreciate your clean-up and 
strengthening of kconfig!

Reviewed-by: Nicolas Schier <n.schier@fritz.com>

Kind regards,
Nicolas

  reply	other threads:[~2026-09-17 16:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15 21:15 [PATCH v2 0/5] kconfig: improve input validation for numeric options Julian Braha
2026-09-15 21:15 ` [PATCH v2 1/5] kconfig: promote invalid numeric reference from warning to error Julian Braha
2026-09-17 10:54   ` Nicolas Schier
2026-09-15 21:15 ` [PATCH v2 2/5] kconfig: check for out-of-bounds numeric constants Julian Braha
2026-09-17 15:13   ` Nicolas Schier
2026-09-15 21:15 ` [PATCH v2 3/5] kconfig: check for hex and int mismatches Julian Braha
2026-09-17 15:57   ` Nicolas Schier
2026-09-15 21:15 ` [PATCH v2 4/5] kconfig: prevent out-of-bounds user input for numeric options Julian Braha
2026-09-17 16:13   ` Nicolas Schier
2026-09-15 21:15 ` [PATCH v2 5/5] kconfig: use unsigned integers for hex range checks Julian Braha
2026-09-17 16:36   ` Nicolas Schier [this message]
2026-09-17 23:48 ` [PATCH v2 0/5] kconfig: improve input validation for numeric options Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260917-nocturnal-dramatic-donkey-e1f8e1@l-nschier-aarch64 \
    --to=n.schier@fritz.com \
    --cc=grahamr@qti.qualcomm.com \
    --cc=julianbraha@gmail.com \
    --cc=kees@kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nathan@kernel.org \
    --cc=nico@fluxnic.net \
    --cc=pengpeng@iscas.ac.cn \
    --cc=rdunlap@infradead.org \
    --cc=vegard.nossum@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®