From: Jonathan Cameron <jic23@kernel.org>
To: Chris Morgan <macromorgan@hotmail.com>
Cc: "Kanak Shilledar" <kanak.shilledar@axis.com>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Linmao Li" <lilinmao@kylinos.cn>,
kernel@axis.com
Subject: Re: [PATCH togreg v4 0/2] iio: imu: inv_icm42607: fix PM error handling
Date: Thu, 17 Sep 2026 03:32:11 +0100 [thread overview]
Message-ID: <20260917033211.6226c895@jic23-hlaptop> (raw)
In-Reply-To: <PH0PR19MB99733868ECBD2EBDD57833E80BA5BA2@PH0PR19MB997338.namprd19.prod.outlook.com>
On Tue, 15 Sep 2026 12:00:28 -0500
Chris Morgan <macromorgan@hotmail.com> wrote:
> On Mon, Sep 14, 2026 at 04:34:06PM +0200, Kanak Shilledar wrote:
> > > The recently queued ICM-42607 PM support has two error paths that can leave
> > > the PM core's state inconsistent with the device.
> > >
> > > Patch 1 propagates sensor shutdown failures from runtime suspend. Patch 2
> > > ensures that system resume restores runtime PM management on both of its
> > > error paths, so that a failed resume does not leave runtime PM disabled for
> > > good.
> > >
> > > Changes since v3:
> > > - Patch 1: commit message expanded with the practical effect of the current
> > > behaviour, the cost of propagating the error, and a description of the
> > > recovery path that does not assume a particular regmap bus
> > > implementation. No code change.
> > > - Patch 2: unchanged.
> > >
> > > Neither patch was reproduced on hardware; both were found by code
> > > inspection. They were compile-tested with W=1 and checked with smatch.
> > >
> > > Whether patch 1 is worth making is still a fair question - it trades a
> > > possible idle power leak that may be cleared by a later successful access
> > > for a runtime PM error state that needs an explicit reset. The commit
> > > message spells that out; happy to drop it if you would rather not take
> > > that trade.
> > >
> > > Linmao Li (2):
> > > iio: imu: inv_icm42607: propagate runtime suspend errors
> > > iio: imu: inv_icm42607: restore runtime PM on system resume errors
> > >
> > > .../iio/imu/inv_icm42607/inv_icm42607_core.c | 38 ++++++++++++++-----
> > > 1 file changed, 29 insertions(+), 9 deletions(-)
> > >
> > > base-commit: 350d1fb9204b13c5f95e511e98b8bcb47574d425
> > > --
> > > 2.25.1
> >
> > Tested on Invensense, ICM-42370-P development board. Performed testing
> > with basic r/w to the device and checking the PM runtime status. It
> > worked as expeted.
> >
> > Tested-by: Kanak Shilledar <kanak.shilledar@axis.com>
> >
> > --
> > Kanak Shilledar <kanak.shilledar@axis.com>
>
> Sorry, I've been a bit busy with back-to-school stuff this month for my
> kids. I've tested these patches and do not see any problems with them on
> my device. Note though that I didn't observe any errors prior, but I can
> at least confirm this doesn't appear to introduce new ones.
>
> Thank you,
> Chris
>
> Tested-by: Chris Morgan <macromorgan@hotmail.com>
Great. Thanks to both of your the tests. We should never hit any of
these conditions unless something has gone wrong hardware side.
Applied to the fixes-togreg branch of iio.git. Whether that
goes upstream before the next merge window or waits until then
is dependent on what else comes in.
Thanks
Jonathan
prev parent reply other threads:[~2026-09-17 2:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 3:55 Linmao Li
2026-08-24 3:55 ` [PATCH togreg v4 1/2] iio: imu: inv_icm42607: propagate runtime suspend errors Linmao Li
2026-08-24 3:55 ` [PATCH togreg v4 2/2] iio: imu: inv_icm42607: restore runtime PM on system resume errors Linmao Li
2026-09-01 1:22 ` [PATCH togreg v4 0/2] iio: imu: inv_icm42607: fix PM error handling Jonathan Cameron
2026-09-14 3:05 ` Jonathan Cameron
2026-09-14 9:23 ` Kanak Shilledar
2026-09-14 14:34 ` Kanak Shilledar
2026-09-15 17:00 ` Chris Morgan
2026-09-17 2:32 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917033211.6226c895@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=kanak.shilledar@axis.com \
--cc=kernel@axis.com \
--cc=lilinmao@kylinos.cn \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macromorgan@hotmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®