From: Jonathan Cameron <jic23@kernel.org>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: "Guangshuo Li" <lgs201920130244@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>, "Siratul Islam" <email@sirat.me>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] iio: accel: kxcjk-1013: disable autosuspend on remove
Date: Thu, 17 Sep 2026 04:05:42 +0100 [thread overview]
Message-ID: <20260917040542.2600a7af@jic23-hlaptop> (raw)
In-Reply-To: <20260914144920.00002f7b@gmail.com>
On Mon, 14 Sep 2026 14:49:20 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> On Mon, 14 Sep 2026 19:20:53 +0800
> Guangshuo Li <lgs201920130244@gmail.com> wrote:
>
> ...
>
> > Add the missing pm_runtime_dont_use_autosuspend() call to the remove
> > path.
> >
> > This issue was found by manual code inspection.
> >
>
> I'm on the fence whether this sentence should go under the ---
In this world of LLMs I'm going to stick up for human effort and
keep that in the commit message :)
Either would have been fine with me.
I'm not going to rush this one in, so applied to the testing branch of
iio.git
Thanks,
Jonathan
>
> ...
>
> > @@ -1547,6 +1547,7 @@ static void kxcjk1013_remove(struct i2c_client *client)
> >
> > iio_device_unregister(indio_dev);
> >
> > + pm_runtime_dont_use_autosuspend(&client->dev);
> > pm_runtime_disable(&client->dev);
> > pm_runtime_set_suspended(&client->dev);
> >
>
> It would've been better if you sent the 4 patches as a series with a cover
> letter as all of them are the same fix.
>
> Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
>
next prev parent reply other threads:[~2026-09-17 3:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 11:20 Guangshuo Li
2026-09-14 12:49 ` Joshua Crofts
2026-09-17 3:05 ` Jonathan Cameron [this message]
2026-09-14 15:42 ` srinivas pandruvada
2026-09-17 5:04 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917040542.2600a7af@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=dakr@kernel.org \
--cc=dlechner@baylibre.com \
--cc=email@sirat.me \
--cc=joshua.crofts1@gmail.com \
--cc=lgs201920130244@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®