mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
	 Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	 James Clark <james.clark@linaro.org>,
	linux-perf-users@vger.kernel.org,  linux-kernel@vger.kernel.org
Cc: sashiko-bot@kernel.org
Subject: [PATCH v1 04/11] perf llvm: missing explicit POSIX headers in symbol__disassemble_llvm()
Date: Wed, 16 Sep 2026 21:53:19 -0700	[thread overview]
Message-ID: <20260917045326.63601-4-irogers@google.com> (raw)
In-Reply-To: <20260917045326.63601-1-irogers@google.com>

Sashiko reported:

  When building the perf tool in an environment utilizing a strict C
  library such as musl libc, compilation fails because
  tools/perf/util/llvm.c omits explicit inclusion of <stdlib.h> and
  <inttypes.h>.

  The function symbol__disassemble_llvm() directly invokes free() for
  memory deallocation and utilizes the PRIx64 macro for formatting
  64-bit integers.  While glibc often implicitly provides these POSIX
  definitions via other includes, relying on transitive inclusion
  creates a brittle dependency that violates perf subsystem
  portability guidelines. On environments that do not implicitly pull
  in these headers, the compiler encounters undeclared identifier and
  unknown type name errors for free() and PRIx64, preventing
  successful builds of the perf toolchain.

Add the header files and use git clang-format to sort.

Reported-by: sashiko-bot@kernel.org
Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/util/llvm.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/tools/perf/util/llvm.c b/tools/perf/util/llvm.c
index a0deb742a733..95efd089014b 100644
--- a/tools/perf/util/llvm.c
+++ b/tools/perf/util/llvm.c
@@ -1,5 +1,14 @@
 // SPDX-License-Identifier: GPL-2.0
 #include "llvm.h"
+
+#include <errno.h>
+#include <inttypes.h>
+#include <stdlib.h>
+
+#include <fcntl.h>
+#include <linux/zalloc.h>
+#include <unistd.h>
+
 #include "annotate.h"
 #include "debug.h"
 #include "dso.h"
@@ -7,10 +16,6 @@
 #include "namespaces.h"
 #include "srcline.h"
 #include "symbol.h"
-#include <errno.h>
-#include <fcntl.h>
-#include <unistd.h>
-#include <linux/zalloc.h>
 
 #ifdef HAVE_LIBLLVM_SUPPORT
 #include "llvm-c-helpers.h"
-- 
2.55.0.1082.g2b9226bbc0-goog


  parent reply	other threads:[~2026-09-17  4:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17  4:53 [PATCH v1 01/11] perf aslr: Add missing includes and sort headers Ian Rogers
2026-09-17  4:53 ` [PATCH v1 02/11] perf bench messaging: " Ian Rogers
2026-09-17  4:53 ` [PATCH v1 03/11] perf unwind-libdw: missing <stdlib.h> in libdw_set_initial_registers() Ian Rogers
2026-09-17  4:53 ` Ian Rogers [this message]
2026-09-17  4:53 ` [PATCH v1 05/11] perf dso: missing POSIX headers string.h and limits.h Ian Rogers
2026-09-17  4:53 ` [PATCH v1 06/11] perf test: missing stdio.h and signal.h inclusions in cmd_test() Ian Rogers
2026-09-17  4:53 ` [PATCH v1 07/11] perf ui annotate-data: missing explicit inclusion of stdlib.h and stdio.h Ian Rogers
2026-09-17  4:53 ` [PATCH v1 08/11] perf annotate-data: missing <string.h> inclusion for libc string functions Ian Rogers
2026-09-17  4:53 ` [PATCH v1 09/11] perf mem: missing stdio.h and limits.h in mem-events.c Ian Rogers
2026-09-17  4:53 ` [PATCH v1 10/11] perf config: undeclared PATH_MAX due to missing <limits.h> inclusion Ian Rogers
2026-09-17  4:53 ` [PATCH v1 11/11] perf mem: missing standard POSIX headers in builtin-mem.c Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260917045326.63601-4-irogers@google.com \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=sashiko-bot@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®