From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ED523E410F for ; Thu, 17 Sep 2026 04:53:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.198 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789620832; cv=none; b=duLslDJJ+DF1hVY9XJt9gfYqC8O3UznHEt2EPOInYVBujJ8uYyj9GKX7vfl7rFy2/JLGw/spvFasWZZfZ3ib7qQDlJ0n4/BSl/9kp26urJBGcOxHMZ8NLE9JJBCj2v/6jxfhQGtgB2oEMTY87zjz3HXGVg22xED+LTg2p+7dpPQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789620832; c=relaxed/simple; bh=5DklQJpfCFJyN0EZrRZqRXjxXKTZyUSm4Q+g/bsrlA8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=tOHoQfm0vpqKaQaIVR2JnNcqLh+yyHQtld4wPbBFdDZMCw7qAwirXK3wi0ZyTRaVFBCgvkjq99XNXHzHi63kg5MaGoSM5YzyDBAm0PSki1dtXmwxktjWyvWuvzM+dnsvf6QDDYngIhWMM4M/CtmYabXh3L+Q2gBkwYEJ6vRfQ4M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=OX25Gn7k; arc=none smtp.client-ip=209.85.215.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OX25Gn7k" Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cc1ca15334cso566930a12.1 for ; Wed, 16 Sep 2026 21:53:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1789620829; x=1790225629; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ctknpE6kMV5LkwM9lNHtmlsQ1sWEmYmqXPSOFSZmCm4=; b=OX25Gn7kOuOpuWa8t41EIB7Ldk7ZTJVHPh+brxsLz/koIVy6N3BmaKMyy30ZJcnP14 IysnRzr6GZQ6xmw953oqfvXTRqKfNp1jAsocJkhT8mw2ryxEG401KsxsFWa6Uam/LV4c Zc5qTgNONK5oP12HGjRuGBEtsB1u3c2AlQ4sOh1zKQJfDc75y1o+3IKcylF83Xcf58aK 2lMOZZgRE3A9f2hKpHJq24r2RkGJMNlwUKDuDLXv2jfDLF5feWOpC8iiXbI6ncGVp1Pm JyF8jmqhBGVTu5QIScBoI9EmqX+mmicfIhQnCCCJaf3BFnfwUPq4WiWkZzD9FD5Dfz4t Tiog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789620829; x=1790225629; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ctknpE6kMV5LkwM9lNHtmlsQ1sWEmYmqXPSOFSZmCm4=; b=R2dtst94kRI36X5Dyi/o3emWByiJnkNYjsUy/q3w9oD90mT4HMY3K4lPBHeikjoe1a KWeSmgKH3U/kYOl0IqjsFrl4ZRiewqYbFc3VJvU/efGWxbrG7Sigjug7hM6UYh3kUpBV Gz0yxaCbbh20hAhDgm9idDt/zMrCOHfsmJ+XhbvRh0jaxufCL6GhtvcrrHRhmqictiHD a+AOCWQsWCWFWyuTqYOz/Z6zTYKfwKLO+aKSUsDggk9+EEuNvsJ1EveTHJAsRn87w8gE PTdoyVVx+Pgr/N7QcZcDBCBOnnVZ0ScFy0jXQUqYN8VCu1+X4nzVayxlnZOyFjhPhCxV 9aBA== X-Forwarded-Encrypted: i=1; AKwUvBxjrX4V02bhVgx8xmw0s/YUZEp/gJ/G/I/IY2IgD4yNn2I6++POC0zamABP8I3NBgS5L0t+of+H9dim44I=@vger.kernel.org X-Gm-Message-State: AFuF++nMAjQ+LY+YPm86Ls+gPeIqZdLpuk352dSVjq2TuiBqqlGbWj1f YweyYE83/I9/oXGmyqEpBaGnqjOFOqcsry4wfWwd4hEeV528CfeRGfXfdWP+XwP10VGdSend9v2 6N+vfkAd9WQ== X-Received: from dycc4.prod.google.com ([2002:a05:693c:60c4:b0:336:afee:118c]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:2584:b0:3da:bea4:6215 with SMTP id adf61e73a8af0-3dd5f72046cmr12464935637.19.1789620829321; Wed, 16 Sep 2026 21:53:49 -0700 (PDT) Date: Wed, 16 Sep 2026 21:53:23 -0700 In-Reply-To: <20260917045326.63601-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260917045326.63601-1-irogers@google.com> X-Mailer: git-send-email 2.55.0.1082.g2b9226bbc0-goog Message-ID: <20260917045326.63601-8-irogers@google.com> Subject: [PATCH v1 08/11] perf annotate-data: missing inclusion for libc string functions From: Ian Rogers To: Arnaldo Carvalho de Melo , Namhyung Kim , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: sashiko-bot@kernel.org Content-Type: text/plain; charset="UTF-8" Sashiko reported: When compiling the perf tool with musl libc, tools/perf/util/annotate-data.c fails to build due to the missing header. The source file utilizes standard C library string and memory functions, such as memset() in init_type_state() and strcmp() in data_type_cmp(). While glibc implicitly pulls in via other standard headers, musl libc enforces stricter header separation. Because the header is not explicitly included at the top of the file, the compiler encounters implicit function declarations for these standard string functions. This results in a direct compile-time build error. Add the header files and use git clang-format to sort. Reported-by: sashiko-bot@kernel.org Signed-off-by: Ian Rogers --- tools/perf/util/annotate-data.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/annotate-data.c b/tools/perf/util/annotate-data.c index aff60a630fd0..02df833504be 100644 --- a/tools/perf/util/annotate-data.c +++ b/tools/perf/util/annotate-data.c @@ -4,20 +4,23 @@ * * Written by Namhyung Kim */ +#include "annotate-data.h" + #include +#include #include #include -#include +#include + #include #include "annotate.h" -#include "annotate-data.h" -#include "debuginfo.h" #include "debug.h" +#include "debuginfo.h" #include "dso.h" #include "dwarf-regs.h" -#include "evsel.h" #include "evlist.h" +#include "evsel.h" #include "map.h" #include "map_symbol.h" #include "sort.h" -- 2.55.0.1082.g2b9226bbc0-goog