From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F09844E659 for ; Thu, 17 Sep 2026 08:38:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789634338; cv=none; b=AS7sVEAiOtQ8G70b1X61f4Yd4SdKDAGqzjKMa9ipE/tBMuVb8menEi2LaLNzmpdtUcexhJuJKpoQq/nRp57XwD/sWxBAP1SOaXQwLQpJXsfWOt0uOZw0nzQzvKDtLex/aBCwlxhDtCrg9uAHv1Z/+REmaKmsgxoHHOAI+jtq/b4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789634338; c=relaxed/simple; bh=Haa1z/DghnZT1qkXm5SKTSly5CBcdv1q5VCtlQW+b8U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gm2B4s4ELIFmDu5rd/vLFczRWC6ot/D3vPvS0gR5VdgSoYtGvA3AnxxefpJHa/74YatgCz3yoN7qJMHFE5e763yB40FawJg2z1XBgdAt351/2/XEYU0oKTQZevdvGCu6ia/tULd9tabyGFXHzSzA6MgNXL/A0b75ybnvc84TySc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RwRqLRT3; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RwRqLRT3" Received: by mail-pj2-f13.google.com with SMTP id 98e67ed59e1d1-396ccc09d65so476544a91.3 for ; Thu, 17 Sep 2026 01:38:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789634331; x=1790239131; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=T87rxYlu6jlwQQ8pbt3sOEyP8di5cJFMReAsYyBJE5U=; b=RwRqLRT3E/I5+GyUW6iiUaS5UrbEM0+7CLmwl4kIN2NIa1cMKGQUHq0Bd3mQk8PFnh W7bj6qi+UfmgbetWwYPFwLUCrxLotWtenhESEvQoBfS6tuaXTQbzDGgAK4ukMVxGwpgh 3rniXTUhp8rHA7FgCqvH7xjLZRsdERoxxCNW/0AwENaJm522hX2T3Zv936xlBIexs+RW MyLlvoki2J5inSvJsWVUUU+lxLkWhHe9SkAz4YSIy+hsCd0sQ8KvWWxeT9SKUXx3LVsl FFNXS6mjYbyrgt72IYQ8oNfRHj75nipqBefyMAkm3oT6cIN2Sn2hP5lowyHEg3c/oJnc kkzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789634331; x=1790239131; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=T87rxYlu6jlwQQ8pbt3sOEyP8di5cJFMReAsYyBJE5U=; b=Y4/3PYQvQf9gx+Mz+VzhV2UB1p3aV93Lmp3zVQ8ypsBX3bVk3fVgEyn7oiUNFArUJo MzjW+ug2RX4k8WVO6rP2MhztdjRclx5gRykB1zpRALnav2ymVp34gNiKZRf6D/H+h5W/ EZ8c+JeBv4Nn/2S+F+ORE0rI1oFnKwwurvtuZU1p/wtA+5ttdTNrIJdho6UGPfea3d9r fa3rBs7mvIF0B0PSz8bs8ttYjCYHYfb2jjGi9wolPoPQT0/DmYP/hpTYkwMaBkxw5Ip+ nDFX9XamQklY8D2UfbZpBO3ViHdzfwd5feYiG3G4NvzMcH0fxi9X9wIqA3WGMfH5TY+R YghQ== X-Forwarded-Encrypted: i=1; AKwUvBxoNAZu/rNS+CnF7+aQXC5vlkHAayFqVsm73bJNGUBC4jVpylNU+VQVrK2bnUGsql1+UeMVbEaGjwXCt9c=@vger.kernel.org X-Gm-Message-State: AFuF++lYhUVds42fg9bMPR2GRX/pBufCKWrwPjG1SzJguGKMyoyuqGWU vqMpf9H5IutlS/XjusbvWpjqNDc8VfBFypDPBEdE2+xS9pwfgOZe2rIc X-Gm-Gg: AYBFou15XdGraviEOGR1kedWgyLVbfd7a/0DugIzUDmT1vmqzgdhPHhJhZgy20ymi/d Jzu/paMASnLe9met2JtjUAVKBWkgy7NUKdUiMMhQDScqfoAZmySZdL2JN2KGSg8jbGXMsgkrtfz Tpu0cwypBvlbqMdYNrblWUTpyot0Jx0vpnwDJCDDzN4MyHa5Jol/5KbypjjQCf3ndvdRyfuKoPP U8YHmVf21ZJ3upvKQMO2kfsWb+ztDQTJjyKAOJFtw6893LXITIVe1Bq8//Hj6Mqj8JJ2sQ2xBit mSvFv2ZLwOnGJozNu0JvmQez9XD/5arXz8EDmUYWdsIbL8+4ZmI2urOJbd/R9IycWD8HpIhfa+v kCdvhUgHY13vON8ecuPCW4igeGBKyvz/zks4ZgK0MwCk2nTwev5kppVyqSXRxtKfqohm4g/gpcm BDSjR6fEdAz61bz12OV24r93zo2UEbzIs32Aoyw2VjL/QD4Bqy7DUK5jfOUXArlVRGFH1o+pjaL tphhNWzc7Fb2xMGsEBuHvynrOah X-Received: by 2002:a17:90b:2d45:b0:39e:261:4e0d with SMTP id 98e67ed59e1d1-39e1e506786mr15054330a91.25.1789634331347; Thu, 17 Sep 2026 01:38:51 -0700 (PDT) Received: from localhost.localdomain ([183.194.144.114]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39e35e56298sm3871317a91.9.2026.09.17.01.38.48 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 17 Sep 2026 01:38:50 -0700 (PDT) From: zjamg To: Song Liu , Yu Kuai Cc: Li Nan , Xiao Ni , NeilBrown , linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, zjamg , stable@vger.kernel.org Subject: [PATCH 1/2] md: fix bblog_size-driven OOB read in super_1_load() and super_1_sync() Date: Thu, 17 Sep 2026 16:38:19 +0800 Message-ID: <20260917083820.57091-2-ndaugoing@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260917083820.57091-1-ndaugoing@gmail.com> References: <20260917083820.57091-1-ndaugoing@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In super_1_load(), when the on-disk feature_map does not have the MD_FEATURE_BAD_BLOCKS flag set, but sb->bblog_offset is non-zero, rdev->badblocks.shift is initialized to 0 while completely bypassing the sectors > (PAGE_SIZE / 512) validation check on sb->bblog_size. Subsequently, when badblocks are updated, super_1_sync() enables the MD_FEATURE_BAD_BLOCKS feature flag and assigns bb->size directly from sb->bblog_size without validating that bb->size fits within the single allocated rdev->bb_page (which is PAGE_SIZE, or PAGE_SIZE / 512 sectors). When md_update_sb() later writes metadata via md_write_metadata(), an unvalidated bb->size (e.g. 0xFFFF) results in a bio whose length exceeds the backing page, causing out-of-bounds reads into kernel memory during block I/O and leaking kernel slab/page contents to disk. Fix this by: 1. Validating sb->bblog_size in the 'else if (sb->bblog_offset != 0)' branch of super_1_load(), returning -EINVAL on oversized values. 2. Clamping bb->size in super_1_sync() to PAGE_SIZE / 512 to ensure it never exceeds the backing rdev->bb_page capacity. Fixes: 2699b67223ac ("md: load/store badblock list from v1.x metadata") Cc: stable@vger.kernel.org Signed-off-by: zjamg --- drivers/md/md.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index 680b34a63cb3..d2433cf41e65 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -1934,8 +1934,11 @@ static int super_1_load(struct md_rdev *rdev, struct md_rdev *refdev, int minor_ if (!badblocks_set(&rdev->badblocks, sector, count, 1)) return -EINVAL; } - } else if (sb->bblog_offset != 0) + } else if (sb->bblog_offset != 0) { + if (le16_to_cpu(sb->bblog_size) > (PAGE_SIZE / 512)) + return -EINVAL; rdev->badblocks.shift = 0; + } if ((le32_to_cpu(sb->feature_map) & (MD_FEATURE_PPL | MD_FEATURE_MULTIPLE_PPLS))) { @@ -2313,7 +2316,8 @@ static void super_1_sync(struct mddev *mddev, struct md_rdev *rdev) bb->sector = (rdev->sb_start + (int)le32_to_cpu(sb->bblog_offset)); - bb->size = le16_to_cpu(sb->bblog_size); + bb->size = min_t(sector_t, le16_to_cpu(sb->bblog_size), + PAGE_SIZE / 512); } } -- 2.53.0