From: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
To: <vkoul@kernel.org>
Cc: <broonie@kernel.org>, <alsa-devel@alsa-project.org>,
<yung-chuan.liao@linux.intel.com>,
<pierre-louis.bossart@linux.dev>, <Basavaraj.Hiregoudar@amd.com>,
<Sunil-kumar.Dommati@amd.com>, <venkataprasad.potturu@amd.com>,
<Syed.SabaKareem@amd.com>, <Mario.Limonciello@amd.com>,
<Richard.Gong@amd.com>, <linux-sound@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
"Vijendar Mukunda" <Vijendar.Mukunda@amd.com>
Subject: [PATCH 6/9] soundwire: amd: introduce struct amd_sdw_hw_ops dispatch framework
Date: Thu, 17 Sep 2026 14:32:54 +0530 [thread overview]
Message-ID: <20260917090407.3828816-7-Vijendar.Mukunda@amd.com> (raw)
In-Reply-To: <20260917090407.3828816-1-Vijendar.Mukunda@amd.com>
Add struct amd_sdw_hw_ops, a function-pointer dispatch table for
hardware-revision-specific SoundWire manager operations. Add inline
dispatch helpers for each callback and a const hw_ops pointer in
struct amd_sdw_manager.
The irq_thread and update_slave_status_work slots take
struct amd_sdw_manager * so that different ACP revisions can register
different handler logic. hw_ops is populated and call sites are wired
through the dispatch helpers in subsequent patches.
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
drivers/soundwire/amd_manager.h | 193 ++++++++++++++++++++++++++++++
include/linux/soundwire/sdw_amd.h | 4 +
2 files changed, 197 insertions(+)
diff --git a/drivers/soundwire/amd_manager.h b/drivers/soundwire/amd_manager.h
index 63fecff62079..2d08c6edd018 100644
--- a/drivers/soundwire/amd_manager.h
+++ b/drivers/soundwire/amd_manager.h
@@ -274,4 +274,197 @@ static u32 sdw_manager_reg_mask_array[AMD_ACP63_SDW_MAX_MANAGER_COUNT] = {
AMD_SDW0_EXT_INTR_MASK,
AMD_SDW1_EXT_INTR_MASK
};
+
+#define AMD_SDW_HW_OPS(amd_manager, cb) ((amd_manager)->hw_ops->cb)
+
+/**
+ * struct amd_sdw_hw_ops - hardware-revision-specific SoundWire manager ops
+ *
+ * @init_sdw_manager: enable the SoundWire manager hardware and perform bus reset
+ * @enable_sdw_manager: set the manager enable bit and wait for it to assert
+ * @disable_sdw_manager: clear the manager enable bit and wait for it to deassert
+ * @enable_sdw_interrupts: unmask ACP-level and per-manager interrupt bits
+ * @disable_sdw_interrupts: mask ACP-level and per-manager interrupt bits
+ * @set_frameshape: write the row/column frame-shape register
+ * @send_cmd_get_resp: issue an immediate command and return the response;
+ * returns 0 on success with the raw u64 response in @response,
+ * or negative on hardware timeout
+ * @wake_enable: enable or disable the in-band SoundWire wake interrupt
+ * @host_wake_enable: enable or disable the host-side wake interrupt
+ * @set_device_state: write the D0/D3 device power state for the manager instance
+ * @read_and_process_ping_status: issue a PING command and process the slave
+ * attach/detach status; called from the IRQ work path
+ * @process_wake_event: handle an in-band wake notification from a slave
+ * @irq_thread: hw_ops callback invoked by the thin work_struct wrapper on
+ * each interrupt; reads status registers and dispatches slave events
+ * @update_slave_status_work: hw_ops callback invoked by the status-update
+ * work item; reads slave status and updates the SoundWire core
+ * @clk_init_ctrl: set the clock divider and update the frame shape registers
+ * based on the current bus clock frequency
+ * @clock_stop_exit: restart the SoundWire bus clock after a CLK_STOP_MODE
+ * suspend; implementation differs across ACP revisions
+ * @suspend: system-suspend hook; stops the bus and powers down the manager
+ * @suspend_runtime: runtime-suspend hook; same sequence as @suspend
+ * @resume_runtime: runtime-resume hook; reinitialises the manager and restarts
+ * the bus after a POWER_OFF_MODE or CLK_STOP_MODE suspend
+ */
+struct amd_sdw_hw_ops {
+ int (*init_sdw_manager)(struct amd_sdw_manager *amd_manager);
+ int (*enable_sdw_manager)(struct amd_sdw_manager *amd_manager);
+ int (*disable_sdw_manager)(struct amd_sdw_manager *amd_manager);
+ void (*enable_sdw_interrupts)(struct amd_sdw_manager *amd_manager);
+ void (*disable_sdw_interrupts)(struct amd_sdw_manager *amd_manager);
+ void (*set_frameshape)(struct amd_sdw_manager *amd_manager);
+ int (*send_cmd_get_resp)(struct amd_sdw_manager *amd_manager, u32 lower_data,
+ u32 upper_data, u64 *response);
+ void (*wake_enable)(struct amd_sdw_manager *amd_manager, bool enable);
+ int (*host_wake_enable)(struct amd_sdw_manager *amd_manager, bool enable);
+ int (*set_device_state)(struct amd_sdw_manager *amd_manager, u32 target_device_state);
+ void (*read_and_process_ping_status)(struct amd_sdw_manager *amd_manager);
+ void (*process_wake_event)(struct amd_sdw_manager *amd_manager);
+ void (*irq_thread)(struct amd_sdw_manager *amd_manager);
+ void (*update_slave_status_work)(struct amd_sdw_manager *amd_manager);
+ int (*clk_init_ctrl)(struct amd_sdw_manager *amd_manager);
+ int (*clock_stop_exit)(struct amd_sdw_manager *amd_manager);
+ int (*suspend)(struct amd_sdw_manager *amd_manager);
+ int (*suspend_runtime)(struct amd_sdw_manager *amd_manager);
+ int (*resume_runtime)(struct amd_sdw_manager *amd_manager);
+};
+
+static inline int acp_init_sdw_manager(struct amd_sdw_manager *amd_manager)
+{
+ if (amd_manager && amd_manager->hw_ops && amd_manager->hw_ops->init_sdw_manager)
+ return AMD_SDW_HW_OPS(amd_manager, init_sdw_manager)(amd_manager);
+ return -EOPNOTSUPP;
+}
+
+static inline int acp_enable_sdw_manager(struct amd_sdw_manager *amd_manager)
+{
+ if (amd_manager && amd_manager->hw_ops && amd_manager->hw_ops->enable_sdw_manager)
+ return AMD_SDW_HW_OPS(amd_manager, enable_sdw_manager)(amd_manager);
+ return -EOPNOTSUPP;
+}
+
+static inline int acp_disable_sdw_manager(struct amd_sdw_manager *amd_manager)
+{
+ if (amd_manager && amd_manager->hw_ops && amd_manager->hw_ops->disable_sdw_manager)
+ return AMD_SDW_HW_OPS(amd_manager, disable_sdw_manager)(amd_manager);
+ return -EOPNOTSUPP;
+}
+
+static inline void acp_enable_sdw_interrupts(struct amd_sdw_manager *amd_manager)
+{
+ if (amd_manager && amd_manager->hw_ops && amd_manager->hw_ops->enable_sdw_interrupts)
+ AMD_SDW_HW_OPS(amd_manager, enable_sdw_interrupts)(amd_manager);
+}
+
+static inline void acp_disable_sdw_interrupts(struct amd_sdw_manager *amd_manager)
+{
+ if (amd_manager && amd_manager->hw_ops && amd_manager->hw_ops->disable_sdw_interrupts)
+ AMD_SDW_HW_OPS(amd_manager, disable_sdw_interrupts)(amd_manager);
+}
+
+static inline void acp_sdw_set_frameshape(struct amd_sdw_manager *amd_manager)
+{
+ if (amd_manager && amd_manager->hw_ops && amd_manager->hw_ops->set_frameshape)
+ AMD_SDW_HW_OPS(amd_manager, set_frameshape)(amd_manager);
+}
+
+static inline int acp_sdw_send_cmd_get_resp(struct amd_sdw_manager *amd_manager,
+ u32 lower_data, u32 upper_data, u64 *response)
+{
+ if (amd_manager && amd_manager->hw_ops && amd_manager->hw_ops->send_cmd_get_resp)
+ return AMD_SDW_HW_OPS(amd_manager, send_cmd_get_resp)(amd_manager,
+ lower_data, upper_data,
+ response);
+ return -EOPNOTSUPP;
+}
+
+static inline void acp_sdw_wake_enable(struct amd_sdw_manager *amd_manager, bool enable)
+{
+ if (amd_manager && amd_manager->hw_ops && amd_manager->hw_ops->wake_enable)
+ AMD_SDW_HW_OPS(amd_manager, wake_enable)(amd_manager, enable);
+}
+
+static inline int acp_sdw_host_wake_enable(struct amd_sdw_manager *amd_manager, bool enable)
+{
+ if (amd_manager && amd_manager->hw_ops && amd_manager->hw_ops->host_wake_enable)
+ return AMD_SDW_HW_OPS(amd_manager, host_wake_enable)(amd_manager, enable);
+ return -EOPNOTSUPP;
+}
+
+static inline int acp_sdw_set_device_state(struct amd_sdw_manager *amd_manager,
+ u32 target_device_state)
+{
+ if (amd_manager && amd_manager->hw_ops && amd_manager->hw_ops->set_device_state)
+ return AMD_SDW_HW_OPS(amd_manager, set_device_state)(amd_manager,
+ target_device_state);
+ return -EOPNOTSUPP;
+}
+
+static inline void acp_sdw_read_and_process_ping_status(struct amd_sdw_manager *amd_manager)
+{
+ if (amd_manager && amd_manager->hw_ops && amd_manager->hw_ops->read_and_process_ping_status)
+ AMD_SDW_HW_OPS(amd_manager, read_and_process_ping_status)(amd_manager);
+}
+
+static inline void acp_sdw_process_wake_event(struct amd_sdw_manager *amd_manager)
+{
+ if (amd_manager && amd_manager->hw_ops && amd_manager->hw_ops->process_wake_event)
+ AMD_SDW_HW_OPS(amd_manager, process_wake_event)(amd_manager);
+}
+
+static inline void acp_sdw_irq_thread(struct amd_sdw_manager *amd_manager)
+{
+ if (amd_manager && amd_manager->hw_ops && amd_manager->hw_ops->irq_thread)
+ AMD_SDW_HW_OPS(amd_manager, irq_thread)(amd_manager);
+}
+
+static inline void acp_sdw_update_slave_status_work(struct amd_sdw_manager *amd_manager)
+{
+ if (amd_manager && amd_manager->hw_ops && amd_manager->hw_ops->update_slave_status_work)
+ AMD_SDW_HW_OPS(amd_manager, update_slave_status_work)(amd_manager);
+}
+
+static inline int acp_sdw_clk_init_ctrl(struct amd_sdw_manager *amd_manager)
+{
+ if (amd_manager && amd_manager->hw_ops && amd_manager->hw_ops->clk_init_ctrl)
+ return AMD_SDW_HW_OPS(amd_manager, clk_init_ctrl)(amd_manager);
+ return -EOPNOTSUPP;
+}
+
+static inline int acp_sdw_clock_stop_exit(struct amd_sdw_manager *amd_manager)
+{
+ if (amd_manager && amd_manager->hw_ops && amd_manager->hw_ops->clock_stop_exit)
+ return AMD_SDW_HW_OPS(amd_manager, clock_stop_exit)(amd_manager);
+ return -EOPNOTSUPP;
+}
+
+static inline int acp_sdw_suspend(struct device *dev)
+{
+ struct amd_sdw_manager *amd_manager = dev_get_drvdata(dev);
+
+ if (amd_manager && amd_manager->hw_ops && amd_manager->hw_ops->suspend)
+ return AMD_SDW_HW_OPS(amd_manager, suspend)(amd_manager);
+ return -EOPNOTSUPP;
+}
+
+static inline int acp_sdw_suspend_runtime(struct device *dev)
+{
+ struct amd_sdw_manager *amd_manager = dev_get_drvdata(dev);
+
+ if (amd_manager && amd_manager->hw_ops && amd_manager->hw_ops->suspend_runtime)
+ return AMD_SDW_HW_OPS(amd_manager, suspend_runtime)(amd_manager);
+ return -EOPNOTSUPP;
+}
+
+static inline int acp_sdw_resume_runtime(struct device *dev)
+{
+ struct amd_sdw_manager *amd_manager = dev_get_drvdata(dev);
+
+ if (amd_manager && amd_manager->hw_ops && amd_manager->hw_ops->resume_runtime)
+ return AMD_SDW_HW_OPS(amd_manager, resume_runtime)(amd_manager);
+ return -EOPNOTSUPP;
+}
+
#endif
diff --git a/include/linux/soundwire/sdw_amd.h b/include/linux/soundwire/sdw_amd.h
index 476de2c30389..cbfa3d6b3460 100644
--- a/include/linux/soundwire/sdw_amd.h
+++ b/include/linux/soundwire/sdw_amd.h
@@ -55,10 +55,13 @@ struct sdw_amd_dai_runtime {
enum sdw_stream_type stream_type;
};
+struct amd_sdw_hw_ops;
+
/**
* struct amd_sdw_manager - amd manager driver context
* @bus: bus handle
* @dev: linux device
+ * @hw_ops: pointer to hardware-revision-specific dispatch table
* @mmio: SoundWire registers mmio base
* @acp_mmio: acp registers mmio base
* @amd_sdw_irq_thread: SoundWire manager irq workqueue
@@ -85,6 +88,7 @@ struct sdw_amd_dai_runtime {
struct amd_sdw_manager {
struct sdw_bus bus;
struct device *dev;
+ const struct amd_sdw_hw_ops *hw_ops;
void __iomem *mmio;
void __iomem *acp_mmio;
--
2.48.1
next prev parent reply other threads:[~2026-09-17 9:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 9:02 [PATCH 0/9] soundwire: amd: introduce hw_ops dispatch and consolidate probe setup Vijendar Mukunda
2026-09-17 9:02 ` [PATCH 1/9] soundwire: amd: rename AMD_SDW_MAX_MANAGER_COUNT macro Vijendar Mukunda
2026-09-17 9:02 ` [PATCH 2/9] soundwire: amd: allocate pdevinfo and sdw_pdata by ACP revision in probe Vijendar Mukunda
2026-09-17 9:02 ` [PATCH 3/9] soundwire: amd: allocate sdw_amd_ctx pdev array dynamically Vijendar Mukunda
2026-10-03 7:52 ` Vinod Koul
2026-09-17 9:02 ` [PATCH 4/9] soundwire: amd: rename hardware backend functions to amd_acp63_*() prefix Vijendar Mukunda
2026-09-17 9:02 ` [PATCH 5/9] soundwire: amd: remove unused AMD_SDW_MAX_FREQ_NUM define Vijendar Mukunda
2026-09-17 9:02 ` Vijendar Mukunda [this message]
2026-10-03 7:56 ` [PATCH 6/9] soundwire: amd: introduce struct amd_sdw_hw_ops dispatch framework Vinod Koul
2026-09-17 9:02 ` [PATCH 7/9] soundwire: amd: convert irq/work handlers to hw_ops callbacks Vijendar Mukunda
2026-09-17 9:02 ` [PATCH 8/9] soundwire: amd: wire amd_acp63_*() call sites through acp_*() helpers Vijendar Mukunda
2026-09-17 9:02 ` [PATCH 9/9] soundwire: amd: consolidate revision-specific probe setup Vijendar Mukunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917090407.3828816-7-Vijendar.Mukunda@amd.com \
--to=vijendar.mukunda@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Richard.Gong@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Syed.SabaKareem@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=pierre-louis.bossart@linux.dev \
--cc=venkataprasad.potturu@amd.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®