From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B70A363C48; Thu, 17 Sep 2026 07:20:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789629642; cv=none; b=rf0Lf+6OwzazYO0mFXw4hYERbIrXf8slCCGeDCl2NFd/oA66TDztOjPZAWdQ/2LmUM49A+PPx1JZKV/oqI5+gmdHvrwMZHlwHQjT0+TeQOyP0GhTeZpUj5w3wOj+XjObTWSz4Jd8Iibjx1GPkIoaqGijUJzMqOxm2659nBanvoo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789629642; c=relaxed/simple; bh=wx2SyeWf9JRa6cDG3qjLvpIGJJwnS7Rcq5rTMoIyWUg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WNAKDInTe7QESlSRneVIBhiI0eruQ2NW3nmH4M9PoiNf+FgzYkPuPFho6btA91K3IsgyzMbExTY6U44RQbddxzIsX5Ep3OuG+LHb5m9CglOYPJ+D/cRpWhPhH1/QYbJRmrd8JRMwjnHCqX6bPyy/HXTpXh/7DNuH9dXCXsoJ4+M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=lNMP9y0s; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="lNMP9y0s" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 469D71A091E; Thu, 17 Sep 2026 07:11:58 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 12D5E5FAA3; Thu, 17 Sep 2026 07:11:58 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id E779D11C79EF2; Thu, 17 Sep 2026 09:11:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1789629116; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=v9SMgrY/6nxdHVGIqM+9vmlR0VE53yEvAwFaJ+/kk44=; b=lNMP9y0sVjOhtTt6UinCCihuLL1n93QUA3hR32zzgX6Q86t1MsbyoXpgSYkulQUYA/qvAM Ic3P7tFZb8QDRAqU8y+ZbHph2YgmDiwiHWmvxwVSd3P03OWS8l0axbmWYvPFeIahmjrUE7 tDu7Mal3dzvZsarAjS/bf1HzyGTGGFW9e4lagA+sQQJ1WNZE/I45AFNMK7UeNyNSAw3E6x LJFuTLxqqHvWeSJfFnqy5APiSkdGmqV9p7xKBUCkxbJN2OaP4aRVVdWXRJpyRmBHz19UJb XEK3WRwW65p1XBwUcrLGj+WtxZK9agtS3+mVDJbt0V037CYXEbZ1Wbvvp00L2g== Date: Thu, 17 Sep 2026 09:11:52 +0200 From: Herve Codina To: David Gibson Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Laurent Pinchart , David Lechner , Ayush Singh , Geert Uytterhoeven , devicetree-compiler@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree-spec@vger.kernel.org, Hui Pu , Ian Ray , Luca Ceresoli , Thomas Petazzoni , Frank Li Subject: Re: [PATCH v3 08/15] flattree: Handle unknown tags Message-ID: <20260917091152.7ad271a8@bootlin.com> In-Reply-To: References: <20260826083146.304291-1-herve.codina@bootlin.com> <20260826083146.304291-9-herve.codina@bootlin.com> <20260915121635.39f13d34@bootlin.com> <20260916083130.7b14e90e@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 On Wed, 16 Sep 2026 18:27:53 +1000 David Gibson wrote: > On Wed, Sep 16, 2026 at 08:31:30AM +0200, Herve Codina wrote: > > Hi David, > > > > On Tue, 15 Sep 2026 21:52:24 +1000 > > David Gibson wrote: > [snip] > > > > This avoid the need for 2 dtbs generated by treegen and also avoid to compare > > > > binary files which are difficult to analyze when the comparison detects a problem > > > > due to something broken by some modifications. > > > > > > We _want_ to understand and test things at the binary byte level. > > > Debugging differences is a little trickier, but it's really not that > > > bad - -Odts or fdtdump or dtdiff can be used if/when there's a test > > > failure. I really think doing the comparison in binary is preferable > > > - that's the level at which the behaviour is specified and should be > > > tested. > > > > Right, will see what I can do. Probably generating using two specific dtbs > > as suggested in your first proposal. > > > > Worth noting that each time a dtb will change due to, for instance, a new > > dtb version (or any other header field update), this test will need to be > > updated. DTC will generate the dtb with new headers value. > > If you use the default call for the header in treegen, which always > uses the latest version, then it should be fine. > Yes indeed. Will give a try. Best regards, Hervé