mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Sean Christopherson <seanjc@google.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	James Clark <james.clark@linaro.org>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org, Jim Mattson <jmattson@google.com>,
	Mingwei Zhang <mizhang@google.com>,
	Stephane Eranian <eranian@google.com>,
	Dapeng Mi <dapeng1.mi@linux.intel.com>
Subject: Re: [PATCH v3 0/9] perf/x86: Don't write PEBS_ENABLED on KVM transitions
Date: Thu, 17 Sep 2026 12:23:14 +0200	[thread overview]
Message-ID: <20260917102314.GI776954@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <aqLvXM5SPPlQePXs@google.com>

On Thu, Sep 10, 2026 at 10:56:44AM -0700, Sean Christopherson wrote:
> On Thu, Aug 06, 2026, Sean Christopherson wrote:
> > On Fri, May 08, 2026, Sean Christopherson wrote:
> > > Sean Christopherson (9):
> > >   perf/x86/intel: Ensure guest PEBS path doesn't set unwanted
> > >     PERF_GLOBAL_CTRL bits
> > >   perf/x86/intel: Don't write PEBS_ENABLED on host<=>guest xfers if CPU
> > >     has isolation
> > >   perf/x86/intel: Don't context switch DS_AREA (and PEBS config) if PEBS
> > >     is unused
> > >   perf/x86/intel: Make @data a mandatory param for
> > >     intel_guest_get_msrs()
> > >   perf/x86/intel: Invert names of intel_ctrl_{guest,host}_mask
> > >   perf/x86: KVM: Have perf define a dedicated struct for getting guest
> > >     PEBS data
> > >   perf/x86/intel: KVM: Handle cross-mapped PEBS PMCs entirely within KVM
> > >   KVM: VMX: Drop a redundant pmu->global_ctrl check when processing
> > >     pebs_enable
> > >   KVM: VMX: Only tell perf to enable PEBS counters for fully enabled
> > >     PMCs
> > > 
> > >  arch/x86/events/core.c            |  5 +-
> > >  arch/x86/events/intel/core.c      | 92 +++++++++++++++++++------------
> > >  arch/x86/events/intel/lbr.c       |  2 +-
> > >  arch/x86/events/perf_event.h      |  7 ++-
> > >  arch/x86/include/asm/kvm_host.h   |  9 ---
> > >  arch/x86/include/asm/perf_event.h | 11 +++-
> > >  arch/x86/kvm/vmx/pmu_intel.c      | 28 +++++++---
> > >  arch/x86/kvm/vmx/vmx.c            | 10 ++--
> > >  arch/x86/kvm/vmx/vmx.h            | 15 ++++-
> > >  9 files changed, 114 insertions(+), 65 deletions(-)
> > 
> > Ping.  This still applies on Linus' tree and against tip/master.
> 
> Ping again.  This fixes a real issue and IMO provides much-needed improvements
> for the KVM<=>perf APIs.

Right, finally got around to staring at them. How did you want them
merged?

AFAICT 2-4 have Fixes tags and should go in perf/urgent, while the rest
goes in perf/core?

/me tries and finds patch 5 doesn't apply.

  reply	other threads:[~2026-09-17 10:23 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-08 23:13 Sean Christopherson
2026-05-08 23:13 ` [PATCH v3 1/9] perf/x86/intel: Ensure guest PEBS path doesn't set unwanted PERF_GLOBAL_CTRL bits Sean Christopherson
2026-05-12  4:53   ` Mi, Dapeng
2026-05-08 23:13 ` [PATCH v3 2/9] perf/x86/intel: Don't write PEBS_ENABLED on host<=>guest xfers if CPU has isolation Sean Christopherson
2026-05-12  4:53   ` Mi, Dapeng
2026-05-08 23:13 ` [PATCH v3 3/9] perf/x86/intel: Don't context switch DS_AREA (and PEBS config) if PEBS is unused Sean Christopherson
2026-05-08 23:13 ` [PATCH v3 4/9] perf/x86/intel: Make @data a mandatory param for intel_guest_get_msrs() Sean Christopherson
2026-05-12 12:39   ` Jim Mattson
2026-05-08 23:13 ` [PATCH v3 5/9] perf/x86/intel: Invert names of intel_ctrl_{guest,host}_mask Sean Christopherson
2026-05-12  4:58   ` Mi, Dapeng
2026-05-08 23:13 ` [PATCH v3 6/9] perf/x86: KVM: Have perf define a dedicated struct for getting guest PEBS data Sean Christopherson
2026-05-08 23:13 ` [PATCH v3 7/9] perf/x86/intel: KVM: Handle cross-mapped PEBS PMCs entirely within KVM Sean Christopherson
2026-05-12  4:59   ` Mi, Dapeng
2026-05-08 23:13 ` [PATCH v3 8/9] KVM: VMX: Drop a redundant pmu->global_ctrl check when processing pebs_enable Sean Christopherson
2026-05-12  5:00   ` Mi, Dapeng
2026-05-08 23:13 ` [PATCH v3 9/9] KVM: VMX: Only tell perf to enable PEBS counters for fully enabled PMCs Sean Christopherson
2026-05-12  5:01   ` Mi, Dapeng
2026-08-06 17:18 ` [PATCH v3 0/9] perf/x86: Don't write PEBS_ENABLED on KVM transitions Sean Christopherson
2026-09-10 17:56   ` Sean Christopherson
2026-09-17 10:23     ` Peter Zijlstra [this message]
2026-09-18 16:30       ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260917102314.GI776954@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=eranian@google.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jmattson@google.com \
    --cc=jolsa@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=mizhang@google.com \
    --cc=namhyung@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®