From: Sergey Lebedev <lsa.uz@pm.me>
To: linux-media@vger.kernel.org
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans de Goede <hansg@kernel.org>,
Dan Scally <dan.scally@ideasonboard.com>,
German Pablo Lindo <germanpapulindez@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2] media: ipu-bridge: Add upside-down quirk for Surface Pro 11
Date: Thu, 17 Sep 2026 14:45:35 +0000 [thread overview]
Message-ID: <20260917144527.24804-1-lsa.uz@pm.me> (raw)
The Microsoft Surface Pro for Business 11th Edition with Intel mounts
its OV13858 rear sensor rotated 180 degrees, but reports a rotation of
0 in its SSDB and has no matching _PLD, so without a DMI quirk the
image is presented upside down.
Add a DMI quirk entry for this model so that a rotation of 180 degrees
is reported for its OVTID858 sensor.
Tested on the affected machine: camera_sensor_rotation reads 180 and
libcamera reports Rotation = 180. Confirmed independently on a second
machine of the same model, where GNOME Snapshot and Firefox present
the image the right way up once the quirk is applied; qcam, which
talks to libcamera directly, does not.
Signed-off-by: Sergey Lebedev <lsa.uz@pm.me>
Tested-by: German Pablo Lindo <germanpapulindez@gmail.com>
---
Changes in v2:
- shortened the commit message, per Sakari's review of v1
- moved the entry into vendor order, before the Samsung entries
- added German Pablo Lindo's Tested-by
v1: https://lore.kernel.org/linux-media/20260913153526.80287-1-lsa.uz@pm.me/
The quirk only has an effect once OVTID858 is a recognised sensor, which
https://lore.kernel.org/linux-media/20260913142034.5632-1-lsa.uz@pm.me/
adds; this patch applies to media/next independently of it.
drivers/media/pci/intel/ipu-bridge.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c
index 952868ad8..0e4bb9d73 100644
--- a/drivers/media/pci/intel/ipu-bridge.c
+++ b/drivers/media/pci/intel/ipu-bridge.c
@@ -210,6 +210,14 @@ static const struct dmi_system_id upside_down_sensor_dmi_ids[] = {
},
.driver_data = "SONY471A",
},
+ {
+ .matches = {
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Microsoft Corporation"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME,
+ "Surface Pro for Business 11th Edition with Intel"),
+ },
+ .driver_data = "OVTID858",
+ },
{
/* Samsung Galaxy Book5 Pro 360 */
.matches = {
--
2.54.0 (Apple Git-157)
reply other threads:[~2026-09-17 14:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917144527.24804-1-lsa.uz@pm.me \
--to=lsa.uz@pm.me \
--cc=dan.scally@ideasonboard.com \
--cc=germanpapulindez@gmail.com \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®