mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Qingshuang Fu <fuqingshuang@kylinos.cn>
Cc: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	Shuah Khan <shuah@kernel.org>,
	Willem de Bruijn <willemb@google.com>,
	Anton Danilov <littlesmilingcloud@gmail.com>,
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: net: fou_mcast_encap: conditionally load fou module and skip IPv4 case
Date: Thu, 17 Sep 2026 15:24:39 -0700	[thread overview]
Message-ID: <20260917152439.64d14833@kernel.org> (raw)
In-Reply-To: <14cff809-d338-4a95-8e7d-10759615b394@kylinos.cn>

On Thu, 17 Sep 2026 11:33:09 +0800 Qingshuang Fu wrote:
> >> +if modprobe -q fou; then
> >> +	setup_ipv4
> >> +	run_ping_test -4 eoudp4 "$TUN4_R" "FOU/GRETAP IPv4 multicast encap resubmit"
> >> +else
> >> +	log_test_skip "FOU/GRETAP IPv4 multicast encap resubmit"
> >> +fi  
> > 
> > Two very important questions you must answer before posting v2 or any
> > other similar fix:
> > 
> > Have you actually run into this or it's a result of an LLM scan?
> > 
> > How many of such fixes would we need to make all the net/ tests
> > clean from similar issues?  
> 
> I noticed it reading the script, then reproduced it on 6.8.0-138-generic.
> This Ubuntu kernel ships with CONFIG_NET_FOU=m by default. Without the fou
> module loaded, tunnel creation fails with "RTNETLINK answers: Invalid 
> argument"
> and the test reports a false failure at 0/100 packets. After applying 
> the patch
> the subtest skips cleanly.
> 
> For FOU this was the only gap. The two other net/ tests that use it
> (pmtu.sh, rtnetlink.sh) already load the module.

I did not ask about FOU

> v2 sent: drop Fixes tag and the in‑script comment as requested. Thanks 
> for the review.

I guess I wasn't clear enough. When I say "before posting v2" 
I was hoping you'd give me a chance to respond too :/

Whatever.

  reply	other threads:[~2026-09-17 22:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11 10:01 Qingshuang Fu
2026-09-17  0:40 ` Jakub Kicinski
2026-09-17  3:33   ` Qingshuang Fu
2026-09-17 22:24     ` Jakub Kicinski [this message]
2026-09-18  1:52       ` Qingshuang Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260917152439.64d14833@kernel.org \
    --to=kuba@kernel.org \
    --cc=apw@canonical.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fuqingshuang@kylinos.cn \
    --cc=horms@kernel.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=littlesmilingcloud@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®