From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: at91: Replace __ASSEMBLY__ with __ASSEMBLER__
Date: Thu, 17 Sep 2026 17:59:38 +0200 [thread overview]
Message-ID: <20260917155938d9150ac2@mail.local> (raw)
In-Reply-To: <20260821083645.200344-1-thuth@redhat.com>
On 21/08/2026 10:36:45+0200, Thomas Huth wrote:
> While the GCC and Clang compilers already define __ASSEMBLER__ auto-
> matically when compiling assembly code, __ASSEMBLY__ is a macro that
> only gets defined by the Makefiles in the kernel. This can be very
> confusing when switching between userspace and kernelspace coding, or
> when dealing with uapi headers that rather should use __ASSEMBLER__
> instead. Let's standardize now on the __ASSEMBLER__ macro to avoid
> this confusion.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> Note: This has been split from an earlier bigger patch of mine into
> a separate patch to ease reviewing
>
> arch/arm/mach-at91/pm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-at91/pm.h b/arch/arm/mach-at91/pm.h
> index 50c3a425d1400..2193e1ab98476 100644
> --- a/arch/arm/mach-at91/pm.h
> +++ b/arch/arm/mach-at91/pm.h
> @@ -25,7 +25,7 @@
> #define AT91_PM_ULP1 0x03
> #define AT91_PM_BACKUP 0x04
>
> -#ifndef __ASSEMBLY__
> +#ifndef __ASSEMBLER__
> struct at91_pm_data {
> void __iomem *pmc;
> void __iomem *ramc[2];
> --
> 2.55.0
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-09-17 15:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 8:36 Thomas Huth
2026-09-17 15:59 ` Alexandre Belloni [this message]
2026-09-19 14:45 ` claudiu beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917155938d9150ac2@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®