From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7587D52CCC5 for ; Thu, 17 Sep 2026 17:00:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789664457; cv=none; b=kUBBaTkKk6aS1UpXFjk7QjFdQ8fej9814c3/PHH62BuXZu8xF7urDsQUsXD6K1gvAgrevelzDi92w4lXh6bnJNCq4vya9LB2RxpvMxe6ndtxkOgEjoZfq1t2yk4+KkzhbRgcEAgiW5cjFigUt7wPc7JEY7cFbqZVauSDieJADH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789664457; c=relaxed/simple; bh=vi8eTtqsxG9GSme2YBKtVsSKifjeUu4TNd9QPpvTqb8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=szMA4tX/YlKQffysJzxNE5wNY5q1WWbnPp3fXSJImWJueQJQPKFQmt8PLJKp7idDZqn02ellwFCTimz2bkx2LYXK8ZaTFLz+G7UplErzN6KEHRBkn4oQ0dyrAHUC087akulIbycHapr88S1JxG//yQZg9tD+RwQNpl1XE3LhpHs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NgQaoJN5; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NgQaoJN5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1789664454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=3cUvhJCeylyKmCRzVdnpI1XudDCvPfdO1HTMEIyjjhA=; b=NgQaoJN5VQt7P6j2t/1aePKvmqwnkzfa8TmOtnlwai8myngdlpLmDB61C27XU6A6KFHQ11 gR7g7DPx/OWiUia+198qhSo4QLlhsc3Z+7+LPqC/cLl5Rh8Qpdan5Ekc+GfKLNNMqmPNVX fPUg7YDERC02btCr2xAL8MTgBlWuUTI= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-104-fL7CYz7kOVOXxBhP8eCeEA-1; Thu, 17 Sep 2026 13:00:52 -0400 X-MC-Unique: fL7CYz7kOVOXxBhP8eCeEA-1 X-Mimecast-MFC-AGG-ID: fL7CYz7kOVOXxBhP8eCeEA_1789664450 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 172EE1802554; Thu, 17 Sep 2026 17:00:50 +0000 (UTC) Received: from GoldenWind.lan (unknown [10.22.64.177]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E1D3930002C2; Thu, 17 Sep 2026 17:00:46 +0000 (UTC) From: Lyude Paul To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: "Timur Tabi" , "Dave Airlie" , "Andy Shevchenko" , "Mohamed Ahmed" , "Maarten Lankhorst" , "Kees Cook" , "Simona Vetter" , "David Airlie" , "Thomas Zimmermann" , "Maxime Ripard" , "Mel Henning" , "Hongling Zeng" , "Danilo Krummrich" , "Lyude Paul" Subject: [PATCH v5 0/5] drm/nouveau/gsp/r570: Follow OpenRM's runtime PM process more closely Date: Thu, 17 Sep 2026 12:58:31 -0400 Message-ID: <20260917170042.440276-1-lyude@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 While we have runtime PM working a lot more reliably then in the past with R570, we're still doing things a lot differently then OpenRM. For instance, we don't save/restore comptag backing stores, and we don't ask GSP whether it's OK to enter GcOff. This series fixes this, and gets our runtime PM process to look a lot closer to OpenRM's by implementing some missing pieces and workarounds. Tested on my daily-driver desktop with an AD102, a ThinkPad P17 Gen1 with a GA103GLM, a Dell Precision 7780 with an AD103, and my test machine with a GB206. Patch series based on drm-misc/drm-misc-next. Branch with patches here: https://gitlab.freedesktop.org/lyudess/linux/-/commits/nouveau/rpm-openrm-sync Previous version: https://patchwork.freedesktop.org/series/173901/ Lyude Paul (5): drm/nouveau/gsp/r570: Add support for INTERNAL_GCX_ENTRY_PREREQUISITE drm/nouveau/gsp/r535: Add support for MEMSYS_GET_STATIC_CONFIG drm/nouveau/gsp/r570: Add comp mode workaround from issue #3172217 drm/nouveau/gsp/r570: Start saving comptag backing stores drm/nouveau/gsp/r570: Enable Gcoff in fbsr again drivers/gpu/drm/nouveau/include/nvif/cl0080.h | 10 +++ drivers/gpu/drm/nouveau/include/nvif/device.h | 1 + .../gpu/drm/nouveau/include/nvkm/subdev/gsp.h | 6 ++ drivers/gpu/drm/nouveau/nouveau_drm.c | 13 ++++ drivers/gpu/drm/nouveau/nvif/device.c | 13 ++++ .../gpu/drm/nouveau/nvkm/engine/device/user.c | 35 +++++++++ .../gpu/drm/nouveau/nvkm/subdev/gsp/base.c | 10 +++ .../gpu/drm/nouveau/nvkm/subdev/gsp/priv.h | 1 + .../drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c | 17 ++++ .../nvkm/subdev/gsp/rm/r535/nvrm/gsp.h | 45 +++++++++++ .../nouveau/nvkm/subdev/gsp/rm/r570/fbsr.c | 77 ++++++++++++++++++- .../drm/nouveau/nvkm/subdev/gsp/rm/r570/gsp.c | 36 +++++++++ .../nvkm/subdev/gsp/rm/r570/nvrm/fbsr.h | 29 +++++++ .../nvkm/subdev/gsp/rm/r570/nvrm/gsp.h | 7 ++ .../gpu/drm/nouveau/nvkm/subdev/gsp/rm/rm.h | 3 + 15 files changed, 301 insertions(+), 2 deletions(-) base-commit: 5535d5e61a77ad79118ea7665ce1c14f857f0f12 -- 2.55.0