From: Heiko Carstens <hca@linux.ibm.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
David Hildenbrand <david@kernel.org>,
Vasily Gorbik <gor@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/uv: Rework page allocation for guest variable storage area
Date: Thu, 17 Sep 2026 21:35:40 +0200 [thread overview]
Message-ID: <20260917193540.13842A26-hca@linux.ibm.com> (raw)
In-Reply-To: <1a53b72c-b215-496c-b9f0-04f3afd09693-agordeev@linux.ibm.com>
On Thu, Sep 17, 2026 at 12:26:55PM +0200, Alexander Gordeev wrote:
> On Tue, Sep 15, 2026 at 04:43:07PM +0200, Heiko Carstens wrote:
> Hi Heiko,
> ...
> > + for (i = 0; i < nr_pages; i++) {
> > + pages[i] = alloc_page(GFP_KERNEL_ACCOUNT | __GFP_ZERO);
> > + if (!pages[i])
> > + goto free_pages;
> > + }
> ...
> > + for (i = 0; i < nr_pages; i++) {
> > + if (pages[i])
> > + __free_page(pages[i]);
> > + }
>
> Why not alloc_pages_bulk()/free_pages_bulk()?
That's because alloc_pages_bulk() contains this:
/* Bulk allocator does not support memcg accounting. */
if (memcg_kmem_online() && (gfp & __GFP_ACCOUNT))
goto failed;
Which does not work with GFP_KERNEL_ACCOUNT.
next prev parent reply other threads:[~2026-09-17 19:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 14:43 Heiko Carstens
2026-09-17 10:26 ` Alexander Gordeev
2026-09-17 19:35 ` Heiko Carstens [this message]
2026-09-18 11:43 ` Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917193540.13842A26-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@kernel.org \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®